Re: [PATCH v2] drm/bridge: ti-sn65dsi86: make use of debugfs_init callback

2025-03-24 Thread Doug Anderson
Hi, On Mon, Mar 17, 2025 at 7:33 AM Doug Anderson wrote: > > Hi, > > On Sat, Mar 15, 2025 at 1:17 PM Wolfram Sang > wrote: > > > > Do not create a custom directory in debugfs-root, but use the > > debugfs_init callback to create a custom directory at the given place > > for the bridge. The new d

Re: [PATCH v2] drm/bridge: ti-sn65dsi86: make use of debugfs_init callback

2025-03-17 Thread Doug Anderson
Hi, On Sat, Mar 15, 2025 at 1:17 PM Wolfram Sang wrote: > > Do not create a custom directory in debugfs-root, but use the > debugfs_init callback to create a custom directory at the given place > for the bridge. The new directory layout looks like this on a Renesas > GrayHawk-Single with a R-Car

Re: [PATCH v2] drm/bridge: ti-sn65dsi86: make use of debugfs_init callback

2025-03-16 Thread Dmitry Baryshkov
On Sun, Mar 16, 2025 at 11:47:04AM +0100, Wolfram Sang wrote: > > > > Just to make sure: there can only be one bridge, right? Because the > > > suggested name is not unique. > > > > Bridges can be chained. It's highly unlikely that a chain would contain > > multiple bridges of the same model, as

Re: [PATCH v2] drm/bridge: ti-sn65dsi86: make use of debugfs_init callback

2025-03-16 Thread Wolfram Sang
> > Just to make sure: there can only be one bridge, right? Because the > > suggested name is not unique. > > Bridges can be chained. It's highly unlikely that a chain would contain > multiple bridges of the same model, as that would be quite pointless, > but in theory it could happen. Thanks fo

Re: [PATCH v2] drm/bridge: ti-sn65dsi86: make use of debugfs_init callback

2025-03-16 Thread Laurent Pinchart
On Sun, Mar 16, 2025 at 08:10:03AM +0100, Wolfram Sang wrote: > > > We don't have a practice yet. Keeping dev_name() was Doug's suggestion. > > But I like your idea better, so I will change to it. Thank you for it! > > Just to make sure: there can only be one bridge, right? Because the > suggeste

Re: [PATCH v2] drm/bridge: ti-sn65dsi86: make use of debugfs_init callback

2025-03-16 Thread Wolfram Sang
> We don't have a practice yet. Keeping dev_name() was Doug's suggestion. > But I like your idea better, so I will change to it. Thank you for it! Just to make sure: there can only be one bridge, right? Because the suggested name is not unique. signature.asc Description: PGP signature

Re: [PATCH v2] drm/bridge: ti-sn65dsi86: make use of debugfs_init callback

2025-03-15 Thread Wolfram Sang
On Sun, Mar 16, 2025 at 12:43:48AM +0200, Dmitry Baryshkov wrote: > On Sat, Mar 15, 2025 at 09:15:11PM +0100, Wolfram Sang wrote: > > Do not create a custom directory in debugfs-root, but use the > > debugfs_init callback to create a custom directory at the given place > > for the bridge. The new d

Re: [PATCH v2] drm/bridge: ti-sn65dsi86: make use of debugfs_init callback

2025-03-15 Thread Dmitry Baryshkov
On Sat, Mar 15, 2025 at 09:15:11PM +0100, Wolfram Sang wrote: > Do not create a custom directory in debugfs-root, but use the > debugfs_init callback to create a custom directory at the given place > for the bridge. The new directory layout looks like this on a Renesas > GrayHawk-Single with a R-Ca

[PATCH v2] drm/bridge: ti-sn65dsi86: make use of debugfs_init callback

2025-03-15 Thread Wolfram Sang
Do not create a custom directory in debugfs-root, but use the debugfs_init callback to create a custom directory at the given place for the bridge. The new directory layout looks like this on a Renesas GrayHawk-Single with a R-Car V4M SoC: /sys/kernel/debug/dri/feb0.display/DP-1/1-002c