[PATCH v2] drm/bridge: adv7511: Remove unused code blocks

Thanks for comments. On 10/20/2016 2:15 PM, Wolfram Sang wrote: >>> IMO it would be better to use id->driver_data unconditionally and save a >>> call to of_device_get_match_data() >>> What would you suggest to move ahead? >> I'd suggest using id->driver_data unconditionally, but I'd like Wolfram'

[PATCH v2] drm/bridge: adv7511: Remove unused code blocks

> Should we leave as it is, redundant if-else code block also, or fix it as > posted in patch v2 Leave it. -- next part -- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 819 bytes Desc: not available URL:

[PATCH v2] drm/bridge: adv7511: Remove unused code blocks

> > IMO it would be better to use id->driver_data unconditionally and save a > > call to of_device_get_match_data() > > What would you suggest to move ahead? > > I'd suggest using id->driver_data unconditionally, but I'd like Wolfram's > opinion on this (CC'ed). IIUC: I'd suggest to leave it as

[PATCH v2] drm/bridge: adv7511: Remove unused code blocks

Hi Jitendra, On Wednesday 19 Oct 2016 19:11:27 Sharma, Jitendra wrote: > On 10/19/2016 7:03 PM, Laurent Pinchart wrote: > > On Wednesday 19 Oct 2016 18:37:38 Sharma, Jitendra wrote: > >> On 10/19/2016 5:21 PM, Laurent Pinchart wrote: > >>> On Wednesday 19 Oct 2016 17:12:48 Jitendra Sharma wrote: >

[PATCH v2] drm/bridge: adv7511: Remove unused code blocks

Hi Laurent, On 10/19/2016 7:03 PM, Laurent Pinchart wrote: > Hi Jitendra, > > On Wednesday 19 Oct 2016 18:37:38 Sharma, Jitendra wrote: >> On 10/19/2016 5:21 PM, Laurent Pinchart wrote: >>> On Wednesday 19 Oct 2016 17:12:48 Jitendra Sharma wrote: Remove redundant condition check Remove

[PATCH v2] drm/bridge: adv7511: Remove unused code blocks

Hi., On 10/19/2016 6:37 PM, Sharma, Jitendra wrote: > Hi Laurent, > > > On 10/19/2016 5:21 PM, Laurent Pinchart wrote: >> Hi Jitendra, >> >> Thank you for the patch. >> >> On Wednesday 19 Oct 2016 17:12:48 Jitendra Sharma wrote: >>> Remove redundant condition check >>> Remove not necessary if-else

[PATCH v2] drm/bridge: adv7511: Remove unused code blocks

Hi Laurent, On 10/19/2016 5:21 PM, Laurent Pinchart wrote: > Hi Jitendra, > > Thank you for the patch. > > On Wednesday 19 Oct 2016 17:12:48 Jitendra Sharma wrote: >> Remove redundant condition check >> Remove not necessary if-else block for checking DT entry because else >> part will never be pi

[PATCH v2] drm/bridge: adv7511: Remove unused code blocks

Remove redundant condition check Remove not necessary if-else block for checking DT entry because else part will never be picked as in absence of device node, probe will fail in initial stage only. Remove unused id->driver_data entries As id->driver_data is not used in driver source. So no need in

[PATCH v2] drm/bridge: adv7511: Remove unused code blocks

Hi Jitendra, On Wednesday 19 Oct 2016 18:37:38 Sharma, Jitendra wrote: > On 10/19/2016 5:21 PM, Laurent Pinchart wrote: > > On Wednesday 19 Oct 2016 17:12:48 Jitendra Sharma wrote: > >> Remove redundant condition check > >> Remove not necessary if-else block for checking DT entry because else > >>

[PATCH v2] drm/bridge: adv7511: Remove unused code blocks

Hi Jitendra, Thank you for the patch. On Wednesday 19 Oct 2016 17:12:48 Jitendra Sharma wrote: > Remove redundant condition check > Remove not necessary if-else block for checking DT entry because else > part will never be picked as in absence of device node, probe will > fail in initial stage on