Re: [PATCH v2] drm/ast: astdp: fix loop timeout check

2024-08-12 Thread Dan Carpenter
On Mon, Aug 12, 2024 at 09:30:00AM +0200, Thomas Zimmermann wrote: > > I feel like if we really hit this failure path then we won't care about the > > tenth msleep(). I can resend if you want, but I'd prefer to just leave it. > > Please resend. Even if the link training ultimately fails, the rest

Re: [PATCH v2] drm/ast: astdp: fix loop timeout check

2024-08-12 Thread Thomas Zimmermann
Hi Am 12.08.24 um 08:54 schrieb Dan Carpenter: On Mon, Aug 12, 2024 at 08:48:16AM +0200, Thomas Zimmermann wrote: Hi Am 12.08.24 um 08:42 schrieb Dan Carpenter: This code has an issue because it loops until "i" is set to UINT_MAX but the test for failure assumes that "i" is set to zero. The

Re: [PATCH v2] drm/ast: astdp: fix loop timeout check

2024-08-11 Thread Dan Carpenter
On Mon, Aug 12, 2024 at 08:48:16AM +0200, Thomas Zimmermann wrote: > Hi > > Am 12.08.24 um 08:42 schrieb Dan Carpenter: > > This code has an issue because it loops until "i" is set to UINT_MAX but > > the test for failure assumes that "i" is set to zero. The result is that > > it will only print

Re: [PATCH v2] drm/ast: astdp: fix loop timeout check

2024-08-11 Thread Dan Carpenter
On Mon, Aug 12, 2024 at 09:42:53AM +0300, Dan Carpenter wrote: > This code has an issue because it loops until "i" is set to UINT_MAX but > the test for failure assumes that "i" is set to zero. The result is that > it will only print an error message if we succeed on the very last try. > Reformat

Re: [PATCH v2] drm/ast: astdp: fix loop timeout check

2024-08-11 Thread Thomas Zimmermann
Hi Am 12.08.24 um 08:42 schrieb Dan Carpenter: This code has an issue because it loops until "i" is set to UINT_MAX but the test for failure assumes that "i" is set to zero. The result is that it will only print an error message if we succeed on the very last try. Reformat the loop to count for

[PATCH v2] drm/ast: astdp: fix loop timeout check

2024-08-11 Thread Dan Carpenter
This code has an issue because it loops until "i" is set to UINT_MAX but the test for failure assumes that "i" is set to zero. The result is that it will only print an error message if we succeed on the very last try. Reformat the loop to count forwards instead of backwards. Fixes: 2281475168d2 (