Re: [PATCH v2] drm/ast: Fix start address computation

2023-02-09 Thread Jocelyn Falempe
On 09/02/2023 10:35, Thomas Zimmermann wrote: Hi Am 09.02.23 um 10:22 schrieb Jammy Huang: Hello, The offset given to ast_set_start_address_crt1() should be offset in vram. It should 0 now as your patch. I think it is better to correct it in ast_primary_plane_init() and ast_cursor_plane_in

Re: [PATCH v2] drm/ast: Fix start address computation

2023-02-09 Thread Thomas Zimmermann
Hi Am 09.02.23 um 10:22 schrieb Jammy Huang: Hello, The offset given to ast_set_start_address_crt1() should be offset in vram. It should 0 now as your patch. I think it is better to correct it in ast_primary_plane_init() and ast_cursor_plane_init() as below. I was about to write the same.

Re: [PATCH v2] drm/ast: Fix start address computation

2023-02-09 Thread Jammy Huang
Hello, The offset given to ast_set_start_address_crt1() should be offset in vram. It should 0 now as your patch. I think it is better to correct it in ast_primary_plane_init() and ast_cursor_plane_init() as below. --- a/drivers/gpu/drm/ast/ast_mode.c +++ b/drivers/gpu/drm/ast/ast_mode.c @@

Re: [PATCH v2] drm/ast: Fix start address computation

2023-02-09 Thread Jocelyn Falempe
On 09/02/2023 10:22, Jammy Huang wrote: Hello, The offset given to ast_set_start_address_crt1() should be offset in vram. It should 0 now as your patch. I think it is better to correct it in ast_primary_plane_init() and ast_cursor_plane_init() as below. ok, thanks for the review, I will se

[PATCH v2] drm/ast: Fix start address computation

2023-02-09 Thread Jocelyn Falempe
During the driver conversion to shmem, the start address for the scanout buffer was set to the base PCI address. In most cases it works because only the lower 24bits are used, and due to alignment it was almost always 0. But on some unlucky hardware, it's not the case, and some unitilized memory is