Re:Re: Re:Re: [PATCH v2] drm/arm: fixes pixel clock enabled with wrong format

2020-05-18 Thread Bernard
发件人:Liviu Dudau 发送日期:2020-05-15 22:41:49 收件人:Bernard 抄送人:Brian Starkey ,David Airlie ,Daniel Vetter ,dri-devel@lists.freedesktop.org,linux-ker...@vger.kernel.org,opensource.ker...@vivo.com 主题:Re: Re:Re: [PATCH v2] drm/arm: fixes pixel clock enabled with wrong format>Hi Bernard, > &

Re: Re:Re: [PATCH v2] drm/arm: fixes pixel clock enabled with wrong format

2020-05-15 Thread Liviu Dudau
..@vivo.com > Subject: Re:Re: [PATCH v2] drm/arm: fixes pixel clock enabled with wrong > format > > > > > From: Liviu Dudau > Date: 2020-04-24 19:09:50 > To: Bernard Zhao > Cc: Brian Starkey ,David Airlie > ,Daniel Vetter > ,dri-devel@lists.freedes

Re:Re:Re: [PATCH v2] drm/arm: fixes pixel clock enabled with wrong format

2020-05-09 Thread Bernard
From: "赵军奎" Date: 2020-04-24 19:37:36 To: Liviu Dudau Cc: Brian Starkey ,David Airlie ,Daniel Vetter ,dri-devel@lists.freedesktop.org,linux-ker...@vger.kernel.org,opensource.ker...@vivo.com Subject: Re:Re: [PATCH v2] drm/arm: fixes pixel clock enabled with wrong format From: L

Re:Re: [PATCH v2] drm/arm: fixes pixel clock enabled with wrong format

2020-04-24 Thread 赵军奎
From: Liviu Dudau Date: 2020-04-24 19:09:50 To: Bernard Zhao Cc: Brian Starkey ,David Airlie ,Daniel Vetter ,dri-devel@lists.freedesktop.org,linux-ker...@vger.kernel.org,opensource.ker...@vivo.com Subject: Re: [PATCH v2] drm/arm: fixes pixel clock enabled with wrong format>Hi Bern

Re: [PATCH v2] drm/arm: fixes pixel clock enabled with wrong format

2020-04-24 Thread Liviu Dudau
Hi Bernand, On Thu, Apr 23, 2020 at 11:35:51PM -0700, Bernard Zhao wrote: > The pixel clock is still enabled when the format is wrong. > no error branch handle, and also some register is not set > in this case, e.g: HDLCD_REG__SELECT. Maybe we > should disable this clock and throw an warn message

Re: [PATCH v2] drm/arm: fixes pixel clock enabled with wrong format

2020-04-24 Thread Emil Velikov
Hi Bernard, On Fri, 24 Apr 2020 at 08:15, Bernard Zhao wrote: > > The pixel clock is still enabled when the format is wrong. > no error branch handle, and also some register is not set > in this case, e.g: HDLCD_REG__SELECT. Maybe we > should disable this clock and throw an warn message when > th

[PATCH v2] drm/arm: fixes pixel clock enabled with wrong format

2020-04-24 Thread Bernard Zhao
The pixel clock is still enabled when the format is wrong. no error branch handle, and also some register is not set in this case, e.g: HDLCD_REG__SELECT. Maybe we should disable this clock and throw an warn message when this happened. With this change, the code maybe a bit more readable. Signed-o