Re: [PATCH v2] drivers/firmware: fix SYSFB depends to prevent build failures

2021-07-27 Thread Javier Martinez Canillas
Hello Geert, On 7/27/21 1:39 PM, Geert Uytterhoeven wrote: [snip] >>> Perhaps SYSFB should be selected by SYSFB_SIMPLEFB, FB_VESA, >>> and FB_EFI? >> >> It's another option, yes. I just thought that the use of select was not >> encouraged and using depends was less fragile / error prone. > > Se

Re: [PATCH v2] drivers/firmware: fix SYSFB depends to prevent build failures

2021-07-27 Thread Mark Brown
On Tue, Jul 27, 2021 at 01:32:29PM +0200, Javier Martinez Canillas wrote: > On 7/27/21 1:17 PM, Geert Uytterhoeven wrote: > > Do all (embedded) EFI systems have a frame buffer? > That's a good question. I don't know if all EFI firmwares are expected > to provide a GOP or not. But even the u-boot

Re: [PATCH v2] drivers/firmware: fix SYSFB depends to prevent build failures

2021-07-27 Thread Geert Uytterhoeven
Hi Javier, On Tue, Jul 27, 2021 at 1:32 PM Javier Martinez Canillas wrote: > On 7/27/21 1:17 PM, Geert Uytterhoeven wrote: > >> Not enabling this, would mean that a platform device to match a driver > >> supporting the EFI GOP framebuffer (e.g: simple{drm,fb} or efifb) will > >> not be registered

Re: [PATCH v2] drivers/firmware: fix SYSFB depends to prevent build failures

2021-07-27 Thread Javier Martinez Canillas
On 7/27/21 1:17 PM, Geert Uytterhoeven wrote: [snip] >> Not enabling this, would mean that a platform device to match a driver >> supporting the EFI GOP framebuffer (e.g: simple{drm,fb} or efifb) will >> not be registered. Which will lead to not having an early framebuffer. > > Do all (embedded)

Re: [PATCH v2] drivers/firmware: fix SYSFB depends to prevent build failures

2021-07-27 Thread Geert Uytterhoeven
Hi Javier, On Tue, Jul 27, 2021 at 12:22 PM Javier Martinez Canillas wrote: > On 7/27/21 12:03 PM, Geert Uytterhoeven wrote: > >> --- a/drivers/firmware/Kconfig > >> +++ b/drivers/firmware/Kconfig > >> @@ -254,7 +254,7 @@ config QCOM_SCM_DOWNLOAD_MODE_DEFAULT > >> config SYSFB > >> bool

Re: [PATCH v2] drivers/firmware: fix SYSFB depends to prevent build failures

2021-07-27 Thread Javier Martinez Canillas
Hello Geert, On 7/27/21 12:03 PM, Geert Uytterhoeven wrote: [snip] > Thanks for your patch! > You are welcome. >> --- a/drivers/firmware/Kconfig >> +++ b/drivers/firmware/Kconfig >> @@ -254,7 +254,7 @@ config QCOM_SCM_DOWNLOAD_MODE_DEFAULT >> config SYSFB >> bool >> default y

Re: [PATCH v2] drivers/firmware: fix SYSFB depends to prevent build failures

2021-07-27 Thread Geert Uytterhoeven
Hi Javier, On Tue, Jul 27, 2021 at 11:33 AM Javier Martinez Canillas wrote: > The Generic System Framebuffers support is built when the COMPILE_TEST > option is enabled. But this wrongly assumes that all the architectures > declare a struct screen_info. > > This is true for most architectures, bu

Re: [PATCH v2] drivers/firmware: fix SYSFB depends to prevent build failures

2021-07-27 Thread Daniel Vetter
On Tue, Jul 27, 2021 at 11:30:15AM +0200, Javier Martinez Canillas wrote: > The Generic System Framebuffers support is built when the COMPILE_TEST > option is enabled. But this wrongly assumes that all the architectures > declare a struct screen_info. > > This is true for most architectures, but a

[PATCH v2] drivers/firmware: fix SYSFB depends to prevent build failures

2021-07-27 Thread Javier Martinez Canillas
The Generic System Framebuffers support is built when the COMPILE_TEST option is enabled. But this wrongly assumes that all the architectures declare a struct screen_info. This is true for most architectures, but at least the following do not: arc, m68k, microblaze, openrisc, parisc and s390. By