Re: [PATCH v2] backlight: pwm_bl: Don't assign levels table repeatedly

2019-10-16 Thread Lee Jones
On Wed, 02 Oct 2019, Matthias Kaehlcke wrote: > pwm_backlight_probe() re-assigns pb->levels for every brightness > level. This is not needed and was likely not intended, since > neither side of the assignment changes during the loop. Assign > the field only once. > > Signed-off-by: Matthias Kaehl

Re: [PATCH v2] backlight: pwm_bl: Don't assign levels table repeatedly

2019-10-03 Thread Daniel Thompson
On Wed, Oct 02, 2019 at 09:56:01AM -0700, Matthias Kaehlcke wrote: > pwm_backlight_probe() re-assigns pb->levels for every brightness > level. This is not needed and was likely not intended, since > neither side of the assignment changes during the loop. Assign > the field only once. > > Signed-of

[PATCH v2] backlight: pwm_bl: Don't assign levels table repeatedly

2019-10-02 Thread Matthias Kaehlcke
pwm_backlight_probe() re-assigns pb->levels for every brightness level. This is not needed and was likely not intended, since neither side of the assignment changes during the loop. Assign the field only once. Signed-off-by: Matthias Kaehlcke --- Changes in v2: - removed curly braces from for lo