Re: [PATCH v18 15/26] drm/panfrost: Explicitly get and put drm-shmem pages

2023-11-24 Thread Boris Brezillon
On Thu, 23 Nov 2023 15:48:48 +0100 Boris Brezillon wrote: > On Mon, 30 Oct 2023 02:01:54 +0300 > Dmitry Osipenko wrote: > > > To simplify the drm-shmem refcnt handling, we're moving away from > > the implicit get_pages() that is used by get_pages_sgt(). From now on > > drivers will have to pin

Re: [PATCH v18 15/26] drm/panfrost: Explicitly get and put drm-shmem pages

2023-11-23 Thread Boris Brezillon
On Mon, 30 Oct 2023 02:01:54 +0300 Dmitry Osipenko wrote: > To simplify the drm-shmem refcnt handling, we're moving away from > the implicit get_pages() that is used by get_pages_sgt(). From now on > drivers will have to pin pages while they use sgt. Panfrost's shrinker > doesn't support swapping

Re: [PATCH v18 15/26] drm/panfrost: Explicitly get and put drm-shmem pages

2023-11-23 Thread Boris Brezillon
On Thu, 23 Nov 2023 15:24:32 +0300 Dmitry Osipenko wrote: > On 11/23/23 12:05, Boris Brezillon wrote: > > On Thu, 23 Nov 2023 01:04:56 +0300 > > Dmitry Osipenko wrote: > > > >> On 11/10/23 13:53, Boris Brezillon wrote: > >>> Hm, there was no drm_gem_shmem_get_pages_sgt() call here, why > >>

Re: [PATCH v18 15/26] drm/panfrost: Explicitly get and put drm-shmem pages

2023-11-23 Thread Dmitry Osipenko
On 11/23/23 12:05, Boris Brezillon wrote: > On Thu, 23 Nov 2023 01:04:56 +0300 > Dmitry Osipenko wrote: > >> On 11/10/23 13:53, Boris Brezillon wrote: >>> Hm, there was no drm_gem_shmem_get_pages_sgt() call here, why should we >>> add a drm_gem_shmem_get_pages()? What we should do instead is add

Re: [PATCH v18 15/26] drm/panfrost: Explicitly get and put drm-shmem pages

2023-11-23 Thread Boris Brezillon
On Thu, 23 Nov 2023 01:04:56 +0300 Dmitry Osipenko wrote: > On 11/10/23 13:53, Boris Brezillon wrote: > > Hm, there was no drm_gem_shmem_get_pages_sgt() call here, why should we > > add a drm_gem_shmem_get_pages()? What we should do instead is add a > > drm_gem_shmem_get_pages() for each drm_gem_

Re: [PATCH v18 15/26] drm/panfrost: Explicitly get and put drm-shmem pages

2023-11-22 Thread Dmitry Osipenko
On 11/10/23 13:53, Boris Brezillon wrote: > Hm, there was no drm_gem_shmem_get_pages_sgt() call here, why should we > add a drm_gem_shmem_get_pages()? What we should do instead is add a > drm_gem_shmem_get_pages() for each drm_gem_shmem_get_pages_sgt() we > have in the driver (in panfrost_mmu_map()

Re: [PATCH v18 15/26] drm/panfrost: Explicitly get and put drm-shmem pages

2023-11-10 Thread Boris Brezillon
On Mon, 30 Oct 2023 02:01:54 +0300 Dmitry Osipenko wrote: > To simplify the drm-shmem refcnt handling, we're moving away from > the implicit get_pages() that is used by get_pages_sgt(). From now on > drivers will have to pin pages while they use sgt. Panfrost's shrinker > doesn't support swapping

[PATCH v18 15/26] drm/panfrost: Explicitly get and put drm-shmem pages

2023-10-29 Thread Dmitry Osipenko
To simplify the drm-shmem refcnt handling, we're moving away from the implicit get_pages() that is used by get_pages_sgt(). From now on drivers will have to pin pages while they use sgt. Panfrost's shrinker doesn't support swapping out BOs, hence pages are pinned and sgt is valid as long as pages'