Re: [PATCH v17 4/8] drm: bridge: Cadence: Add MHDP8501 DP/HDMI driver

2024-10-24 Thread Sandor Yu
> > On Mon, Sep 30, 2024 at 10:18:06AM +0200, Maxime Ripard wrote: > > On Sun, Sep 29, 2024 at 02:34:36AM GMT, Sandor Yu wrote: > > > > > +static void cdns_hdmi_sink_config(struct cdns_mhdp8501_device > > > > > +*mhdp) { > > > > > + struct drm_display_info *display = > &mhdp->curr_conn->displ

Re: [PATCH v17 4/8] drm: bridge: Cadence: Add MHDP8501 DP/HDMI driver

2024-10-19 Thread Dmitry Baryshkov
On Mon, Sep 30, 2024 at 10:18:06AM +0200, Maxime Ripard wrote: > On Sun, Sep 29, 2024 at 02:34:36AM GMT, Sandor Yu wrote: > > > > +static void cdns_hdmi_sink_config(struct cdns_mhdp8501_device *mhdp) > > > > +{ > > > > + struct drm_display_info *display = > > > > &mhdp->curr_conn->display_in

Re: [PATCH v17 4/8] drm: bridge: Cadence: Add MHDP8501 DP/HDMI driver

2024-09-30 Thread Maxime Ripard
On Sun, Sep 29, 2024 at 02:34:36AM GMT, Sandor Yu wrote: > > > +static void cdns_hdmi_sink_config(struct cdns_mhdp8501_device *mhdp) > > > +{ > > > + struct drm_display_info *display = &mhdp->curr_conn->display_info; > > > + struct drm_connector_state *conn_state = mhdp->curr_conn->state; > > > >

Re: [PATCH v17 4/8] drm: bridge: Cadence: Add MHDP8501 DP/HDMI driver

2024-09-28 Thread Sandor Yu
Hi Maxime, Thanks for your comments. > > On Tue, Sep 24, 2024 at 03:36:49PM GMT, Sandor Yu wrote: > > +static int cdns_mhdp8501_read_hpd(struct cdns_mhdp8501_device > *mhdp) > > +{ > > + u8 status; > > + int ret; > > + > > + mutex_lock(&mhdp_mailbox_mutex); > > + > > + ret = cdns_mhdp_ma

Re: [PATCH v17 4/8] drm: bridge: Cadence: Add MHDP8501 DP/HDMI driver

2024-09-28 Thread Sandor Yu
Hi Dmitry, Thanks for your comments, > > On Tue, Sep 24, 2024 at 12:16:27PM GMT, Maxime Ripard wrote: > > On Tue, Sep 24, 2024 at 03:36:49PM GMT, Sandor Yu wrote: > > > +static int cdns_mhdp8501_read_hpd(struct cdns_mhdp8501_device > > > +*mhdp) { > > > + u8 status; > > > + int ret; > > > +

Re: [PATCH v17 4/8] drm: bridge: Cadence: Add MHDP8501 DP/HDMI driver

2024-09-24 Thread Dmitry Baryshkov
On Tue, Sep 24, 2024 at 12:16:27PM GMT, Maxime Ripard wrote: > On Tue, Sep 24, 2024 at 03:36:49PM GMT, Sandor Yu wrote: > > +static int cdns_mhdp8501_read_hpd(struct cdns_mhdp8501_device *mhdp) > > +{ > > + u8 status; > > + int ret; > > + > > + mutex_lock(&mhdp_mailbox_mutex); > > + > > + r

Re: [PATCH v17 4/8] drm: bridge: Cadence: Add MHDP8501 DP/HDMI driver

2024-09-24 Thread Maxime Ripard
On Tue, Sep 24, 2024 at 03:36:49PM GMT, Sandor Yu wrote: > +static int cdns_mhdp8501_read_hpd(struct cdns_mhdp8501_device *mhdp) > +{ > + u8 status; > + int ret; > + > + mutex_lock(&mhdp_mailbox_mutex); > + > + ret = cdns_mhdp_mailbox_send(&mhdp->base, MB_MODULE_ID_GENERAL, > +

[PATCH v17 4/8] drm: bridge: Cadence: Add MHDP8501 DP/HDMI driver

2024-09-24 Thread Sandor Yu
Add a new DRM DisplayPort and HDMI bridge driver for Candence MHDP8501 used in i.MX8MQ SOC. MHDP8501 could support HDMI or DisplayPort standards according embedded Firmware running in the uCPU. For iMX8MQ SOC, the DisplayPort/HDMI FW was loaded and activated by SOC's ROM code. Bootload binary incl