Re: [PATCH v16 4/4] drm/bridge: dw-hdmi: fix bus formats negotiation for 8 bit modes

Hi, On 03/03/2022 16:37, H. Nikolaus Schaller wrote: Hi Neil, Am 03.03.2022 um 12:45 schrieb H. Nikolaus Schaller : Hi Neil, Am 03.03.2022 um 12:42 schrieb Neil Armstrong : So how can we get that merged? IMHO your proposal should be before we add ingenic-dw-hdmi. If you have a version wi

Re: [PATCH v16 4/4] drm/bridge: dw-hdmi: fix bus formats negotiation for 8 bit modes

Hi Neil, > Am 03.03.2022 um 12:45 schrieb H. Nikolaus Schaller : > > Hi Neil, > >> Am 03.03.2022 um 12:42 schrieb Neil Armstrong : >> >>> So how can we get that merged? IMHO your proposal should be before we add >>> ingenic-dw-hdmi. >>> If you have a version with proper commit message I can ad

Re: [PATCH v16 4/4] drm/bridge: dw-hdmi: fix bus formats negotiation for 8 bit modes

Hi Neil, Any feedback on the other patches? They look fine to me, but I still need an ack to merge them in drm-misc-next. Cheers, -Paul Le jeu., mars 3 2022 at 12:42:02 +0100, Neil Armstrong a écrit : On 03/03/2022 11:40, H. Nikolaus Schaller wrote: Hi Neil, Am 03.03.2022 um 09:35 schr

Re: [PATCH v16 4/4] drm/bridge: dw-hdmi: fix bus formats negotiation for 8 bit modes

Hi Neil, > Am 03.03.2022 um 12:42 schrieb Neil Armstrong : > >> So how can we get that merged? IMHO your proposal should be before we add >> ingenic-dw-hdmi. >> If you have a version with proper commit message I can add it to the >> beginning of my >> seried and include it in a v17. Or if you g

Re: [PATCH v16 4/4] drm/bridge: dw-hdmi: fix bus formats negotiation for 8 bit modes

On 03/03/2022 11:40, H. Nikolaus Schaller wrote: Hi Neil, Am 03.03.2022 um 09:35 schrieb Neil Armstrong : Hi, On 02/03/2022 23:24, H. Nikolaus Schaller wrote: Hi Neil, Am 02.03.2022 um 15:34 schrieb Neil Armstrong : Hi, (cross-checked: RGB mode still works if I force hdmi->sink_is_hdmi =

Re: [PATCH v16 4/4] drm/bridge: dw-hdmi: fix bus formats negotiation for 8 bit modes

Hi Neil, > Am 03.03.2022 um 09:35 schrieb Neil Armstrong : > > Hi, > > On 02/03/2022 23:24, H. Nikolaus Schaller wrote: >> Hi Neil, >>> Am 02.03.2022 um 15:34 schrieb Neil Armstrong : >>> >>> Hi, >>> (cross-checked: RGB mode still works if I force hdmi->sink_is_hdmi = false) >>> >>> I do

Re: [PATCH v16 4/4] drm/bridge: dw-hdmi: fix bus formats negotiation for 8 bit modes

Hi, On 02/03/2022 23:24, H. Nikolaus Schaller wrote: Hi Neil, Am 02.03.2022 um 15:34 schrieb Neil Armstrong : Hi, (cross-checked: RGB mode still works if I force hdmi->sink_is_hdmi = false) I don't understand what's wrong, can you try to make the logic select MEDIA_BUS_FMT_YUV8_1X24 inst

Re: [PATCH v16 4/4] drm/bridge: dw-hdmi: fix bus formats negotiation for 8 bit modes

Hi Neil, > Am 02.03.2022 um 15:34 schrieb Neil Armstrong : > > Hi, > >> (cross-checked: RGB mode still works if I force hdmi->sink_is_hdmi = false) > > I don't understand what's wrong, can you try to make the logic select > MEDIA_BUS_FMT_YUV8_1X24 instead of DRM_COLOR_FORMAT_YCBCR422 ? I have

Re: [PATCH v16 4/4] drm/bridge: dw-hdmi: fix bus formats negotiation for 8 bit modes

Hi, On 02/03/2022 12:15, H. Nikolaus Schaller wrote: Hi Neil, Am 02.03.2022 um 11:25 schrieb Neil Armstrong : I added a printk for hdmi->sink_is_hdmi. This returns 1. Which IMHO is to be expected since I am using a HDMI connector and panel... So your patch will still add the UYVY formats.

Re: [PATCH v16 4/4] drm/bridge: dw-hdmi: fix bus formats negotiation for 8 bit modes

Hi Neil, > Am 02.03.2022 um 11:25 schrieb Neil Armstrong : > >> I added a printk for hdmi->sink_is_hdmi. This returns 1. Which IMHO is to be >> expected >> since I am using a HDMI connector and panel... So your patch will still add >> the UYVY formats. >> Either the synposys module inside the j

Re: [PATCH v16 4/4] drm/bridge: dw-hdmi: fix bus formats negotiation for 8 bit modes

H, On 01/03/2022 21:37, H. Nikolaus Schaller wrote: Hi Neil, Am 01.03.2022 um 10:18 schrieb Neil Armstrong : Hi, On 26/02/2022 18:13, H. Nikolaus Schaller wrote: Commit 7cd70656d1285b ("drm/bridge: display-connector: implement bus fmts callbacks") introduced a new mechanism to negotiate b

Re: [PATCH v16 4/4] drm/bridge: dw-hdmi: fix bus formats negotiation for 8 bit modes

Hi Neil, > Am 01.03.2022 um 10:18 schrieb Neil Armstrong : > > Hi, > > On 26/02/2022 18:13, H. Nikolaus Schaller wrote: >> Commit 7cd70656d1285b ("drm/bridge: display-connector: implement bus fmts >> callbacks") >> introduced a new mechanism to negotiate bus formats between hdmi connectors >>

Re: [PATCH v16 4/4] drm/bridge: dw-hdmi: fix bus formats negotiation for 8 bit modes

Hi, On 26/02/2022 18:13, H. Nikolaus Schaller wrote: Commit 7cd70656d1285b ("drm/bridge: display-connector: implement bus fmts callbacks") introduced a new mechanism to negotiate bus formats between hdmi connectors and bridges which is to be used e.g. for the jz4780 based CI20 board. In this

[PATCH v16 4/4] drm/bridge: dw-hdmi: fix bus formats negotiation for 8 bit modes

Commit 7cd70656d1285b ("drm/bridge: display-connector: implement bus fmts callbacks") introduced a new mechanism to negotiate bus formats between hdmi connectors and bridges which is to be used e.g. for the jz4780 based CI20 board. In this case dw-hdmi sets up a list of formats in dw_hdmi_bridge