Re: [PATCH v16 15/20] drm/shmem-helper: Add memory shrinker

2023-09-14 Thread Dmitry Osipenko
On 9/14/23 16:27, Boris Brezillon wrote: ... > If you added this pages_use_count > 0 check to deal with the > 'free-partially-imported-GEM' case, I keep thinking this is not > the right fix. You should just assume that obj->import_attach == NULL > means not-a-prime-buffer, and then make sure > part

Re: [PATCH v16 15/20] drm/shmem-helper: Add memory shrinker

2023-09-14 Thread Boris Brezillon
On Thu, 14 Sep 2023 15:27:03 +0200 Boris Brezillon wrote: > You should drop the '&& refcount_read(&shmem->pages_use_count)', > otherwise you'll never enter this branch (sgt allocation retained > a ref, so pages_use_count > 0 when ->sgt != NULL). Sorry for the brain fart. You can drop this extra

Re: [PATCH v16 15/20] drm/shmem-helper: Add memory shrinker

2023-09-14 Thread Boris Brezillon
On Thu, 14 Sep 2023 16:01:37 +0300 Dmitry Osipenko wrote: > On 9/14/23 14:58, Boris Brezillon wrote: > > On Thu, 14 Sep 2023 14:36:23 +0300 > > Dmitry Osipenko wrote: > > > >> On 9/14/23 11:27, Boris Brezillon wrote: > >>> On Thu, 14 Sep 2023 10:50:32 +0300 > >>> Dmitry Osipenko wrote: > >

Re: [PATCH v16 15/20] drm/shmem-helper: Add memory shrinker

2023-09-14 Thread Dmitry Osipenko
On 9/14/23 14:58, Boris Brezillon wrote: > On Thu, 14 Sep 2023 14:36:23 +0300 > Dmitry Osipenko wrote: > >> On 9/14/23 11:27, Boris Brezillon wrote: >>> On Thu, 14 Sep 2023 10:50:32 +0300 >>> Dmitry Osipenko wrote: >>> On 9/14/23 10:36, Boris Brezillon wrote: > On Thu, 14 Sep 2023

Re: [PATCH v16 15/20] drm/shmem-helper: Add memory shrinker

2023-09-14 Thread Boris Brezillon
On Thu, 14 Sep 2023 14:36:23 +0300 Dmitry Osipenko wrote: > On 9/14/23 11:27, Boris Brezillon wrote: > > On Thu, 14 Sep 2023 10:50:32 +0300 > > Dmitry Osipenko wrote: > > > >> On 9/14/23 10:36, Boris Brezillon wrote: > >>> On Thu, 14 Sep 2023 07:02:52 +0300 > >>> Dmitry Osipenko wrote: > >

Re: [PATCH v16 15/20] drm/shmem-helper: Add memory shrinker

2023-09-14 Thread Dmitry Osipenko
On 9/14/23 11:27, Boris Brezillon wrote: > On Thu, 14 Sep 2023 10:50:32 +0300 > Dmitry Osipenko wrote: > >> On 9/14/23 10:36, Boris Brezillon wrote: >>> On Thu, 14 Sep 2023 07:02:52 +0300 >>> Dmitry Osipenko wrote: >>> On 9/13/23 10:48, Boris Brezillon wrote: > On Wed, 13 Sep 2023

Re: [PATCH v16 15/20] drm/shmem-helper: Add memory shrinker

2023-09-14 Thread Boris Brezillon
On Thu, 14 Sep 2023 10:50:32 +0300 Dmitry Osipenko wrote: > On 9/14/23 10:36, Boris Brezillon wrote: > > On Thu, 14 Sep 2023 07:02:52 +0300 > > Dmitry Osipenko wrote: > > > >> On 9/13/23 10:48, Boris Brezillon wrote: > >>> On Wed, 13 Sep 2023 03:56:14 +0300 > >>> Dmitry Osipenko wrote: > >

Re: [PATCH v16 15/20] drm/shmem-helper: Add memory shrinker

2023-09-14 Thread Dmitry Osipenko
On 9/14/23 10:36, Boris Brezillon wrote: > On Thu, 14 Sep 2023 07:02:52 +0300 > Dmitry Osipenko wrote: > >> On 9/13/23 10:48, Boris Brezillon wrote: >>> On Wed, 13 Sep 2023 03:56:14 +0300 >>> Dmitry Osipenko wrote: >>> On 9/5/23 11:03, Boris Brezillon wrote: >>* But

Re: [PATCH v16 15/20] drm/shmem-helper: Add memory shrinker

2023-09-14 Thread Boris Brezillon
On Thu, 14 Sep 2023 07:02:52 +0300 Dmitry Osipenko wrote: > On 9/13/23 10:48, Boris Brezillon wrote: > > On Wed, 13 Sep 2023 03:56:14 +0300 > > Dmitry Osipenko wrote: > > > >> On 9/5/23 11:03, Boris Brezillon wrote: > * But > + * acquiring the obj lo

Re: [PATCH v16 15/20] drm/shmem-helper: Add memory shrinker

2023-09-13 Thread Dmitry Osipenko
On 9/13/23 10:48, Boris Brezillon wrote: > On Wed, 13 Sep 2023 03:56:14 +0300 > Dmitry Osipenko wrote: > >> On 9/5/23 11:03, Boris Brezillon wrote: * But + * acquiring the obj lock in drm_gem_shmem_release_pages_locked() can + * cause a lock

Re: [PATCH v16 15/20] drm/shmem-helper: Add memory shrinker

2023-09-13 Thread Boris Brezillon
On Wed, 13 Sep 2023 03:56:14 +0300 Dmitry Osipenko wrote: > On 9/5/23 11:03, Boris Brezillon wrote: > >>* But > >> + * acquiring the obj lock in > >> drm_gem_shmem_release_pages_locked() can > >> + * cause a locking order inversion between > >> reservation_ww

Re: [PATCH v16 15/20] drm/shmem-helper: Add memory shrinker

2023-09-12 Thread Dmitry Osipenko
On 9/5/23 11:03, Boris Brezillon wrote: >>* But >> + * acquiring the obj lock in >> drm_gem_shmem_release_pages_locked() can >> + * cause a locking order inversion between >> reservation_ww_class_mutex >> + * and fs_reclaim. >> + * >

Re: [PATCH v16 15/20] drm/shmem-helper: Add memory shrinker

2023-09-11 Thread Dmitry Osipenko
On 9/7/23 13:03, Dan Carpenter wrote: > 2c607edf57db6a Dmitry Osipenko 2023-09-03 @724if (page_offset >= > num_pages || (!shmem->pages && !shmem->evicted)) { > > ^^^ > Sho

Re: [PATCH v16 15/20] drm/shmem-helper: Add memory shrinker

2023-09-07 Thread Dan Carpenter
base: linus/master patch link: https://lore.kernel.org/r/20230903170736.513347-16-dmitry.osipenko%40collabora.com patch subject: [PATCH v16 15/20] drm/shmem-helper: Add memory shrinker config: x86_64-randconfig-161-20230907 (https://download.01.org/0day-ci/archive/20230907/202309070814.jygjojzy

Re: [PATCH v16 15/20] drm/shmem-helper: Add memory shrinker

2023-09-05 Thread Boris Brezillon
On Sun, 3 Sep 2023 20:07:31 +0300 Dmitry Osipenko wrote: > Introduce common drm-shmem shrinker for DRM drivers. > > To start using drm-shmem shrinker drivers should do the following: > > 1. Implement evict() callback of GEM object where driver should check >whether object is purgeable or e

[PATCH v16 15/20] drm/shmem-helper: Add memory shrinker

2023-09-03 Thread Dmitry Osipenko
Introduce common drm-shmem shrinker for DRM drivers. To start using drm-shmem shrinker drivers should do the following: 1. Implement evict() callback of GEM object where driver should check whether object is purgeable or evictable using drm-shmem helpers and perform the shrinking action 2.