Re: [PATCH v16 0/3] eDP/DP Phy vdda realted function

2022-08-03 Thread Johan Hovold
On Fri, Jul 29, 2022 at 03:07:47PM +0100, Mark Brown wrote: > On Fri, Jul 29, 2022 at 03:35:33PM +0200, Johan Hovold wrote: > > > I guess we just need to drop all those regulator-allow-set-load > > properties for now even if using DT for power-management configuration > > this way does seem to run

Re: [PATCH v16 0/3] eDP/DP Phy vdda realted function

2022-07-29 Thread Mark Brown
On Fri, Jul 29, 2022 at 03:35:33PM +0200, Johan Hovold wrote: > I guess we just need to drop all those regulator-allow-set-load > properties for now even if using DT for power-management configuration > this way does seem to run against the whole DT-as-hardware-description > idea (e.g. we may want

Re: [PATCH v16 0/3] eDP/DP Phy vdda realted function

2022-07-29 Thread Johan Hovold
Sorry about the late follow-up on this. Has been one of those constant-preemption weeks. And thanks Doug and Mark for the insightful comments in this and the dt-load RFC thread. On Thu, Jul 21, 2022 at 07:49:55AM -0700, Doug Anderson wrote: > Hi, > > On Thu, Jul 21, 2022 at 6:25 AM Dmitry Barysh

Re: [PATCH v16 0/3] eDP/DP Phy vdda realted function

2022-07-21 Thread Doug Anderson
Hi, On Thu, Jul 21, 2022 at 7:52 AM Doug Anderson wrote: > > Hi, > > On Thu, Jul 21, 2022 at 7:39 AM Doug Anderson wrote: > > > > > You could add a way to specify constant base loads in DT on either a per > > > regulator or per consumer basis. > > > > Yes, this please! ...on a per consumer basis

Re: [PATCH v16 0/3] eDP/DP Phy vdda realted function

2022-07-21 Thread Dmitry Baryshkov
On Thu, 21 Jul 2022 at 17:50, Doug Anderson wrote: > > Hi, > > On Thu, Jul 21, 2022 at 6:25 AM Dmitry Baryshkov > wrote: > > > > > This series breaks USB and PCIe for some SC8280XP and SA540P machines > > > where the DP PHY regulators are shared with other PHYs whose drivers do > > > not request

Re: [PATCH v16 0/3] eDP/DP Phy vdda realted function

2022-07-21 Thread Mark Brown
On Thu, Jul 21, 2022 at 07:52:01AM -0700, Doug Anderson wrote: > On Thu, Jul 21, 2022 at 7:39 AM Doug Anderson wrote: > > vdda-phy-supply = <&vdda_mipi_dsi0_1p2>; > > vdda-phy-supply-base-load = <21800>; > Ah, sorry to respond to my own thread so quickly, but I just thought > of a reason for the

Re: [PATCH v16 0/3] eDP/DP Phy vdda realted function

2022-07-21 Thread Mark Brown
On Thu, Jul 21, 2022 at 08:43:48AM -0700, Doug Anderson wrote: > I guess I'd put it this way, though: how many drivers in Linux today > have _two_ calls to regulator_set_load(): one for the "active" state > and one for the retention state. Looks like UFS maybe. Any others? For > most devices the p

Re: [PATCH v16 0/3] eDP/DP Phy vdda realted function

2022-07-21 Thread Doug Anderson
Hi, On Thu, Jul 21, 2022 at 8:06 AM Mark Brown wrote: > > On Thu, Jul 21, 2022 at 07:49:55AM -0700, Doug Anderson wrote: > > > Every single LDO on Qualcomm's PMICs seems to be able to be set in > > "high power mode" and "low power mode", but I think the majority of > > clients only really care ab

Re: [PATCH v16 0/3] eDP/DP Phy vdda realted function

2022-07-21 Thread Mark Brown
On Thu, Jul 21, 2022 at 07:49:55AM -0700, Doug Anderson wrote: > Every single LDO on Qualcomm's PMICs seems to be able to be set in > "high power mode" and "low power mode", but I think the majority of > clients only really care about two things: on and in high power mode > vs. off. I think the am

Re: [PATCH v16 0/3] eDP/DP Phy vdda realted function

2022-07-21 Thread Doug Anderson
Hi, On Thu, Jul 21, 2022 at 7:39 AM Doug Anderson wrote: > > > You could add a way to specify constant base loads in DT on either a per > > regulator or per consumer basis. > > Yes, this please! ...on a per consumer basis. :-) It's been on my > wishlist for a while and would eliminate a massive a

Re: [PATCH v16 0/3] eDP/DP Phy vdda realted function

2022-07-21 Thread Doug Anderson
Hi, On Thu, Jul 21, 2022 at 6:25 AM Dmitry Baryshkov wrote: > > > This series breaks USB and PCIe for some SC8280XP and SA540P machines > > where the DP PHY regulators are shared with other PHYs whose drivers do > > not request a load. > > I'm trying to understand, why does this series cause the

Re: [PATCH v16 0/3] eDP/DP Phy vdda realted function

2022-07-21 Thread Doug Anderson
Hi, On Thu, Jul 21, 2022 at 4:20 AM Mark Brown wrote: > > On Thu, Jul 21, 2022 at 12:31:41PM +0200, Johan Hovold wrote: > > If you're copying someone into a thread that's not obviously relevant > for them it's good practice to put a note about it at the top of the > mail to reduce the chances tha

Re: [PATCH v16 0/3] eDP/DP Phy vdda realted function

2022-07-21 Thread Dmitry Baryshkov
On Thu, 21 Jul 2022 at 13:31, Johan Hovold wrote: > > On Tue, Jul 05, 2022 at 09:29:13AM -0700, Kuogee Hsieh wrote: > > 0) rebase on > > https://git.kernel.org/pub/scm/linux/kernel/git/phy/linux-phy.git tree > > 1) add regulator_set_load() to eDP phy > > 2) add regulator_set_load() to DP phy > >

Re: [PATCH v16 0/3] eDP/DP Phy vdda realted function

2022-07-21 Thread Johan Hovold
On Thu, Jul 21, 2022 at 12:56:37PM +0100, Mark Brown wrote: > On Thu, Jul 21, 2022 at 12:20:31PM +0100, Mark Brown wrote: > > > You could add a way to specify constant base loads in DT on either a per > > regulator or per consumer basis. > > ...and also note that this is only an issue if the syst

Re: [PATCH v16 0/3] eDP/DP Phy vdda realted function

2022-07-21 Thread Mark Brown
On Thu, Jul 21, 2022 at 12:20:31PM +0100, Mark Brown wrote: > You could add a way to specify constant base loads in DT on either a per > regulator or per consumer basis. ...and also note that this is only an issue if the system gives permission to change the mode in the constraints which is prett

Re: [PATCH v16 0/3] eDP/DP Phy vdda realted function

2022-07-21 Thread Mark Brown
On Thu, Jul 21, 2022 at 12:31:41PM +0200, Johan Hovold wrote: If you're copying someone into a thread that's not obviously relevant for them it's good practice to put a note about it at the top of the mail to reduce the chances that it just gets deleted unread - people get copies of all sorts of r

Re: [PATCH v16 0/3] eDP/DP Phy vdda realted function

2022-07-21 Thread Johan Hovold
On Tue, Jul 05, 2022 at 09:29:13AM -0700, Kuogee Hsieh wrote: > 0) rebase on > https://git.kernel.org/pub/scm/linux/kernel/git/phy/linux-phy.git tree > 1) add regulator_set_load() to eDP phy > 2) add regulator_set_load() to DP phy > 3) remove vdda related function out of eDP/DP controller > > Kuo

Re: [PATCH v16 0/3] eDP/DP Phy vdda realted function

2022-07-06 Thread Vinod Koul
On 05-07-22, 09:29, Kuogee Hsieh wrote: > 0) rebase on > https://git.kernel.org/pub/scm/linux/kernel/git/phy/linux-phy.git tree > 1) add regulator_set_load() to eDP phy > 2) add regulator_set_load() to DP phy > 3) remove vdda related function out of eDP/DP controller Applied, thanks -- ~Vinod

[PATCH v16 0/3] eDP/DP Phy vdda realted function

2022-07-05 Thread Kuogee Hsieh
0) rebase on https://git.kernel.org/pub/scm/linux/kernel/git/phy/linux-phy.git tree 1) add regulator_set_load() to eDP phy 2) add regulator_set_load() to DP phy 3) remove vdda related function out of eDP/DP controller Kuogee Hsieh (3): phy: qcom-edp: add regulator_set_load to edp phy phy: qco