Re: [PATCH v14 1/2] drm: add kms driver for loongson display controller

2023-06-13 Thread Sui Jingfeng
On 2023/6/14 00:20, Sui Jingfeng wrote: We will remote this workaround at next version. remote -> remove

Re: [PATCH v14 1/2] drm: add kms driver for loongson display controller

2023-06-13 Thread Sui Jingfeng
Hi, On 2023/5/21 20:21, WANG Xuerui wrote: + +static int __init loongson_module_init(void) +{ +    struct pci_dev *pdev = NULL; + +    if (video_firmware_drivers_only()) +    return -ENODEV; + +    /* Multiple video card workaround */ +    while ((pdev = pci_get_class(PCI_CLASS_DISPLAY_VGA <

Re: [PATCH v14 1/2] drm: add kms driver for loongson display controller

2023-06-12 Thread Sui Jingfeng
Hi, On 2023/5/24 10:56, Huacai Chen wrote: I suggest split the LS2K parts to a separate patch, but keep it in the same series to get them upstreamed together. Nice idea! Yet, it is really deserve  for  a dedicated patch. The skill and effort needed is overwhelming. Our graphics group have l

Re: [PATCH v14 1/2] drm: add kms driver for loongson display controller

2023-05-24 Thread Sui Jingfeng
On 2023/5/25 12:09, Sui Jingfeng wrote: Hi, On 2023/5/23 00:40, WANG Xuerui wrote: On 5/22/23 21:13, Sui Jingfeng wrote: Hi, On 2023/5/22 18:25, WANG Xuerui wrote: On 2023/5/22 18:17, Sui Jingfeng wrote: Hi, On 2023/5/22 18:05, WANG Xuerui wrote: On 2023/5/22 17:49, Sui Jingfeng wrote:

Re: [PATCH v14 1/2] drm: add kms driver for loongson display controller

2023-05-24 Thread Sui Jingfeng
Hi, On 2023/5/23 00:40, WANG Xuerui wrote: On 5/22/23 21:13, Sui Jingfeng wrote: Hi, On 2023/5/22 18:25, WANG Xuerui wrote: On 2023/5/22 18:17, Sui Jingfeng wrote: Hi, On 2023/5/22 18:05, WANG Xuerui wrote: On 2023/5/22 17:49, Sui Jingfeng wrote: Hi, On 2023/5/22 17:28, WANG Xuerui wrote

Re: [PATCH v14 1/2] drm: add kms driver for loongson display controller

2023-05-23 Thread Huacai Chen
On Tue, May 23, 2023 at 4:14 PM WANG Xuerui wrote: > > On 2023/5/22 16:02, Sui Jingfeng wrote: > > Hi, > > > > On 2023/5/21 20:21, WANG Xuerui wrote: > >>> --- /dev/null > >>> +++ b/drivers/gpu/drm/loongson/Kconfig > >>> @@ -0,0 +1,17 @@ > >>> +# SPDX-License-Identifier: GPL-2.0 > >>> + > >>> +con

Re: [PATCH v14 1/2] drm: add kms driver for loongson display controller

2023-05-23 Thread Huacai Chen
On Tue, May 23, 2023 at 4:14 PM WANG Xuerui wrote: > > On 5/22/23 21:13, Sui Jingfeng wrote: > > Hi, > > > > On 2023/5/22 18:25, WANG Xuerui wrote: > >> On 2023/5/22 18:17, Sui Jingfeng wrote: > >>> Hi, > >>> > >>> On 2023/5/22 18:05, WANG Xuerui wrote: > On 2023/5/22 17:49, Sui Jingfeng wrot

Re: [PATCH v14 1/2] drm: add kms driver for loongson display controller

2023-05-23 Thread WANG Xuerui
On 2023/5/22 17:49, Sui Jingfeng wrote: Hi, On 2023/5/22 17:28, WANG Xuerui wrote: On 2023/5/22 17:25, Sui Jingfeng wrote: Hi, On 2023/5/21 20:21, WANG Xuerui wrote: + * LS3A4000/LS3A5000/LS3A6000 CPU, they are equipped with on-board video RAM + * typically. While LS2K0500/LS2K1000/LS2K2000

Re: [PATCH v14 1/2] drm: add kms driver for loongson display controller

2023-05-23 Thread WANG Xuerui
On 2023/5/22 16:14, Sui Jingfeng wrote: Hi, On 2023/5/21 20:21, WANG Xuerui wrote: + +  If in doubt, say "N". diff --git a/drivers/gpu/drm/loongson/Makefile b/drivers/gpu/drm/loongson/Makefile new file mode 100644 index ..9158816ece8e --- /dev/null +++ b/drivers/gpu/drm/loongs

Re: [PATCH v14 1/2] drm: add kms driver for loongson display controller

2023-05-23 Thread WANG Xuerui
On 2023/5/22 17:05, Sui Jingfeng wrote: Hi, On 2023/5/21 20:21, WANG Xuerui wrote: +++ b/drivers/gpu/drm/loongson/lsdc_debugfs.c @@ -0,0 +1,91 @@ +// SPDX-License-Identifier: GPL-2.0+ +/* + * Copyright (C) 2023 Loongson Technology Corporation Limited + */ + +#include + +#include "lsdc_benchmar

Re: [PATCH v14 1/2] drm: add kms driver for loongson display controller

2023-05-23 Thread WANG Xuerui
On 2023/5/22 16:02, Sui Jingfeng wrote: Hi, On 2023/5/21 20:21, WANG Xuerui wrote: --- /dev/null +++ b/drivers/gpu/drm/loongson/Kconfig @@ -0,0 +1,17 @@ +# SPDX-License-Identifier: GPL-2.0 + +config DRM_LOONGSON +    tristate "DRM support for Loongson Graphics" +    depends on DRM && PCI && MMU

Re: [PATCH v14 1/2] drm: add kms driver for loongson display controller

2023-05-23 Thread WANG Xuerui
On 5/22/23 21:13, Sui Jingfeng wrote: Hi, On 2023/5/22 18:25, WANG Xuerui wrote: On 2023/5/22 18:17, Sui Jingfeng wrote: Hi, On 2023/5/22 18:05, WANG Xuerui wrote: On 2023/5/22 17:49, Sui Jingfeng wrote: Hi, On 2023/5/22 17:28, WANG Xuerui wrote: On 2023/5/22 17:25, Sui Jingfeng wrote: H

Re: [PATCH v14 1/2] drm: add kms driver for loongson display controller

2023-05-23 Thread WANG Xuerui
On 2023/5/22 18:17, Sui Jingfeng wrote: Hi, On 2023/5/22 18:05, WANG Xuerui wrote: On 2023/5/22 17:49, Sui Jingfeng wrote: Hi, On 2023/5/22 17:28, WANG Xuerui wrote: On 2023/5/22 17:25, Sui Jingfeng wrote: Hi, On 2023/5/21 20:21, WANG Xuerui wrote: + * LS3A4000/LS3A5000/LS3A6000 CPU, they

Re: [PATCH v14 1/2] drm: add kms driver for loongson display controller

2023-05-23 Thread WANG Xuerui
On 2023/5/22 17:25, Sui Jingfeng wrote: Hi, On 2023/5/21 20:21, WANG Xuerui wrote: + * LS3A4000/LS3A5000/LS3A6000 CPU, they are equipped with on-board video RAM + * typically. While LS2K0500/LS2K1000/LS2K2000 are low cost SoCs which share + * the system RAM as video RAM, they don't has a dedi

Re: [PATCH v14 1/2] drm: add kms driver for loongson display controller

2023-05-23 Thread WANG Xuerui
On 2023/5/22 16:29, Sui Jingfeng wrote: On 2023/5/22 16:09, WANG Xuerui wrote: On 2023/5/22 16:02, Sui Jingfeng wrote: Hi, On 2023/5/21 20:21, WANG Xuerui wrote: --- /dev/null +++ b/drivers/gpu/drm/loongson/Kconfig @@ -0,0 +1,17 @@ +# SPDX-License-Identifier: GPL-2.0 + +config DRM_LOONGSON +

Re: [PATCH v14 1/2] drm: add kms driver for loongson display controller

2023-05-23 Thread WANG Xuerui
On 2023/5/22 16:51, Sui Jingfeng wrote: Hi, On 2023/5/21 20:21, WANG Xuerui wrote: + +static void lsdc_crtc0_soft_reset(struct lsdc_crtc *lcrtc) +{ +    struct lsdc_device *ldev = lcrtc->ldev; +    u32 val; + +    val = lsdc_rreg32(ldev, LSDC_CRTC0_CFG_REG); + +    val &= CFG_VALID_BITS_MASK

Re: [PATCH v14 1/2] drm: add kms driver for loongson display controller

2023-05-22 Thread Sui Jingfeng
Hi, On 2023/5/22 18:25, WANG Xuerui wrote: On 2023/5/22 18:17, Sui Jingfeng wrote: Hi, On 2023/5/22 18:05, WANG Xuerui wrote: On 2023/5/22 17:49, Sui Jingfeng wrote: Hi, On 2023/5/22 17:28, WANG Xuerui wrote: On 2023/5/22 17:25, Sui Jingfeng wrote: Hi, On 2023/5/21 20:21, WANG Xuerui wro

Re: [PATCH v14 1/2] drm: add kms driver for loongson display controller

2023-05-22 Thread Sui Jingfeng
Hi, On 2023/5/22 18:05, WANG Xuerui wrote: On 2023/5/22 17:49, Sui Jingfeng wrote: Hi, On 2023/5/22 17:28, WANG Xuerui wrote: On 2023/5/22 17:25, Sui Jingfeng wrote: Hi, On 2023/5/21 20:21, WANG Xuerui wrote: + * LS3A4000/LS3A5000/LS3A6000 CPU, they are equipped with on-board video RAM + *

Re: [PATCH v14 1/2] drm: add kms driver for loongson display controller

2023-05-22 Thread Sui Jingfeng
Hi, On 2023/5/22 18:05, WANG Xuerui wrote: On 2023/5/22 17:49, Sui Jingfeng wrote: Hi, On 2023/5/22 17:28, WANG Xuerui wrote: On 2023/5/22 17:25, Sui Jingfeng wrote: Hi, On 2023/5/21 20:21, WANG Xuerui wrote: + * LS3A4000/LS3A5000/LS3A6000 CPU, they are equipped with on-board video RAM + *

Re: [PATCH v14 1/2] drm: add kms driver for loongson display controller

2023-05-22 Thread Sui Jingfeng
Hi, On 2023/5/22 17:28, WANG Xuerui wrote: On 2023/5/22 17:25, Sui Jingfeng wrote: Hi, On 2023/5/21 20:21, WANG Xuerui wrote: + * LS3A4000/LS3A5000/LS3A6000 CPU, they are equipped with on-board video RAM + * typically. While LS2K0500/LS2K1000/LS2K2000 are low cost SoCs which share + * the s

Re: [PATCH v14 1/2] drm: add kms driver for loongson display controller

2023-05-22 Thread Sui Jingfeng
Hi, On 2023/5/21 20:21, WANG Xuerui wrote: +#ifndef __LSDC_REGS_H__ +#define __LSDC_REGS_H__ + +#include +#include + +/* + * PIXEL PLL Reference clock + */ +#define LSDC_PLL_REF_CLK    10   /* kHz */ Consider naming it like "LSDC_PLL_REF_CLK_KHZ" for it to be self-do

Re: [PATCH v14 1/2] drm: add kms driver for loongson display controller

2023-05-22 Thread Sui Jingfeng
Hi, On 2023/5/21 20:21, WANG Xuerui wrote: + * LS3A4000/LS3A5000/LS3A6000 CPU, they are equipped with on-board video RAM + * typically. While LS2K0500/LS2K1000/LS2K2000 are low cost SoCs which share + * the system RAM as video RAM, they don't has a dediacated VRAM. CPU models are not typical

Re: [PATCH v14 1/2] drm: add kms driver for loongson display controller

2023-05-22 Thread Sui Jingfeng
Hi, On 2023/5/21 20:21, WANG Xuerui wrote: +++ b/drivers/gpu/drm/loongson/lsdc_debugfs.c @@ -0,0 +1,91 @@ +// SPDX-License-Identifier: GPL-2.0+ +/* + * Copyright (C) 2023 Loongson Technology Corporation Limited + */ + +#include + +#include "lsdc_benchmark.h" +#include "lsdc_drv.h" +#include "ls

Re: [PATCH v14 1/2] drm: add kms driver for loongson display controller

2023-05-22 Thread Sui Jingfeng
Hi, On 2023/5/21 20:21, WANG Xuerui wrote: +/* + * Copyright (C) 2023 Loongson Technology Corporation Limited + */ + +#include + +#include "lsdc_benchmark.h" +#include "lsdc_drv.h" +#include "lsdc_gem.h" +#include "lsdc_ttm.h" + +typedef void (*lsdc_copy_proc_t)(struct lsdc_bo *src_bo, + 

Re: [PATCH v14 1/2] drm: add kms driver for loongson display controller

2023-05-22 Thread Sui Jingfeng
On 2023/5/22 16:09, WANG Xuerui wrote: On 2023/5/22 16:02, Sui Jingfeng wrote: Hi, On 2023/5/21 20:21, WANG Xuerui wrote: --- /dev/null +++ b/drivers/gpu/drm/loongson/Kconfig @@ -0,0 +1,17 @@ +# SPDX-License-Identifier: GPL-2.0 + +config DRM_LOONGSON +    tristate "DRM support for Loongson G

Re: [PATCH v14 1/2] drm: add kms driver for loongson display controller

2023-05-22 Thread Sui Jingfeng
Hi, On 2023/5/21 20:21, WANG Xuerui wrote: + +  If in doubt, say "N". diff --git a/drivers/gpu/drm/loongson/Makefile b/drivers/gpu/drm/loongson/Makefile new file mode 100644 index ..9158816ece8e --- /dev/null +++ b/drivers/gpu/drm/loongson/Makefile @@ -0,0 +1,20 @@ +# SPDX-Lice

Re: [PATCH v14 1/2] drm: add kms driver for loongson display controller

2023-05-22 Thread Sui Jingfeng
Hi, On 2023/5/21 20:21, WANG Xuerui wrote: --- /dev/null +++ b/drivers/gpu/drm/loongson/Kconfig @@ -0,0 +1,17 @@ +# SPDX-License-Identifier: GPL-2.0 + +config DRM_LOONGSON +    tristate "DRM support for Loongson Graphics" +    depends on DRM && PCI && MMU +    select DRM_KMS_HELPER +    select D

Re: [PATCH v14 1/2] drm: add kms driver for loongson display controller

2023-05-22 Thread Sui Jingfeng
Hi, I love your reviews, On 2023/5/21 20:21, WANG Xuerui wrote: Hi, Someone else in a discussion group brought my attention to this series, that I've neglected for a long time because loonga...@lists.linux.dev isn't on the Cc list and I'm not subscribed to dri-devel. While I'm reasonabl