Re: [PATCH v12 2/9] drm/ingenic: Add support for JZ4780 and HDMI output

2022-02-02 Thread Paul Boddie
On Wednesday, 2 February 2022 13:41:21 CET Paul Cercueil wrote: > Le mer., févr. 2 2022 at 13:33:15 +0100, H. Nikolaus Schaller> a écrit : > >> Am 02.02.2022 um 13:28 schrieb Paul Cercueil : > >> > >> Note that there are other things not working with your current > >> > >> implementation, fo

Re: [PATCH v12 2/9] drm/ingenic: Add support for JZ4780 and HDMI output

2022-02-02 Thread H. Nikolaus Schaller
> Am 02.02.2022 um 13:41 schrieb Paul Cercueil : > > > > Le mer., févr. 2 2022 at 13:33:15 +0100, H. Nikolaus Schaller > a écrit : >>> Am 02.02.2022 um 13:28 schrieb Paul Cercueil : >>> Le mer., févr. 2 2022 at 13:17:14 +0100, H. Nikolaus Schaller >>> a écrit : Hi Paul, > Am 02.0

Re: [PATCH v12 2/9] drm/ingenic: Add support for JZ4780 and HDMI output

2022-02-02 Thread Paul Cercueil
Le mer., févr. 2 2022 at 13:33:15 +0100, H. Nikolaus Schaller a écrit : Am 02.02.2022 um 13:28 schrieb Paul Cercueil : Le mer., févr. 2 2022 at 13:17:14 +0100, H. Nikolaus Schaller a écrit : Hi Paul, Am 02.02.2022 um 13:06 schrieb Paul Cercueil : Hi Nikolaus, @@ -446,6 +454,

Re: [PATCH v12 2/9] drm/ingenic: Add support for JZ4780 and HDMI output

2022-02-02 Thread H. Nikolaus Schaller
> Am 02.02.2022 um 13:28 schrieb Paul Cercueil : > > > > Le mer., févr. 2 2022 at 13:17:14 +0100, H. Nikolaus Schaller > a écrit : >> Hi Paul, >>> Am 02.02.2022 um 13:06 schrieb Paul Cercueil : >>> Hi Nikolaus, >> @@ -446,6 +454,9 @@ static int ingenic_drm_plane_atomic_check(struct >>>

Re: [PATCH v12 2/9] drm/ingenic: Add support for JZ4780 and HDMI output

2022-02-02 Thread Paul Cercueil
Le mer., févr. 2 2022 at 13:17:14 +0100, H. Nikolaus Schaller a écrit : Hi Paul, Am 02.02.2022 um 13:06 schrieb Paul Cercueil : Hi Nikolaus, @@ -446,6 +454,9 @@ static int ingenic_drm_plane_atomic_check(struct drm_plane *plane, if (!crtc) return 0; + if

Re: [PATCH v12 2/9] drm/ingenic: Add support for JZ4780 and HDMI output

2022-02-02 Thread H. Nikolaus Schaller
Hi Paul, > Am 02.02.2022 um 13:06 schrieb Paul Cercueil : > > Hi Nikolaus, > @@ -446,6 +454,9 @@ static int ingenic_drm_plane_atomic_check(struct drm_plane *plane, if (!crtc) return 0; + if (plane == &priv->f0) + return -EINVAL; >>> This wil

Re: [PATCH v12 2/9] drm/ingenic: Add support for JZ4780 and HDMI output

2022-02-02 Thread Paul Cercueil
Hi Nikolaus, Le mer., févr. 2 2022 at 12:56:35 +0100, H. Nikolaus Schaller a écrit : Hi Paul, thanks for the reviews. Looks as if we are close to making a goal. Am 02.02.2022 um 11:23 schrieb Paul Cercueil : Hi Nikolaus, Le lun., janv. 31 2022 at 13:26:48 +0100, H. Nikolaus Schaller a

Re: [PATCH v12 2/9] drm/ingenic: Add support for JZ4780 and HDMI output

2022-02-02 Thread H. Nikolaus Schaller
Hi Paul, thanks for the reviews. Looks as if we are close to making a goal. > Am 02.02.2022 um 11:23 schrieb Paul Cercueil : > > Hi Nikolaus, > > Le lun., janv. 31 2022 at 13:26:48 +0100, H. Nikolaus Schaller > a écrit : >> From: Paul Boddie >> Add support for the LCD controller present on JZ

Re: [PATCH v12 2/9] drm/ingenic: Add support for JZ4780 and HDMI output

2022-02-02 Thread Paul Cercueil
Hi Nikolaus, Le lun., janv. 31 2022 at 13:26:48 +0100, H. Nikolaus Schaller a écrit : From: Paul Boddie Add support for the LCD controller present on JZ4780 SoCs. This SoC uses 8-byte descriptors which extend the current 4-byte descriptors used for other Ingenic SoCs. Tested on MIPS Creator

[PATCH v12 2/9] drm/ingenic: Add support for JZ4780 and HDMI output

2022-01-31 Thread H. Nikolaus Schaller
From: Paul Boddie Add support for the LCD controller present on JZ4780 SoCs. This SoC uses 8-byte descriptors which extend the current 4-byte descriptors used for other Ingenic SoCs. Tested on MIPS Creator CI20 board. Signed-off-by: Paul Boddie Signed-off-by: Ezequiel Garcia Signed-off-by: H.