Re: [PATCH v11 8/8] x86/vmware: Add TDX hypercall support

2024-06-14 Thread Alexey Makhalov
On 6/14/24 12:09 PM, Borislav Petkov wrote: On Fri, Jun 14, 2024 at 11:32:16AM -0700, Alexey Makhalov wrote: On 6/14/24 9:19 AM, Dave Hansen wrote: On 6/14/24 09:14, Borislav Petkov wrote: On Fri, Jun 14, 2024 at 09:03:22AM -0700, Dave Hansen wrote: ... You need to zero out all of 'args

Re: [PATCH v11 8/8] x86/vmware: Add TDX hypercall support

2024-06-14 Thread Borislav Petkov
On Fri, Jun 14, 2024 at 11:32:16AM -0700, Alexey Makhalov wrote: > > > On 6/14/24 9:19 AM, Dave Hansen wrote: > > On 6/14/24 09:14, Borislav Petkov wrote: > > > On Fri, Jun 14, 2024 at 09:03:22AM -0700, Dave Hansen wrote: > > ... > > > > You need to zero out all of 'args' somehow. > > > > > > Yo

Re: [PATCH v11 8/8] x86/vmware: Add TDX hypercall support

2024-06-14 Thread Alexey Makhalov
On 6/14/24 9:19 AM, Dave Hansen wrote: On 6/14/24 09:14, Borislav Petkov wrote: On Fri, Jun 14, 2024 at 09:03:22AM -0700, Dave Hansen wrote: ... You need to zero out all of 'args' somehow. You mean like this: struct tdx_module_args args = {}; ? Yes, or do all the assignments w

Re: [PATCH v11 8/8] x86/vmware: Add TDX hypercall support

2024-06-14 Thread Dave Hansen
On 6/14/24 09:14, Borislav Petkov wrote: > On Fri, Jun 14, 2024 at 09:03:22AM -0700, Dave Hansen wrote: ... >> You need to zero out all of 'args' somehow. > > You mean like this: > > struct tdx_module_args args = {}; > > ? Yes, or do all the assignments with the initializer. We seem to d

Re: [PATCH v11 8/8] x86/vmware: Add TDX hypercall support

2024-06-14 Thread Borislav Petkov
On Fri, Jun 14, 2024 at 09:03:22AM -0700, Dave Hansen wrote: > On 6/13/24 12:16, Alexey Makhalov wrote: > > +unsigned long vmware_tdx_hypercall(unsigned long cmd, > > + unsigned long in1, unsigned long in3, > > + unsigned long in4, unsigned

Re: [PATCH v11 8/8] x86/vmware: Add TDX hypercall support

2024-06-14 Thread Dave Hansen
On 6/13/24 12:16, Alexey Makhalov wrote: > +unsigned long vmware_tdx_hypercall(unsigned long cmd, > +unsigned long in1, unsigned long in3, > +unsigned long in4, unsigned long in5, > +u32 *out1, u32 *out2

[PATCH v11 8/8] x86/vmware: Add TDX hypercall support

2024-06-13 Thread Alexey Makhalov
VMware hypercalls use I/O port, VMCALL or VMMCALL instructions. Add __tdx_hypercall path to support TDX guests. No change in high bandwidth hypercalls, as only low bandwidth ones are supported for TDX guests. Co-developed-by: Tim Merrifield Signed-off-by: Tim Merrifield Signed-off-by: Alexey Ma