Re: [PATCH v11] drm/amdgpu: add drm buddy support to amdgpu

2022-03-29 Thread Christian König
Am 29.03.22 um 21:18 schrieb Arunpravin Paneer Selvam: On 29/03/22 9:30 pm, Arunpravin Paneer Selvam wrote: On 29/03/22 4:54 pm, Christian König wrote: Am 29.03.22 um 13:19 schrieb Arunpravin Paneer Selvam: [SNIP] + pages_left = node->base.num_pages; i = 0; - spin_loc

Re: [PATCH v11] drm/amdgpu: add drm buddy support to amdgpu

2022-03-29 Thread Arunpravin Paneer Selvam
On 29/03/22 9:30 pm, Arunpravin Paneer Selvam wrote: > > > On 29/03/22 4:54 pm, Christian König wrote: >> Am 29.03.22 um 13:19 schrieb Arunpravin Paneer Selvam: >>> [SNIP] > + pages_left = node->base.num_pages; > > i = 0; > - spin_lock(&mgr->lock); >

Re: [PATCH v11] drm/amdgpu: add drm buddy support to amdgpu

2022-03-29 Thread Arunpravin Paneer Selvam
On 29/03/22 4:54 pm, Christian König wrote: > Am 29.03.22 um 13:19 schrieb Arunpravin Paneer Selvam: >> [SNIP] + pages_left = node->base.num_pages; i = 0; - spin_lock(&mgr->lock); while (pages_left) { - uint32_t alignment = tbo->

Re: [PATCH v11] drm/amdgpu: add drm buddy support to amdgpu

2022-03-29 Thread Christian König
Am 29.03.22 um 13:19 schrieb Arunpravin Paneer Selvam: [SNIP] + pages_left = node->base.num_pages; i = 0; - spin_lock(&mgr->lock); while (pages_left) { - uint32_t alignment = tbo->page_alignment; + if (tbo->page_alignment) +

Re: [PATCH v11] drm/amdgpu: add drm buddy support to amdgpu

2022-03-29 Thread Arunpravin Paneer Selvam
r, Alexander ; matthew.a...@intel.com; > dan...@ffwll.ch; Koenig, Christian > Subject: Re: [PATCH v11] drm/amdgpu: add drm buddy support to amdgpu > > Am 23.03.22 um 07:25 schrieb Arunpravin Paneer Selvam: >> [SNIP] >> @@ -415,48 +409,86 @@ static int amdgpu_v

Re: [Intel-gfx] Commit messages (was: [PATCH v11] drm/amdgpu: add drm buddy support to amdgpu)

2022-03-24 Thread Daniel Vetter
On Wed, 23 Mar 2022 at 16:32, Christian König wrote: > > Am 23.03.22 um 16:24 schrieb Daniel Stone: > > On Wed, 23 Mar 2022 at 15:14, Alex Deucher wrote: > >> On Wed, Mar 23, 2022 at 11:04 AM Daniel Stone wrote: > >>> That's not what anyone's saying here ... > >>> > >>> No-one's demanding AMD pu

Re: Commit messages (was: [PATCH v11] drm/amdgpu: add drm buddy support to amdgpu)

2022-03-23 Thread Christian König
Am 23.03.22 um 16:24 schrieb Daniel Stone: On Wed, 23 Mar 2022 at 15:14, Alex Deucher wrote: On Wed, Mar 23, 2022 at 11:04 AM Daniel Stone wrote: That's not what anyone's saying here ... No-one's demanding AMD publish RTL, or internal design docs, or hardware specs, or URLs to JIRA tickets n

Re: Commit messages (was: [PATCH v11] drm/amdgpu: add drm buddy support to amdgpu)

2022-03-23 Thread Daniel Stone
On Wed, 23 Mar 2022 at 15:14, Alex Deucher wrote: > On Wed, Mar 23, 2022 at 11:04 AM Daniel Stone wrote: > > That's not what anyone's saying here ... > > > > No-one's demanding AMD publish RTL, or internal design docs, or > > hardware specs, or URLs to JIRA tickets no-one can access. > > > > This

Re: Commit messages (was: [PATCH v11] drm/amdgpu: add drm buddy support to amdgpu)

2022-03-23 Thread Christian König
Am 23.03.22 um 15:00 schrieb Daniel Stone: On Wed, 23 Mar 2022 at 08:19, Christian König wrote: Am 23.03.22 um 09:10 schrieb Paul Menzel: Sorry, I disagree. The motivation needs to be part of the commit message. For example see recent discussion on the LWN article *Donenfeld: Random number gen

Re: Commit messages (was: [PATCH v11] drm/amdgpu: add drm buddy support to amdgpu)

2022-03-23 Thread Alex Deucher
On Wed, Mar 23, 2022 at 11:04 AM Daniel Stone wrote: > > Hi Alex, > > On Wed, 23 Mar 2022 at 14:42, Alex Deucher wrote: > > On Wed, Mar 23, 2022 at 10:00 AM Daniel Stone wrote: > > > On Wed, 23 Mar 2022 at 08:19, Christian König > > > wrote: > > > > Well the key point is it's not about you to

Re: Commit messages (was: [PATCH v11] drm/amdgpu: add drm buddy support to amdgpu)

2022-03-23 Thread Daniel Stone
Hi Alex, On Wed, 23 Mar 2022 at 14:42, Alex Deucher wrote: > On Wed, Mar 23, 2022 at 10:00 AM Daniel Stone wrote: > > On Wed, 23 Mar 2022 at 08:19, Christian König > > wrote: > > > Well the key point is it's not about you to judge that. > > > > > > If you want to complain about the commit mess

Re: Commit messages (was: [PATCH v11] drm/amdgpu: add drm buddy support to amdgpu)

2022-03-23 Thread Alex Deucher
On Wed, Mar 23, 2022 at 10:00 AM Daniel Stone wrote: > > On Wed, 23 Mar 2022 at 08:19, Christian König > wrote: > > Am 23.03.22 um 09:10 schrieb Paul Menzel: > > > Sorry, I disagree. The motivation needs to be part of the commit > > > message. For example see recent discussion on the LWN article

Re: Commit messages (was: [PATCH v11] drm/amdgpu: add drm buddy support to amdgpu)

2022-03-23 Thread Daniel Stone
On Wed, 23 Mar 2022 at 08:19, Christian König wrote: > Am 23.03.22 um 09:10 schrieb Paul Menzel: > > Sorry, I disagree. The motivation needs to be part of the commit > > message. For example see recent discussion on the LWN article > > *Donenfeld: Random number generator enhancements for Linux 5.1

Re: [PATCH v11] drm/amdgpu: add drm buddy support to amdgpu

2022-03-23 Thread kernel test robot
Hi Arunpravin, Thank you for the patch! Yet something to improve: [auto build test ERROR on a678f97326454b60ffbbde6abf52d23997d71a27] url: https://github.com/0day-ci/linux/commits/Arunpravin-Paneer-Selvam/drm-amdgpu-add-drm-buddy-support-to-amdgpu/20220323-142749 base: a678f97326454b60ffbb

Re: Commit messages (was: [PATCH v11] drm/amdgpu: add drm buddy support to amdgpu)

2022-03-23 Thread Christian König
Hi Paul, Am 23.03.22 um 09:10 schrieb Paul Menzel: Dear Christian, Am 23.03.22 um 08:42 schrieb Christian König: Am 23.03.22 um 07:42 schrieb Paul Menzel: Am 23.03.22 um 07:25 schrieb Arunpravin Paneer Selvam: - Remove drm_mm references and replace with drm buddy functionalities The co

Commit messages (was: [PATCH v11] drm/amdgpu: add drm buddy support to amdgpu)

2022-03-23 Thread Paul Menzel
Dear Christian, Am 23.03.22 um 08:42 schrieb Christian König: Am 23.03.22 um 07:42 schrieb Paul Menzel: Am 23.03.22 um 07:25 schrieb Arunpravin Paneer Selvam: - Remove drm_mm references and replace with drm buddy functionalities The commit message summary to me suggested, you can somehow

Re: [PATCH v11] drm/amdgpu: add drm buddy support to amdgpu

2022-03-23 Thread Christian König
Hi Paul, Am 23.03.22 um 07:42 schrieb Paul Menzel: Dear Arunprivin, Thank you for your patch. Am 23.03.22 um 07:25 schrieb Arunpravin Paneer Selvam: - Remove drm_mm references and replace with drm buddy functionalities The commit message summary to me suggested, you can somehow use both a

Re: [PATCH v11] drm/amdgpu: add drm buddy support to amdgpu

2022-03-23 Thread Christian König
Am 23.03.22 um 07:25 schrieb Arunpravin Paneer Selvam: [SNIP] @@ -415,48 +409,86 @@ static int amdgpu_vram_mgr_new(struct ttm_resource_manager *man, goto error_fini; } - mode = DRM_MM_INSERT_BEST; + INIT_LIST_HEAD(&node->blocks); + if (place->flags & TTM

Re: [PATCH v11] drm/amdgpu: add drm buddy support to amdgpu

2022-03-22 Thread Paul Menzel
Dear Arunprivin, Thank you for your patch. Am 23.03.22 um 07:25 schrieb Arunpravin Paneer Selvam: - Remove drm_mm references and replace with drm buddy functionalities The commit message summary to me suggested, you can somehow use both allocators now. Two suggestions below: 1. Switch to

[PATCH v11] drm/amdgpu: add drm buddy support to amdgpu

2022-03-22 Thread Arunpravin Paneer Selvam
- Remove drm_mm references and replace with drm buddy functionalities - Add res cursor support for drm buddy v2(Matthew Auld): - replace spinlock with mutex as we call kmem_cache_zalloc (..., GFP_KERNEL) in drm_buddy_alloc() function - lock drm_buddy_block_trim() function as it calls