Re: [PATCH v10 4/8] drm/ingenic: Add dw-hdmi driver for jz4780

2021-12-01 Thread Mark Brown
On Wed, Dec 01, 2021 at 05:53:03PM +0100, H. Nikolaus Schaller wrote: > > Am 01.12.2021 um 16:10 schrieb Mark Brown : > > Again, if the supply can be physically absent that is a sensible use > > case but that means completely absent, not just not software > > controllable. We can represent fixed

Re: [PATCH v10 4/8] drm/ingenic: Add dw-hdmi driver for jz4780

2021-12-01 Thread H. Nikolaus Schaller
Hi Mark, > Am 01.12.2021 um 16:10 schrieb Mark Brown : > > On Wed, Dec 01, 2021 at 03:33:24PM +0100, H. Nikolaus Schaller wrote: >>> Am 01.12.2021 um 15:03 schrieb Paul Cercueil : > >>> Please make it mandatory in DTS then, and use devm_regulator_get() in the >>> driver. > >> Well, I just won

Re: [PATCH v10 4/8] drm/ingenic: Add dw-hdmi driver for jz4780

2021-12-01 Thread Mark Brown
On Wed, Dec 01, 2021 at 03:33:24PM +0100, H. Nikolaus Schaller wrote: > > Am 01.12.2021 um 15:03 schrieb Paul Cercueil : > > Please make it mandatory in DTS then, and use devm_regulator_get() in the > > driver. > Well, I just wonder why the elegant devm_regulator_get_optional() exists at > all

Re: [PATCH v10 4/8] drm/ingenic: Add dw-hdmi driver for jz4780

2021-12-01 Thread H. Nikolaus Schaller
Hi Paul, > Am 01.12.2021 um 15:03 schrieb Paul Cercueil : > > Hi Nikolaus, Mark, > > Le mer., déc. 1 2021 at 14:51:51 +0100, H. Nikolaus Schaller > a écrit : >> Hi, >>> Am 01.12.2021 um 14:39 schrieb Mark Brown : >>> On Wed, Dec 01, 2021 at 01:02:45PM +, Paul Cercueil wrote: Le mar.,

Re: [PATCH v10 4/8] drm/ingenic: Add dw-hdmi driver for jz4780

2021-12-01 Thread Paul Cercueil
Hi Nikolaus, Mark, Le mer., déc. 1 2021 at 14:51:51 +0100, H. Nikolaus Schaller a écrit : Hi, Am 01.12.2021 um 14:39 schrieb Mark Brown : On Wed, Dec 01, 2021 at 01:02:45PM +, Paul Cercueil wrote: Le mar., nov. 30 2021 at 22:26:37 +0100, H. Nikolaus Schaller + regulator = d

Re: [PATCH v10 4/8] drm/ingenic: Add dw-hdmi driver for jz4780

2021-12-01 Thread H. Nikolaus Schaller
Hi, > Am 01.12.2021 um 14:39 schrieb Mark Brown : > > On Wed, Dec 01, 2021 at 01:02:45PM +, Paul Cercueil wrote: >> Le mar., nov. 30 2021 at 22:26:37 +0100, H. Nikolaus Schaller > >>> + regulator = devm_regulator_get_optional(&pdev->dev, "hdmi-5v"); >>> + if (IS_ERR(regulator)) { >>> +

Re: [PATCH v10 4/8] drm/ingenic: Add dw-hdmi driver for jz4780

2021-12-01 Thread Mark Brown
On Wed, Dec 01, 2021 at 01:02:45PM +, Paul Cercueil wrote: > Le mar., nov. 30 2021 at 22:26:37 +0100, H. Nikolaus Schaller > > + regulator = devm_regulator_get_optional(&pdev->dev, "hdmi-5v"); > > + if (IS_ERR(regulator)) { > > + ret = PTR_ERR(regulator); Why is this using _opti

Re: [PATCH v10 4/8] drm/ingenic: Add dw-hdmi driver for jz4780

2021-12-01 Thread H. Nikolaus Schaller
Hi Paul, > Am 01.12.2021 um 14:02 schrieb Paul Cercueil : > > Hi Nikolaus, > > Le mar., nov. 30 2021 at 22:26:37 +0100, H. Nikolaus Schaller > a écrit : >> From: Paul Boddie >> A specialisation of the generic Synopsys HDMI driver is employed for >> JZ4780 HDMI support. This requires a new dr

Re: [PATCH v10 4/8] drm/ingenic: Add dw-hdmi driver for jz4780

2021-12-01 Thread Paul Cercueil
Hi Nikolaus, Le mar., nov. 30 2021 at 22:26:37 +0100, H. Nikolaus Schaller a écrit : From: Paul Boddie A specialisation of the generic Synopsys HDMI driver is employed for JZ4780 HDMI support. This requires a new driver, plus device tree and configuration modifications. Here we add Kconfig

[PATCH v10 4/8] drm/ingenic: Add dw-hdmi driver for jz4780

2021-11-30 Thread H. Nikolaus Schaller
From: Paul Boddie A specialisation of the generic Synopsys HDMI driver is employed for JZ4780 HDMI support. This requires a new driver, plus device tree and configuration modifications. Here we add Kconfig DRM_INGENIC_DW_HDMI, Makefile and driver code. Signed-off-by: Paul Boddie Signed-off-by: