Re: [PATCH v1 4/4] drm/panel: ili9806e: Break some CMDS into helper functions

On 12/07/2024 17:50, Doug Anderson wrote: Hi, On Fri, Jul 12, 2024 at 7:56 AM wrote: On 11/07/2024 21:36, Doug Anderson wrote: Hi, On Wed, Jul 10, 2024 at 6:09 PM cong yang wrote: Hi, Michael Walle 于2024年7月11日周四 03:38写道： On Wed Jul 10, 2024 at 9:12 PM CEST, Doug Anderson wrote: Hi,

Re: [PATCH v1 4/4] drm/panel: ili9806e: Break some CMDS into helper functions

Hi, On Fri, Jul 12, 2024 at 7:56 AM wrote: > > On 11/07/2024 21:36, Doug Anderson wrote: > > Hi, > > > > On Wed, Jul 10, 2024 at 6:09 PM cong yang > > wrote: > >> > >> Hi, > >> > >> Michael Walle 于2024年7月11日周四 03:38写道： > >>> > >>> On Wed Jul 10, 2024 at 9:12 PM CEST, Doug Anderson wrote: >

Re: [PATCH v1 4/4] drm/panel: ili9806e: Break some CMDS into helper functions

On 11/07/2024 21:36, Doug Anderson wrote: Hi, On Wed, Jul 10, 2024 at 6:09 PM cong yang wrote: Hi, Michael Walle 于2024年7月11日周四 03:38写道： On Wed Jul 10, 2024 at 9:12 PM CEST, Doug Anderson wrote: Hi, On Wed, Jul 10, 2024 at 2:02 AM Michael Walle wrote: On Wed Jul 10, 2024 at 10:47 AM C

Re: [PATCH v1 4/4] drm/panel: ili9806e: Break some CMDS into helper functions

Hi, On Wed, Jul 10, 2024 at 6:09 PM cong yang wrote: > > Hi, > > Michael Walle 于2024年7月11日周四 03:38写道： > > > > On Wed Jul 10, 2024 at 9:12 PM CEST, Doug Anderson wrote: > > > Hi, > > > > > > On Wed, Jul 10, 2024 at 2:02 AM Michael Walle wrote: > > > > > > > > On Wed Jul 10, 2024 at 10:47 AM CEST

Re: [PATCH v1 4/4] drm/panel: ili9806e: Break some CMDS into helper functions

Hi, Michael Walle 于2024年7月11日周四 03:38写道： > > On Wed Jul 10, 2024 at 9:12 PM CEST, Doug Anderson wrote: > > Hi, > > > > On Wed, Jul 10, 2024 at 2:02 AM Michael Walle wrote: > > > > > > On Wed Jul 10, 2024 at 10:47 AM CEST, Cong Yang wrote: > > > > Break select page cmds into helper function. > >

Re: [PATCH v1 4/4] drm/panel: ili9806e: Break some CMDS into helper functions

On Wed Jul 10, 2024 at 9:12 PM CEST, Doug Anderson wrote: > Hi, > > On Wed, Jul 10, 2024 at 2:02 AM Michael Walle wrote: > > > > On Wed Jul 10, 2024 at 10:47 AM CEST, Cong Yang wrote: > > > Break select page cmds into helper function. > > > > Why though? I don't find that anything easier to read.

Re: [PATCH v1 4/4] drm/panel: ili9806e: Break some CMDS into helper functions

Hi, On Wed, Jul 10, 2024 at 2:02 AM Michael Walle wrote: > > On Wed Jul 10, 2024 at 10:47 AM CEST, Cong Yang wrote: > > Break select page cmds into helper function. > > Why though? I don't find that anything easier to read. In fact, I > deliberately chose not to factor that out into a function. I

Re: [PATCH v1 4/4] drm/panel: ili9806e: Break some CMDS into helper functions

On Wed Jul 10, 2024 at 10:47 AM CEST, Cong Yang wrote: > Break select page cmds into helper function. Why though? I don't find that anything easier to read. In fact, I deliberately chose not to factor that out into a function. It's just a sequence of magic commands, taken straight from the datashe

[PATCH v1 4/4] drm/panel: ili9806e: Break some CMDS into helper functions

Break select page cmds into helper function. Signed-off-by: Cong Yang --- drivers/gpu/drm/panel/panel-ilitek-ili9806e.c | 14 ++ 1 file changed, 10 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/panel/panel-ilitek-ili9806e.c b/drivers/gpu/drm/panel/panel-ilitek-ili9806e