Re: [PATCH v1 3/7] mfd: add atmel-lcdc driver

2018-08-24 Thread Lee Jones
On Fri, 24 Aug 2018, Boris Brezillon wrote: > Hi Lee, > > On Wed, 15 Aug 2018 06:24:35 +0100 > Lee Jones wrote: > > > > +static const struct mfd_cell lcdc_cells[] = { > > > + { > > > + .name = "atmel-lcdc-pwm", > > > + .of_compatible = "atmel,lcdc-pwm", > > > + }, > > > + { > >

Re: [PATCH v1 3/7] mfd: add atmel-lcdc driver

2018-08-24 Thread Boris Brezillon
On Sun, 12 Aug 2018 20:46:25 +0200 Sam Ravnborg wrote: > The LCDC IP used by some Atmel SOC's have a > multifunction device that include two sub-devices: > - pwm > - display controller > > This mfd device provide a regmap that can be used by the > sub-devices to safely access the reg

Re: [PATCH v1 3/7] mfd: add atmel-lcdc driver

2018-08-24 Thread Boris Brezillon
On Thu, 16 Aug 2018 10:28:54 +0200 Nicolas Ferre wrote: > On 15/08/2018 at 22:40, Sam Ravnborg wrote: > > Hi Lee. > > > >>> + > >>> +static const struct mfd_cell lcdc_cells[] = { > >>> + { > >>> + .name = "atmel-lcdc-pwm", > >>> + .of_compatible = "atmel,lcdc-pwm", > >>> + }, >

Re: [PATCH v1 3/7] mfd: add atmel-lcdc driver

2018-08-24 Thread Boris Brezillon
Hi Lee, On Wed, 15 Aug 2018 06:24:35 +0100 Lee Jones wrote: > > +static const struct mfd_cell lcdc_cells[] = { > > + { > > + .name = "atmel-lcdc-pwm", > > + .of_compatible = "atmel,lcdc-pwm", > > + }, > > + { > > + .name = "atmel-lcdc-dc", > > + .of_

Re: [PATCH v1 3/7] mfd: add atmel-lcdc driver

2018-08-17 Thread Nicolas Ferre
On 15/08/2018 at 22:40, Sam Ravnborg wrote: Hi Lee. + +static const struct mfd_cell lcdc_cells[] = { + { + .name = "atmel-lcdc-pwm", + .of_compatible = "atmel,lcdc-pwm", + }, + { + .name = "atmel-lcdc-dc", + .of_compatibl

Re: [PATCH v1 3/7] mfd: add atmel-lcdc driver

2018-08-16 Thread Lee Jones
On Thu, 16 Aug 2018, Nicolas Ferre wrote: > On 15/08/2018 at 22:40, Sam Ravnborg wrote: > > Hi Lee. > > > > > > + > > > > +static const struct mfd_cell lcdc_cells[] = { > > > > + { > > > > + .name = "atmel-lcdc-pwm", > > > > + .of_compatible = "atmel,lcdc-pwm", >

Re: [PATCH v1 3/7] mfd: add atmel-lcdc driver

2018-08-15 Thread Sam Ravnborg
Hi Lee. > > + > > +static const struct mfd_cell lcdc_cells[] = { > > + { > > + .name = "atmel-lcdc-pwm", > > + .of_compatible = "atmel,lcdc-pwm", > > + }, > > + { > > + .name = "atmel-lcdc-dc", > > + .of_compatible = "atmel,lcdc-display-controller", >

Re: [PATCH v1 3/7] mfd: add atmel-lcdc driver

2018-08-15 Thread kbuild test robot
Hi Sam, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on at91/at91-next] [also build test WARNING on v4.18 next-20180814] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linu

Re: [PATCH v1 3/7] mfd: add atmel-lcdc driver

2018-08-14 Thread Lee Jones
On Sun, 12 Aug 2018, Sam Ravnborg wrote: > The LCDC IP used by some Atmel SOC's have a > multifunction device that include two sub-devices: > - pwm > - display controller > > This mfd device provide a regmap that can be used by the > sub-devices to safely access the registers. > The m

Re: [PATCH v1 3/7] mfd: add atmel-lcdc driver

2018-08-14 Thread kbuild test robot
Hi Sam, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on at91/at91-next] [also build test WARNING on v4.18 next-20180813] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linu

[PATCH v1 3/7] mfd: add atmel-lcdc driver

2018-08-13 Thread Sam Ravnborg
The LCDC IP used by some Atmel SOC's have a multifunction device that include two sub-devices: - pwm - display controller This mfd device provide a regmap that can be used by the sub-devices to safely access the registers. The mfd device also support the clock used by the LCDC IP + a b