Re: [PATCH v1 3/4] drm/ls2kbmc: Add support for Loongson-2K BMC display

2025-01-15 Thread Thomas Zimmermann
Hi, after the discussion, let me give you a preliminary review. Am 30.12.24 um 10:31 schrieb Binbin Zhou: Adds a driver for the Loongson-2K BMC display as a sub-function of the BMC device. Display-related scan output buffers, sizes, and display formats are provided through the Loongson-2K BMC

Re: [PATCH v1 3/4] drm/ls2kbmc: Add support for Loongson-2K BMC display

2025-01-09 Thread Binbin Zhou
Hi Thomas: Sorry for the late reply. On Mon, Jan 6, 2025 at 10:10 PM Thomas Zimmermann wrote: > > Hi, > > Thanks for the info. > > > Am 06.01.25 um 08:03 schrieb Binbin Zhou: > [...] > >> Could you point to the exact call that fails within simpledrm? > > If we use simpledrm directly, the followi

Re: [PATCH v1 3/4] drm/ls2kbmc: Add support for Loongson-2K BMC display

2025-01-06 Thread Thomas Zimmermann
Hi, Thanks for the info. Am 06.01.25 um 08:03 schrieb Binbin Zhou: [...] Could you point to the exact call that fails within simpledrm? If we use simpledrm directly, the following error occurs: [8.289823] simple-framebuffer simple-framebuffer.0: [drm] *ERROR* could not acquire memory ran

Re: [PATCH v1 3/4] drm/ls2kbmc: Add support for Loongson-2K BMC display

2025-01-05 Thread Binbin Zhou
Hi Thomas: The last reply email was incomplete, sorry for the incomplete reply due to my mistake. On Thu, Jan 2, 2025 at 9:32 PM Thomas Zimmermann wrote: > > Hi > > > Am 02.01.25 um 13:55 schrieb Binbin Zhou: > > Hi Thomas: > > > > Thanks for your reply. > > > > On Thu, Jan 2, 2025 at 5:07 PM Th

Re: [PATCH v1 3/4] drm/ls2kbmc: Add support for Loongson-2K BMC display

2025-01-05 Thread Binbin Zhou
Hi Thomas: On Thu, Jan 2, 2025 at 9:32 PM Thomas Zimmermann wrote: > > Hi > > > Am 02.01.25 um 13:55 schrieb Binbin Zhou: > > Hi Thomas: > > > > Thanks for your reply. > > > > On Thu, Jan 2, 2025 at 5:07 PM Thomas Zimmermann > > wrote: > >> Hi > >> > >> > >> Am 30.12.24 um 10:31 schrieb Binbin

Re: [PATCH v1 3/4] drm/ls2kbmc: Add support for Loongson-2K BMC display

2025-01-02 Thread Binbin Zhou
Hi Thomas: Thanks for your reply. On Thu, Jan 2, 2025 at 5:07 PM Thomas Zimmermann wrote: > > Hi > > > Am 30.12.24 um 10:31 schrieb Binbin Zhou: > [...] > > + > > +static struct platform_driver ls2kbmc_platform_driver = { > > + .driver = { > > + .name = "ls2kbmc-framebuffer", > >

Re: [PATCH v1 3/4] drm/ls2kbmc: Add support for Loongson-2K BMC display

2025-01-02 Thread Thomas Zimmermann
Hi Am 02.01.25 um 13:55 schrieb Binbin Zhou: Hi Thomas: Thanks for your reply. On Thu, Jan 2, 2025 at 5:07 PM Thomas Zimmermann wrote: Hi Am 30.12.24 um 10:31 schrieb Binbin Zhou: [...] + +static struct platform_driver ls2kbmc_platform_driver = { + .driver = { + .name = "

Re: [PATCH v1 3/4] drm/ls2kbmc: Add support for Loongson-2K BMC display

2025-01-02 Thread Thomas Zimmermann
Hi Am 30.12.24 um 10:31 schrieb Binbin Zhou: [...] + +static struct platform_driver ls2kbmc_platform_driver = { + .driver = { + .name = "ls2kbmc-framebuffer", The driver is mostly a copy of simpledrm. Why don't you use "simple-framebuffer" for your device name? You could

[PATCH v1 3/4] drm/ls2kbmc: Add support for Loongson-2K BMC display

2024-12-31 Thread Binbin Zhou
Adds a driver for the Loongson-2K BMC display as a sub-function of the BMC device. Display-related scan output buffers, sizes, and display formats are provided through the Loongson-2K BMC MFD driver. Co-developed-by: Chong Qiao Signed-off-by: Chong Qiao Signed-off-by: Binbin Zhou --- drivers/