Re: [PATCH v1 2/4] drm/i915: Add missing mask when reading GEN12_DSMBASE

2022-09-16 Thread Iddamsetty, Aravind
On 16-09-2022 02:09, Lucas De Marchi wrote: > DSMBASE register is defined so BDSM bitfield contains the bits 63 to 20 > of the base address of stolen. For the supported platforms bits 0-19 are > zero but that may not be true in future. Add the missing mask. > > Signed-off-by: Lucas De Marchi

Re: [Intel-gfx] [PATCH v1 2/4] drm/i915: Add missing mask when reading GEN12_DSMBASE

2022-09-15 Thread kernel test robot
Hi Lucas, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on bb4f6b2281b11b009210f62eecd291f7b75c1e85] url: https://github.com/intel-lab-lkp/linux/commits/Lucas-De-Marchi/drm-i915-Improvements-to-stolen-memory-setup/20220916-044155 base: bb4f6b2281b11b009210

Re: [Intel-gfx] [PATCH v1 2/4] drm/i915: Add missing mask when reading GEN12_DSMBASE

2022-09-15 Thread kernel test robot
Hi Lucas, Thank you for the patch! Yet something to improve: [auto build test ERROR on bb4f6b2281b11b009210f62eecd291f7b75c1e85] url: https://github.com/intel-lab-lkp/linux/commits/Lucas-De-Marchi/drm-i915-Improvements-to-stolen-memory-setup/20220916-044155 base: bb4f6b2281b11b009210f62eec

Re: [Intel-gfx] [PATCH v1 2/4] drm/i915: Add missing mask when reading GEN12_DSMBASE

2022-09-15 Thread Caz Yokoyama
Reviewed-by: Caz Yokoyama Better to be safe. On Thu, Sep 15, 2022 at 1:40 PM Lucas De Marchi wrote: > DSMBASE register is defined so BDSM bitfield contains the bits 63 to 20 > of the base address of stolen. For the supported platforms bits 0-19 are > zero but that may not be true in future. A

[PATCH v1 2/4] drm/i915: Add missing mask when reading GEN12_DSMBASE

2022-09-15 Thread Lucas De Marchi
DSMBASE register is defined so BDSM bitfield contains the bits 63 to 20 of the base address of stolen. For the supported platforms bits 0-19 are zero but that may not be true in future. Add the missing mask. Signed-off-by: Lucas De Marchi diff --git a/drivers/gpu/drm/i915/gem/i915_gem_stolen.c