Re: [PATCH v1 2/3] xfs/libxfs: replace kmalloc() and memcpy() with kmemdup()

2025-01-14 Thread Carlos Maiolino
On Tue, 17 Dec 2024 23:58:12 +0100, Mirsad Todorovac wrote: > The source static analysis tool gave the following advice: > > ./fs/xfs/libxfs/xfs_dir2.c:382:15-22: WARNING opportunity for kmemdup > > → 382 args->value = kmalloc(len, >383 GFP_KERNEL | __GFP_NOL

Re: [PATCH v1 2/3] xfs/libxfs: replace kmalloc() and memcpy() with kmemdup()

2025-01-09 Thread Carlos Maiolino
Hi Mirsad. Did you send only this patch, or did I miss patch 1 and 3 of the series? I can't find them anywhere. Carlos On Tue, Dec 17, 2024 at 11:58:12PM +0100, Mirsad Todorovac wrote: > The source static analysis tool gave the following advice: > > ./fs/xfs/libxfs/xfs_dir2.c:382:15-22: WARNING

Re: [PATCH v1 2/3] xfs/libxfs: replace kmalloc() and memcpy() with kmemdup()

2025-01-06 Thread Darrick J. Wong
On Sun, Dec 29, 2024 at 01:58:19PM +0100, Andrey Albershteyn wrote: > On 2024-12-18 16:35:21, Darrick J. Wong wrote: > > On Tue, Dec 17, 2024 at 11:58:12PM +0100, Mirsad Todorovac wrote: > > > The source static analysis tool gave the following advice: > > > > > > ./fs/xfs/libxfs/xfs_dir2.c:382:15-

Re: [PATCH v1 2/3] xfs/libxfs: replace kmalloc() and memcpy() with kmemdup()

2024-12-29 Thread Andrey Albershteyn
On 2024-12-18 16:35:21, Darrick J. Wong wrote: > On Tue, Dec 17, 2024 at 11:58:12PM +0100, Mirsad Todorovac wrote: > > The source static analysis tool gave the following advice: > > > > ./fs/xfs/libxfs/xfs_dir2.c:382:15-22: WARNING opportunity for kmemdup > > > > → 382 args->value = kmal

Re: [PATCH v1 2/3] xfs/libxfs: replace kmalloc() and memcpy() with kmemdup()

2024-12-18 Thread Darrick J. Wong
On Tue, Dec 17, 2024 at 11:58:12PM +0100, Mirsad Todorovac wrote: > The source static analysis tool gave the following advice: > > ./fs/xfs/libxfs/xfs_dir2.c:382:15-22: WARNING opportunity for kmemdup > > → 382 args->value = kmalloc(len, >383 GFP_KERNEL | __G

[PATCH v1 2/3] xfs/libxfs: replace kmalloc() and memcpy() with kmemdup()

2024-12-17 Thread Mirsad Todorovac
The source static analysis tool gave the following advice: ./fs/xfs/libxfs/xfs_dir2.c:382:15-22: WARNING opportunity for kmemdup → 382 args->value = kmalloc(len, 383 GFP_KERNEL | __GFP_NOLOCKDEP | __GFP_RETRY_MAYFAIL); 384 if (!args->value) 385