Hi Lowry,
Based on Daniel's input, this patch looks fine:
Reviewed-by: Brian Starkey
I think there's some opportunity for improvement around
prepare_signaling/complete_signaling, but that can be treated as
separate from fixing this bug.
Thanks,
-Brian
On Wed, Jul 31, 2019 at 11:04:45AM +,
On Fri, Aug 02, 2019 at 10:09:05AM +, Brian Starkey wrote:
> Hi Daniel,
>
> On Fri, Aug 02, 2019 at 11:45:13AM +0200, Daniel Vetter wrote:
> > On Fri, Aug 2, 2019 at 11:43 AM Daniel Vetter wrote:
> > >
> > > On Fri, Aug 2, 2019 at 11:29 AM Brian Starkey
> > > wrote:
> > > >
> > > > Hi Lowry
On Fri, Aug 02, 2019 at 05:29:20PM +0800, Brian Starkey wrote:
> Hi Lowry,
>
> On Thu, Aug 01, 2019 at 06:34:08AM +, Lowry Li (Arm Technology China)
> wrote:
> > Hi Brian,
> >
> > On Wed, Jul 31, 2019 at 09:20:04PM +0800, Brian Starkey wrote:
> > > Hi Lowry,
> > >
> > > Thanks for this clea
Hi Daniel,
On Fri, Aug 02, 2019 at 11:45:13AM +0200, Daniel Vetter wrote:
> On Fri, Aug 2, 2019 at 11:43 AM Daniel Vetter wrote:
> >
> > On Fri, Aug 2, 2019 at 11:29 AM Brian Starkey wrote:
> > >
> > > Hi Lowry,
> > >
> > > On Thu, Aug 01, 2019 at 06:34:08AM +, Lowry Li (Arm Technology China
On Fri, Aug 2, 2019 at 11:43 AM Daniel Vetter wrote:
>
> On Fri, Aug 2, 2019 at 11:29 AM Brian Starkey wrote:
> >
> > Hi Lowry,
> >
> > On Thu, Aug 01, 2019 at 06:34:08AM +, Lowry Li (Arm Technology China)
> > wrote:
> > > Hi Brian,
> > >
> > > On Wed, Jul 31, 2019 at 09:20:04PM +0800, Brian
On Fri, Aug 2, 2019 at 11:29 AM Brian Starkey wrote:
>
> Hi Lowry,
>
> On Thu, Aug 01, 2019 at 06:34:08AM +, Lowry Li (Arm Technology China)
> wrote:
> > Hi Brian,
> >
> > On Wed, Jul 31, 2019 at 09:20:04PM +0800, Brian Starkey wrote:
> > > Hi Lowry,
> > >
> > > Thanks for this cleanup.
> > >
Hi Lowry,
On Thu, Aug 01, 2019 at 06:34:08AM +, Lowry Li (Arm Technology China) wrote:
> Hi Brian,
>
> On Wed, Jul 31, 2019 at 09:20:04PM +0800, Brian Starkey wrote:
> > Hi Lowry,
> >
> > Thanks for this cleanup.
> >
> > On Wed, Jul 31, 2019 at 11:04:45AM +, Lowry Li (Arm Technology Chi
On Thu, Aug 01, 2019 at 06:31:13AM +, Lowry Li (Arm Technology China) wrote:
> Hi Liviu,
>
> On Wed, Jul 31, 2019 at 01:15:25PM +, Liviu Dudau wrote:
> > Hi Lowry,
> >
> > On Wed, Jul 31, 2019 at 11:04:45AM +, Lowry Li (Arm Technology China)
> > wrote:
> > > During it signals the com
Hi Brian,
On Wed, Jul 31, 2019 at 09:20:04PM +0800, Brian Starkey wrote:
> Hi Lowry,
>
> Thanks for this cleanup.
>
> On Wed, Jul 31, 2019 at 11:04:45AM +, Lowry Li (Arm Technology China)
> wrote:
> > During it signals the completion of a writeback job, after releasing
> > the out_fence, we
Hi Liviu,
On Wed, Jul 31, 2019 at 01:15:25PM +, Liviu Dudau wrote:
> Hi Lowry,
>
> On Wed, Jul 31, 2019 at 11:04:45AM +, Lowry Li (Arm Technology China)
> wrote:
> > During it signals the completion of a writeback job, after releasing
> > the out_fence, we'd clear the pointer.
> >
> > C
Hi Lowry,
Thanks for this cleanup.
On Wed, Jul 31, 2019 at 11:04:45AM +, Lowry Li (Arm Technology China) wrote:
> During it signals the completion of a writeback job, after releasing
> the out_fence, we'd clear the pointer.
>
> Check if fence left over in drm_writeback_cleanup_job(), release
Hi Lowry,
On Wed, Jul 31, 2019 at 11:04:45AM +, Lowry Li (Arm Technology China) wrote:
> During it signals the completion of a writeback job, after releasing
> the out_fence, we'd clear the pointer.
>
> Check if fence left over in drm_writeback_cleanup_job(), release it.
>
> Signed-off-by: L
During it signals the completion of a writeback job, after releasing
the out_fence, we'd clear the pointer.
Check if fence left over in drm_writeback_cleanup_job(), release it.
Signed-off-by: Lowry Li (Arm Technology China)
---
drivers/gpu/drm/drm_writeback.c | 23 +++
1 fil
13 matches
Mail list logo
