Re: [PATCH v1 1/6] drm/lima: fix devfreq refcount imbalance for job timeouts

2024-01-23 Thread Qiang Yu
On Wed, Jan 24, 2024 at 7:19 AM Erico Nunes wrote: > > On Fri, Jan 19, 2024 at 2:50 AM Qiang Yu wrote: > > > > On Thu, Jan 18, 2024 at 7:14 PM Erico Nunes wrote: > > > > > > On Thu, Jan 18, 2024 at 2:36 AM Qiang Yu wrote: > > > > > > > > So this is caused by same job trigger both done and timeo

Re: [PATCH v1 1/6] drm/lima: fix devfreq refcount imbalance for job timeouts

2024-01-23 Thread Erico Nunes
On Fri, Jan 19, 2024 at 2:50 AM Qiang Yu wrote: > > On Thu, Jan 18, 2024 at 7:14 PM Erico Nunes wrote: > > > > On Thu, Jan 18, 2024 at 2:36 AM Qiang Yu wrote: > > > > > > So this is caused by same job trigger both done and timeout handling? > > > I think a better way to solve this is to make sur

Re: [PATCH v1 1/6] drm/lima: fix devfreq refcount imbalance for job timeouts

2024-01-18 Thread Qiang Yu
On Thu, Jan 18, 2024 at 7:14 PM Erico Nunes wrote: > > On Thu, Jan 18, 2024 at 2:36 AM Qiang Yu wrote: > > > > So this is caused by same job trigger both done and timeout handling? > > I think a better way to solve this is to make sure only one handler > > (done or timeout) process the job instea

Re: [PATCH v1 1/6] drm/lima: fix devfreq refcount imbalance for job timeouts

2024-01-18 Thread Erico Nunes
On Thu, Jan 18, 2024 at 2:36 AM Qiang Yu wrote: > > So this is caused by same job trigger both done and timeout handling? > I think a better way to solve this is to make sure only one handler > (done or timeout) process the job instead of just making lima_pm_idle() > unique. It's not very clear t

Re: [PATCH v1 1/6] drm/lima: fix devfreq refcount imbalance for job timeouts

2024-01-17 Thread Qiang Yu
So this is caused by same job trigger both done and timeout handling? I think a better way to solve this is to make sure only one handler (done or timeout) process the job instead of just making lima_pm_idle() unique. Regards, Qiang On Wed, Jan 17, 2024 at 11:12 AM Erico Nunes wrote: > > In case

Re: [PATCH v1 1/6] drm/lima: fix devfreq refcount imbalance for job timeouts

2024-01-17 Thread Vasily Khoruzhick
On Tue, Jan 16, 2024 at 7:12 PM Erico Nunes wrote: > > In case a task manages to complete but it took just long enough to also > trigger the timeout handler, the current code results in a refcount > imbalance on lima_pm_idle. > > While this can be a rare occurrence, when it happens it may fill use

[PATCH v1 1/6] drm/lima: fix devfreq refcount imbalance for job timeouts

2024-01-16 Thread Erico Nunes
In case a task manages to complete but it took just long enough to also trigger the timeout handler, the current code results in a refcount imbalance on lima_pm_idle. While this can be a rare occurrence, when it happens it may fill user logs with stack traces such as: [10136.669170] WARNING: CPU: