Re: [PATCH v1 1/4] misc: fastrpc: Add CRC support using invokeV2 request

2025-01-23 Thread Ekansh Gupta
On 1/23/2025 6:03 PM, Dmitry Baryshkov wrote: > On Thu, Jan 23, 2025 at 05:34:00PM +0530, Ekansh Gupta wrote: >> >> >> On 1/23/2025 4:43 PM, Dmitry Baryshkov wrote: >>> On Thu, Jan 23, 2025 at 03:19:21PM +0530, Ekansh Gupta wrote: On 1/23/2025 1:18 PM, Dmitry Baryshkov wrote: > On

Re: [PATCH v1 1/4] misc: fastrpc: Add CRC support using invokeV2 request

2025-01-23 Thread Dmitry Baryshkov
On Thu, Jan 23, 2025 at 05:34:00PM +0530, Ekansh Gupta wrote: > > > > On 1/23/2025 4:43 PM, Dmitry Baryshkov wrote: > > On Thu, Jan 23, 2025 at 03:19:21PM +0530, Ekansh Gupta wrote: > >> > >> > >> On 1/23/2025 1:18 PM, Dmitry Baryshkov wrote: > >>> On Thu, Jan 23, 2025 at 11:16:41AM +0530, Ekans

Re: [PATCH v1 1/4] misc: fastrpc: Add CRC support using invokeV2 request

2025-01-23 Thread Ekansh Gupta
On 1/23/2025 4:43 PM, Dmitry Baryshkov wrote: > On Thu, Jan 23, 2025 at 03:19:21PM +0530, Ekansh Gupta wrote: >> >> >> On 1/23/2025 1:18 PM, Dmitry Baryshkov wrote: >>> On Thu, Jan 23, 2025 at 11:16:41AM +0530, Ekansh Gupta wrote: On 10/7/2024 7:27 PM, Dmitry Baryshkov wrote: > On

Re: [PATCH v1 1/4] misc: fastrpc: Add CRC support using invokeV2 request

2025-01-23 Thread Dmitry Baryshkov
On Thu, Jan 23, 2025 at 03:19:21PM +0530, Ekansh Gupta wrote: > > > > On 1/23/2025 1:18 PM, Dmitry Baryshkov wrote: > > On Thu, Jan 23, 2025 at 11:16:41AM +0530, Ekansh Gupta wrote: > >> > >> > >> On 10/7/2024 7:27 PM, Dmitry Baryshkov wrote: > >>> On Mon, Oct 07, 2024 at 02:15:15PM GMT, Ekansh

Re: [PATCH v1 1/4] misc: fastrpc: Add CRC support using invokeV2 request

2025-01-23 Thread Ekansh Gupta
On 1/23/2025 1:18 PM, Dmitry Baryshkov wrote: > On Thu, Jan 23, 2025 at 11:16:41AM +0530, Ekansh Gupta wrote: >> >> >> On 10/7/2024 7:27 PM, Dmitry Baryshkov wrote: >>> On Mon, Oct 07, 2024 at 02:15:15PM GMT, Ekansh Gupta wrote: InvokeV2 request is intended to support multiple enhanced inv

Re: [PATCH v1 1/4] misc: fastrpc: Add CRC support using invokeV2 request

2025-01-22 Thread Dmitry Baryshkov
On Thu, Jan 23, 2025 at 11:16:41AM +0530, Ekansh Gupta wrote: > > > > On 10/7/2024 7:27 PM, Dmitry Baryshkov wrote: > > On Mon, Oct 07, 2024 at 02:15:15PM GMT, Ekansh Gupta wrote: > >> InvokeV2 request is intended to support multiple enhanced invoke > >> requests like CRC check, performance coun

Re: [PATCH v1 1/4] misc: fastrpc: Add CRC support using invokeV2 request

2025-01-22 Thread Ekansh Gupta
On 10/7/2024 7:27 PM, Dmitry Baryshkov wrote: > On Mon, Oct 07, 2024 at 02:15:15PM GMT, Ekansh Gupta wrote: >> InvokeV2 request is intended to support multiple enhanced invoke >> requests like CRC check, performance counter enablement and polling >> mode for RPC invocations. CRC check is gettin

Re: [PATCH v1 1/4] misc: fastrpc: Add CRC support using invokeV2 request

2024-10-09 Thread Ekansh Gupta
On 10/7/2024 2:23 PM, Greg KH wrote: > On Mon, Oct 07, 2024 at 02:15:15PM +0530, Ekansh Gupta wrote: >> +struct fastrpc_invoke_v2 { >> +struct fastrpc_invoke inv; >> +__u64 crc; >> +__u32 reserved[16]; > I'm sure we have been over this before, but if you have a reserved > field, you

Re: [PATCH v1 1/4] misc: fastrpc: Add CRC support using invokeV2 request

2024-10-08 Thread kernel test robot
64734 base: char-misc/char-misc-testing patch link: https://lore.kernel.org/r/20241007084518.3649876-2-quic_ekangupt%40quicinc.com patch subject: [PATCH v1 1/4] misc: fastrpc: Add CRC support using invokeV2 request config: alpha-randconfig-r112-20241008 (https://download.01.org/0day-ci/archiv

Re: [PATCH v1 1/4] misc: fastrpc: Add CRC support using invokeV2 request

2024-10-07 Thread kernel test robot
se: char-misc/char-misc-testing patch link: https://lore.kernel.org/r/20241007084518.3649876-2-quic_ekangupt%40quicinc.com patch subject: [PATCH v1 1/4] misc: fastrpc: Add CRC support using invokeV2 request config: loongarch-allmodconfig (https://download.01.org/0day-ci/archive/20241008/20

Re: [PATCH v1 1/4] misc: fastrpc: Add CRC support using invokeV2 request

2024-10-07 Thread kernel test robot
se: char-misc/char-misc-testing patch link: https://lore.kernel.org/r/20241007084518.3649876-2-quic_ekangupt%40quicinc.com patch subject: [PATCH v1 1/4] misc: fastrpc: Add CRC support using invokeV2 request config: arm-randconfig-002-20241008 (https://download.01.org/0day-ci/archiv

Re: [PATCH v1 1/4] misc: fastrpc: Add CRC support using invokeV2 request

2024-10-07 Thread kernel test robot
64734 base: char-misc/char-misc-testing patch link: https://lore.kernel.org/r/20241007084518.3649876-2-quic_ekangupt%40quicinc.com patch subject: [PATCH v1 1/4] misc: fastrpc: Add CRC support using invokeV2 request config: arc-randconfig-001-20241008 (https://download.01.org/0day-ci/archiv

Re: [PATCH v1 1/4] misc: fastrpc: Add CRC support using invokeV2 request

2024-10-07 Thread Dmitry Baryshkov
On Mon, Oct 07, 2024 at 02:15:15PM GMT, Ekansh Gupta wrote: > InvokeV2 request is intended to support multiple enhanced invoke > requests like CRC check, performance counter enablement and polling > mode for RPC invocations. CRC check is getting enabled as part of > this patch. CRC check for input

Re: [PATCH v1 1/4] misc: fastrpc: Add CRC support using invokeV2 request

2024-10-07 Thread Greg KH
On Mon, Oct 07, 2024 at 02:15:15PM +0530, Ekansh Gupta wrote: > +struct fastrpc_invoke_v2 { > + struct fastrpc_invoke inv; > + __u64 crc; > + __u32 reserved[16]; I'm sure we have been over this before, but if you have a reserved field, you HAVE to check that it is zero if you ever want

[PATCH v1 1/4] misc: fastrpc: Add CRC support using invokeV2 request

2024-10-07 Thread Ekansh Gupta
InvokeV2 request is intended to support multiple enhanced invoke requests like CRC check, performance counter enablement and polling mode for RPC invocations. CRC check is getting enabled as part of this patch. CRC check for input and output argument helps in ensuring data consistency over a remote