Re: [PATCH v1 1/4] fbtft: Unorphan the driver

2022-02-01 Thread Sam Ravnborg
Hi Daniel, On Tue, Feb 01, 2022 at 06:06:33PM +0100, Daniel Vetter wrote: > On Tue, Feb 1, 2022 at 6:01 PM Geert Uytterhoeven > wrote: > > > > Hi Thomas, > > > > On Tue, Feb 1, 2022 at 5:16 PM Thomas Zimmermann > > wrote: > > > Am 31.01.22 um 11:18 schrieb Javier Martinez Canillas: > > > > Ano

Re: [PATCH v1 1/4] fbtft: Unorphan the driver

2022-02-01 Thread Thomas Zimmermann
Hi Am 01.02.22 um 18:00 schrieb Geert Uytterhoeven: Hi Thomas, On Tue, Feb 1, 2022 at 5:16 PM Thomas Zimmermann wrote: Am 31.01.22 um 11:18 schrieb Javier Martinez Canillas: Another thing that's missing is a DRM_MODE_CONNECTOR_I2C, because I used for now a DRM_MODE_CONNECTOR_Unknown. That

Re: [PATCH v1 1/4] fbtft: Unorphan the driver

2022-02-01 Thread Daniel Vetter
On Tue, Feb 1, 2022 at 6:01 PM Geert Uytterhoeven wrote: > > Hi Thomas, > > On Tue, Feb 1, 2022 at 5:16 PM Thomas Zimmermann wrote: > > Am 31.01.22 um 11:18 schrieb Javier Martinez Canillas: > > > Another thing that's missing is a DRM_MODE_CONNECTOR_I2C, because I used > > > for > > > now a DRM_

Re: [PATCH v1 1/4] fbtft: Unorphan the driver

2022-02-01 Thread Geert Uytterhoeven
Hi Thomas, On Tue, Feb 1, 2022 at 5:16 PM Thomas Zimmermann wrote: > Am 31.01.22 um 11:18 schrieb Javier Martinez Canillas: > > Another thing that's missing is a DRM_MODE_CONNECTOR_I2C, because I used for > > now a DRM_MODE_CONNECTOR_Unknown. > > That might have implications on userspace. Maybe a

Re: [PATCH v1 1/4] fbtft: Unorphan the driver

2022-01-31 Thread Andy Shevchenko
On Mon, Jan 31, 2022 at 02:55:21PM +0100, Javier Martinez Canillas wrote: > On 1/31/22 14:23, Andy Shevchenko wrote: > > On Mon, Jan 31, 2022 at 01:08:32PM +0100, Javier Martinez Canillas wrote: ... > > The tricky part is the PRP0001 > > ACPI PNP ID that allows to reuse it on ACPI-based platforms

Re: [PATCH v1 1/4] fbtft: Unorphan the driver

2022-01-31 Thread Javier Martinez Canillas
On 1/31/22 14:23, Andy Shevchenko wrote: > On Mon, Jan 31, 2022 at 01:08:32PM +0100, Javier Martinez Canillas wrote: >> On 1/31/22 12:36, Andy Shevchenko wrote: > > ... > +config TINYDRM_SSD130X + tristate "DRM support for Solomon SSD130X OLED displays" + depends on DRM && OF &&

Re: [PATCH v1 1/4] fbtft: Unorphan the driver

2022-01-31 Thread Andy Shevchenko
On Mon, Jan 31, 2022 at 03:23:13PM +0200, Andy Shevchenko wrote: > On Mon, Jan 31, 2022 at 01:08:32PM +0100, Javier Martinez Canillas wrote: > > On 1/31/22 12:36, Andy Shevchenko wrote: ... > > I actually added this dependency deliberative. It's true that the driver is > > using > > the device p

Re: [PATCH v1 1/4] fbtft: Unorphan the driver

2022-01-31 Thread Andy Shevchenko
On Mon, Jan 31, 2022 at 01:08:32PM +0100, Javier Martinez Canillas wrote: > On 1/31/22 12:36, Andy Shevchenko wrote: ... > >> +config TINYDRM_SSD130X > >> + tristate "DRM support for Solomon SSD130X OLED displays" > >> + depends on DRM && OF && I2C > > > > Please, make sure that it does NOT de

Re: [PATCH v1 1/4] fbtft: Unorphan the driver

2022-01-31 Thread Javier Martinez Canillas
Hello Andy, Thanks a lot for your feedback. On 1/31/22 12:36, Andy Shevchenko wrote: [snip] >> >> Another hack is that I am just hardcoding the {width, height}_mm, but I don't >> know what DPI could be used for these panels nor how I could calculate the >> mm. > > I think the hacks is the fir

Re: [PATCH v1 1/4] fbtft: Unorphan the driver

2022-01-31 Thread Andy Shevchenko
On Mon, Jan 31, 2022 at 09:29:33AM +0100, Javier Martinez Canillas wrote: > On 1/26/22 15:15, Javier Martinez Canillas wrote: > > On 1/26/22 15:10, Andy Shevchenko wrote: > >> On Wed, Jan 26, 2022 at 04:08:32PM +0200, Andy Shevchenko wrote: > >>> On Wed, Jan 26, 2022 at 02:46:08PM +0100, Javier Mar

Re: [PATCH v1 1/4] fbtft: Unorphan the driver

2022-01-31 Thread Thomas Zimmermann
Hi Am 31.01.22 um 11:18 schrieb Javier Martinez Canillas: Hello Thomas, On 1/31/22 10:18, Thomas Zimmermann wrote: [snip] There are some hacks in the driver though. For example it exposes an XRGB format even thought the OLED display is monochromatic and has 1 bit per pixel. The driver t

Re: [PATCH v1 1/4] fbtft: Unorphan the driver

2022-01-31 Thread Javier Martinez Canillas
Hello Thomas, On 1/31/22 10:18, Thomas Zimmermann wrote: [snip] >> There are some hacks in the driver though. For example it exposes an XRGB >> format even thought the OLED display is monochromatic and has 1 bit per >> pixel. >> >> The driver then goes and converts the XRGB pixels first

Re: [PATCH v1 1/4] fbtft: Unorphan the driver

2022-01-31 Thread Thomas Zimmermann
Hi Am 31.01.22 um 09:29 schrieb Javier Martinez Canillas: On 1/26/22 15:15, Javier Martinez Canillas wrote: On 1/26/22 15:10, Andy Shevchenko wrote: On Wed, Jan 26, 2022 at 04:08:32PM +0200, Andy Shevchenko wrote: On Wed, Jan 26, 2022 at 02:46:08PM +0100, Javier Martinez Canillas wrote: On 1

Re: [PATCH v1 1/4] fbtft: Unorphan the driver

2022-01-31 Thread Javier Martinez Canillas
On 1/26/22 15:15, Javier Martinez Canillas wrote: > On 1/26/22 15:10, Andy Shevchenko wrote: >> On Wed, Jan 26, 2022 at 04:08:32PM +0200, Andy Shevchenko wrote: >>> On Wed, Jan 26, 2022 at 02:46:08PM +0100, Javier Martinez Canillas wrote: On 1/26/22 14:12, Andy Shevchenko wrote: >> >> ... >> >

Re: [PATCH v1 1/4] fbtft: Unorphan the driver

2022-01-26 Thread Jani Nikula
On Wed, 26 Jan 2022, Andy Shevchenko wrote: > And basically create a MIPI based driver for I2C. What does that even mean? BR, Jani. -- Jani Nikula, Intel Open Source Graphics Center

Re: [PATCH v1 1/4] fbtft: Unorphan the driver

2022-01-26 Thread Javier Martinez Canillas
On 1/26/22 15:10, Andy Shevchenko wrote: > On Wed, Jan 26, 2022 at 04:08:32PM +0200, Andy Shevchenko wrote: >> On Wed, Jan 26, 2022 at 02:46:08PM +0100, Javier Martinez Canillas wrote: >>> On 1/26/22 14:12, Andy Shevchenko wrote: > > ... > >>> I've just bought a SSD1306 (I2C) based one and will a

Re: [PATCH v1 1/4] fbtft: Unorphan the driver

2022-01-26 Thread Andy Shevchenko
On Wed, Jan 26, 2022 at 04:08:32PM +0200, Andy Shevchenko wrote: > On Wed, Jan 26, 2022 at 02:46:08PM +0100, Javier Martinez Canillas wrote: > > On 1/26/22 14:12, Andy Shevchenko wrote: ... > > I've just bought a SSD1306 (I2C) based one and will attempt to write a DRM > > driver using drivers/sta

Re: [PATCH v1 1/4] fbtft: Unorphan the driver

2022-01-26 Thread Andy Shevchenko
On Wed, Jan 26, 2022 at 02:46:08PM +0100, Javier Martinez Canillas wrote: > On 1/26/22 14:12, Andy Shevchenko wrote: > > On Wed, Jan 26, 2022 at 12:26:36PM +0100, Greg Kroah-Hartman wrote: > >> On Wed, Jan 26, 2022 at 12:17:08PM +0100, Helge Deller wrote: > >>> On 1/26/22 11:31, Daniel Vetter wrote

Re: [PATCH v1 1/4] fbtft: Unorphan the driver

2022-01-26 Thread Javier Martinez Canillas
On 1/26/22 14:12, Andy Shevchenko wrote: > On Wed, Jan 26, 2022 at 12:26:36PM +0100, Greg Kroah-Hartman wrote: >> On Wed, Jan 26, 2022 at 12:17:08PM +0100, Helge Deller wrote: >>> On 1/26/22 11:31, Daniel Vetter wrote: > > ... > >>> You are describing a transitioning over to DRM - which is Ok. >>

Re: [PATCH v1 1/4] fbtft: Unorphan the driver

2022-01-26 Thread Daniel Stone
Hi, On Wed, 26 Jan 2022 at 13:08, Andy Shevchenko wrote: > It's not useful to bury the /dev/fbX out for the devices that > the use of are black-and-white output on small embedded systems. It's not useful to decide that such systems should only be supported by a subsystem which has been deprecate

Re: [PATCH v1 1/4] fbtft: Unorphan the driver

2022-01-26 Thread Andy Shevchenko
On Wed, Jan 26, 2022 at 12:26:36PM +0100, Greg Kroah-Hartman wrote: > On Wed, Jan 26, 2022 at 12:17:08PM +0100, Helge Deller wrote: > > On 1/26/22 11:31, Daniel Vetter wrote: ... > > You are describing a transitioning over to DRM - which is Ok. > > But on that way there is no need to ignore, deny

Re: [PATCH v1 1/4] fbtft: Unorphan the driver

2022-01-26 Thread Andy Shevchenko
On Wed, Jan 26, 2022 at 12:27:19PM +0100, Daniel Vetter wrote: > On Wed, Jan 26, 2022 at 12:18 PM Helge Deller wrote: > > On 1/26/22 11:31, Daniel Vetter wrote: ... > > You are describing a transitioning over to DRM - which is Ok. > > But on that way there is no need to ignore, deny or even kill

Re: [PATCH v1 1/4] fbtft: Unorphan the driver

2022-01-26 Thread Andy Shevchenko
On Wed, Jan 26, 2022 at 12:31:40PM +0100, Thomas Zimmermann wrote: > Am 26.01.22 um 12:17 schrieb Helge Deller: ... > And none of those examples is out-ruled by DRM. In fact we do support > devices that fall in those categories. > > This is last week's discussion all over again. Fine, write a d

Re: [PATCH v1 1/4] fbtft: Unorphan the driver

2022-01-26 Thread Andy Shevchenko
On Wed, Jan 26, 2022 at 12:17:08PM +0100, Helge Deller wrote: > On 1/26/22 11:31, Daniel Vetter wrote: > > On Wed, Jan 26, 2022 at 9:31 AM Greg Kroah-Hartman > > wrote: ... > > On the other hand ... why does it have to be resurrecting fbdev? > > There's an entire community of people who really k

Re: [PATCH v1 1/4] fbtft: Unorphan the driver

2022-01-26 Thread Andy Shevchenko
On Wed, Jan 26, 2022 at 11:31:45AM +0100, Daniel Vetter wrote: > On Wed, Jan 26, 2022 at 9:31 AM Greg Kroah-Hartman > wrote: > > On Tue, Jan 25, 2022 at 10:21:14PM +0200, Andy Shevchenko wrote: ... > > I'm ok with the files moving if the dri developers agree with it. It's > > up to them, not me

Re: [PATCH v1 1/4] fbtft: Unorphan the driver

2022-01-26 Thread Thomas Zimmermann
Hi Am 26.01.22 um 12:17 schrieb Helge Deller: On 1/26/22 11:31, Daniel Vetter wrote: On Wed, Jan 26, 2022 at 9:31 AM Greg Kroah-Hartman wrote: On Tue, Jan 25, 2022 at 10:21:14PM +0200, Andy Shevchenko wrote: Let's maintain occasional fixes to the fbtft driver. Signed-off-by: Andy Shevchenk

Re: [PATCH v1 1/4] fbtft: Unorphan the driver

2022-01-26 Thread Daniel Vetter
On Wed, Jan 26, 2022 at 12:18 PM Helge Deller wrote: > > On 1/26/22 11:31, Daniel Vetter wrote: > > On Wed, Jan 26, 2022 at 9:31 AM Greg Kroah-Hartman > > wrote: > >> > >> On Tue, Jan 25, 2022 at 10:21:14PM +0200, Andy Shevchenko wrote: > >>> Let's maintain occasional fixes to the fbtft driver. >

Re: [PATCH v1 1/4] fbtft: Unorphan the driver

2022-01-26 Thread Greg Kroah-Hartman
On Wed, Jan 26, 2022 at 12:17:08PM +0100, Helge Deller wrote: > On 1/26/22 11:31, Daniel Vetter wrote: > > On Wed, Jan 26, 2022 at 9:31 AM Greg Kroah-Hartman > > wrote: > >> > >> On Tue, Jan 25, 2022 at 10:21:14PM +0200, Andy Shevchenko wrote: > >>> Let's maintain occasional fixes to the fbtft dri

Re: [PATCH v1 1/4] fbtft: Unorphan the driver

2022-01-26 Thread Helge Deller
On 1/26/22 11:31, Daniel Vetter wrote: > On Wed, Jan 26, 2022 at 9:31 AM Greg Kroah-Hartman > wrote: >> >> On Tue, Jan 25, 2022 at 10:21:14PM +0200, Andy Shevchenko wrote: >>> Let's maintain occasional fixes to the fbtft driver. >>> >>> Signed-off-by: Andy Shevchenko >>> --- >>> MAINTAINERS | 4

Re: [PATCH v1 1/4] fbtft: Unorphan the driver

2022-01-26 Thread Daniel Vetter
On Wed, Jan 26, 2022 at 9:31 AM Greg Kroah-Hartman wrote: > > On Tue, Jan 25, 2022 at 10:21:14PM +0200, Andy Shevchenko wrote: > > Let's maintain occasional fixes to the fbtft driver. > > > > Signed-off-by: Andy Shevchenko > > --- > > MAINTAINERS | 4 +++- > > 1 file changed, 3 insertions(+), 1

Re: [PATCH v1 1/4] fbtft: Unorphan the driver

2022-01-26 Thread Greg Kroah-Hartman
On Tue, Jan 25, 2022 at 10:21:14PM +0200, Andy Shevchenko wrote: > Let's maintain occasional fixes to the fbtft driver. > > Signed-off-by: Andy Shevchenko > --- > MAINTAINERS | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/MAINTAINERS b/MAINTAINERS > index ea3e6c9143

[PATCH v1 1/4] fbtft: Unorphan the driver

2022-01-25 Thread Andy Shevchenko
Let's maintain occasional fixes to the fbtft driver. Signed-off-by: Andy Shevchenko --- MAINTAINERS | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/MAINTAINERS b/MAINTAINERS index ea3e6c914384..16e614606ac1 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -7372,9 +7372,11 @@