Re: [PATCH v1 1/4] backlight: hx8357: Make use of device properties

2024-01-28 Thread Andy Shevchenko
On Wed, Jan 24, 2024 at 05:19:53PM +, Daniel Thompson wrote: > On Sun, Jan 14, 2024 at 05:25:08PM +0200, Andy Shevchenko wrote: ... > > +typedef int (*hx8357_init)(struct lcd_device *); > > + hx8357_init init; > > As somewhere else in this thread, I'd find this a lot more readable > as: >

Re: [PATCH v1 1/4] backlight: hx8357: Make use of device properties

2024-01-24 Thread Daniel Thompson
On Sun, Jan 14, 2024 at 05:25:08PM +0200, Andy Shevchenko wrote: > Convert the module to be property provider agnostic and allow > it to be used on non-OF platforms. > > Include mod_devicetable.h explicitly to replace the dropped of.h > which included mod_devicetable.h indirectly. > > Signed-off-by

Re: [PATCH v1 1/4] backlight: hx8357: Make use of device properties

2024-01-22 Thread Daniel Thompson
On Sun, Jan 21, 2024 at 03:48:05PM +0200, Andy Shevchenko wrote: > On Mon, Jan 15, 2024 at 09:20:46AM +0100, Javier Martinez Canillas wrote: > > Andy Shevchenko writes: > > ... > > > > +typedef int (*hx8357_init)(struct lcd_device *); > > > > This kind of typedef usage is frowned upon in the Linux

Re: [PATCH v1 1/4] backlight: hx8357: Make use of device properties

2024-01-21 Thread Andy Shevchenko
On Mon, Jan 15, 2024 at 09:20:46AM +0100, Javier Martinez Canillas wrote: > Andy Shevchenko writes: ... > > +typedef int (*hx8357_init)(struct lcd_device *); > > This kind of typedef usage is frowned upon in the Linux coding style [0] > (per my understanding at least) and indeed in my opinion i

Re: [PATCH v1 1/4] backlight: hx8357: Make use of device properties

2024-01-15 Thread Javier Martinez Canillas
Andy Shevchenko writes: Hello Andy, > Convert the module to be property provider agnostic and allow > it to be used on non-OF platforms. > > Include mod_devicetable.h explicitly to replace the dropped of.h > which included mod_devicetable.h indirectly. > > Signed-off-by: Andy Shevchenko > --- >

[PATCH v1 1/4] backlight: hx8357: Make use of device properties

2024-01-14 Thread Andy Shevchenko
Convert the module to be property provider agnostic and allow it to be used on non-OF platforms. Include mod_devicetable.h explicitly to replace the dropped of.h which included mod_devicetable.h indirectly. Signed-off-by: Andy Shevchenko --- drivers/video/backlight/hx8357.c | 14 --