Re: [PATCH v1 1/3] string: Consolidate yesno() helpers under string.h hood

2021-11-15 Thread Andy Shevchenko
On Mon, Nov 15, 2021 at 01:43:02PM +0200, Jani Nikula wrote: > On Mon, 15 Nov 2021, Andy Shevchenko > wrote: > > On Tue, Oct 05, 2021 at 02:34:23PM -0700, Lucas De Marchi wrote: > >> On Mon, Feb 15, 2021 at 04:21:35PM +0200, Andy Shevchenko wrote: > >> > We have already few similar implementation

Re: [PATCH v1 1/3] string: Consolidate yesno() helpers under string.h hood

2021-11-15 Thread Jani Nikula
On Mon, 15 Nov 2021, Andy Shevchenko wrote: > On Tue, Oct 05, 2021 at 02:34:23PM -0700, Lucas De Marchi wrote: >> On Mon, Feb 15, 2021 at 04:21:35PM +0200, Andy Shevchenko wrote: >> > We have already few similar implementation and a lot of code that can >> > benefit >> > of the yesno() helper. C

Re: [PATCH v1 1/3] string: Consolidate yesno() helpers under string.h hood

2021-11-15 Thread Andy Shevchenko
On Tue, Oct 05, 2021 at 02:34:23PM -0700, Lucas De Marchi wrote: > On Mon, Feb 15, 2021 at 04:21:35PM +0200, Andy Shevchenko wrote: > > We have already few similar implementation and a lot of code that can > > benefit > > of the yesno() helper. Consolidate yesno() helpers under string.h hood. >

Re: [PATCH v1 1/3] string: Consolidate yesno() helpers under string.h hood

2021-10-05 Thread Lucas De Marchi
On Mon, Feb 15, 2021 at 04:21:35PM +0200, Andy Shevchenko wrote: We have already few similar implementation and a lot of code that can benefit of the yesno() helper. Consolidate yesno() helpers under string.h hood. I was taking a look on i915_utils.h to reduce it and move some of it elsewhere

Re: [PATCH v1 1/3] string: Consolidate yesno() helpers under string.h hood

2021-02-17 Thread Jani Nikula
On Wed, 17 Feb 2021, Petr Mladek wrote: > On Mon 2021-02-15 16:39:26, Andy Shevchenko wrote: >> +Cc: Sakari and printk people >> >> On Mon, Feb 15, 2021 at 4:28 PM Christian König >> wrote: >> > Am 15.02.21 um 15:21 schrieb Andy Shevchenko: >> > > We have already few similar implementation and a

Re: [PATCH v1 1/3] string: Consolidate yesno() helpers under string.h hood

2021-02-17 Thread Petr Mladek
On Mon 2021-02-15 16:39:26, Andy Shevchenko wrote: > +Cc: Sakari and printk people > > On Mon, Feb 15, 2021 at 4:28 PM Christian König > wrote: > > Am 15.02.21 um 15:21 schrieb Andy Shevchenko: > > > We have already few similar implementation and a lot of code that can > > > benefit > > > of the

Re: [PATCH v1 1/3] string: Consolidate yesno() helpers under string.h hood

2021-02-15 Thread Andy Shevchenko
On Mon, Feb 15, 2021 at 04:37:50PM +0200, Jani Nikula wrote: > On Mon, 15 Feb 2021, Andy Shevchenko > wrote: > > We have already few similar implementation and a lot of code that can > > benefit > > of the yesno() helper. Consolidate yesno() helpers under string.h hood. > > Good luck. I gave u

Re: [PATCH v1 1/3] string: Consolidate yesno() helpers under string.h hood

2021-02-15 Thread Andy Shevchenko
+Cc: Sakari and printk people On Mon, Feb 15, 2021 at 4:28 PM Christian König wrote: > Am 15.02.21 um 15:21 schrieb Andy Shevchenko: > > We have already few similar implementation and a lot of code that can > > benefit > > of the yesno() helper. Consolidate yesno() helpers under string.h hood.

Re: [PATCH v1 1/3] string: Consolidate yesno() helpers under string.h hood

2021-02-15 Thread Jani Nikula
On Mon, 15 Feb 2021, Andy Shevchenko wrote: > We have already few similar implementation and a lot of code that can benefit > of the yesno() helper. Consolidate yesno() helpers under string.h hood. Good luck. I gave up after just four versions. [1] Acked-by: Jani Nikula BR, Jani. [1] http:

Re: [PATCH v1 1/3] string: Consolidate yesno() helpers under string.h hood

2021-02-15 Thread Christian König
Am 15.02.21 um 15:21 schrieb Andy Shevchenko: We have already few similar implementation and a lot of code that can benefit of the yesno() helper. Consolidate yesno() helpers under string.h hood. Signed-off-by: Andy Shevchenko Looks like a good idea to me, feel free to add an Acked-by: Chris

[PATCH v1 1/3] string: Consolidate yesno() helpers under string.h hood

2021-02-15 Thread Andy Shevchenko
We have already few similar implementation and a lot of code that can benefit of the yesno() helper. Consolidate yesno() helpers under string.h hood. Signed-off-by: Andy Shevchenko --- .../drm/amd/display/amdgpu_dm/amdgpu_dm_debugfs.c| 6 +- drivers/gpu/drm/i915/i915_utils.h