Re: [PATCH v1 1/2] fbtft: Rectify GPIO handling

2021-04-16 Thread Andy Shevchenko
On Fri, Apr 16, 2021 at 02:51:59PM +0200, Greg Kroah-Hartman wrote: > On Fri, Apr 16, 2021 at 03:31:16PM +0300, Andy Shevchenko wrote: > > The infamous commit c440eee1a7a1 ("Staging: fbtft: Switch to > > the GPIO descriptor interface") broke GPIO handling completely. > > It has already four commits

Re: [PATCH v1 1/2] fbtft: Rectify GPIO handling

2021-04-16 Thread Andy Shevchenko
On Fri, Apr 16, 2021 at 04:37:48PM +0300, Andy Shevchenko wrote: > On Fri, Apr 16, 2021 at 02:51:59PM +0200, Greg Kroah-Hartman wrote: > > On Fri, Apr 16, 2021 at 03:31:16PM +0300, Andy Shevchenko wrote: > > > The infamous commit c440eee1a7a1 ("Staging: fbtft: Switch to > > > the GPIO descriptor in

Re: [PATCH v1 1/2] fbtft: Rectify GPIO handling

2021-04-16 Thread Andy Shevchenko
On Fri, Apr 16, 2021 at 02:51:59PM +0200, Greg Kroah-Hartman wrote: > On Fri, Apr 16, 2021 at 03:31:16PM +0300, Andy Shevchenko wrote: > > The infamous commit c440eee1a7a1 ("Staging: fbtft: Switch to > > the GPIO descriptor interface") broke GPIO handling completely. > > It has already four commits

Re: [PATCH v1 1/2] fbtft: Rectify GPIO handling

2021-04-16 Thread Greg Kroah-Hartman
On Fri, Apr 16, 2021 at 03:31:16PM +0300, Andy Shevchenko wrote: > The infamous commit c440eee1a7a1 ("Staging: fbtft: Switch to > the GPIO descriptor interface") broke GPIO handling completely. > It has already four commits to rectify and it seems not enough. > In order to fix the mess here we: >

[PATCH v1 1/2] fbtft: Rectify GPIO handling

2021-04-16 Thread Andy Shevchenko
The infamous commit c440eee1a7a1 ("Staging: fbtft: Switch to the GPIO descriptor interface") broke GPIO handling completely. It has already four commits to rectify and it seems not enough. In order to fix the mess here we: 1) Set default to "inactive" for all requested pins 2) Fix CS, RD, and