Re: [PATCH v1 03/12] drm/mediatek: Drop chain_mode_fixup call in mode_valid()

2022-09-19 Thread Laurent Pinchart
Hi Sam, Thank you for the patch. On Sun, Jul 17, 2022 at 07:44:45PM +0200, Sam Ravnborg wrote: > The mode_valid implementation had a call to > drm_bridge_chain_mode_fixup() which would be wrong as the mode_valid is > not allowed to change anything - only to validate the mode. > > As the next bri

Re: [PATCH v1 03/12] drm/mediatek: Drop chain_mode_fixup call in mode_valid()

2022-09-17 Thread Chun-Kuang Hu
Hi, Sam: Sam Ravnborg 於 2022年7月18日 週一 凌晨1:45寫道: > > The mode_valid implementation had a call to > drm_bridge_chain_mode_fixup() which would be wrong as the mode_valid is > not allowed to change anything - only to validate the mode. > > As the next bridge is often/always a connector the call had n

[PATCH v1 03/12] drm/mediatek: Drop chain_mode_fixup call in mode_valid()

2022-07-17 Thread Sam Ravnborg
The mode_valid implementation had a call to drm_bridge_chain_mode_fixup() which would be wrong as the mode_valid is not allowed to change anything - only to validate the mode. As the next bridge is often/always a connector the call had no effect anyway. So drop it. >From the git history I could s