Re: [PATCH v1 01/12] fbdev: gxfb: use generic power management

2020-08-11 Thread Vaibhav Gupta
> > > -static int gxfb_suspend(struct pci_dev *pdev, pm_message_t state) > > > +static int __maybe_unused gxfb_suspend(struct device *dev) > > > { > > > - struct fb_info *info = pci_get_drvdata(pdev); > > > + struct fb_info *info = dev_get_drvdata(dev); > > I do not see any dev_set_drvdata() so I

Re: [PATCH v1 01/12] fbdev: gxfb: use generic power management

2020-08-11 Thread Vaibhav Gupta
On Mon, Aug 10, 2020 at 06:54:58PM +0200, Sam Ravnborg wrote: > Hi Vaibhav > On Mon, Aug 10, 2020 at 03:09:48PM +0530, Vaibhav Gupta wrote: > > On Sat, Aug 08, 2020 at 01:17:46PM +0200, Sam Ravnborg wrote: > > > Hi Vaibhav > > > > > > On Wed, Aug 05, 2020 at 11:37:11PM +0530, Vaibhav Gupta wrote:

Re: [PATCH v1 01/12] fbdev: gxfb: use generic power management

2020-08-11 Thread Vaibhav Gupta
On Sat, Aug 08, 2020 at 01:17:46PM +0200, Sam Ravnborg wrote: > Hi Vaibhav > > On Wed, Aug 05, 2020 at 11:37:11PM +0530, Vaibhav Gupta wrote: > > Drivers using legacy power management .suspen()/.resume() callbacks > > have to manage PCI states and device's PM states themselves. They also > > need

Re: [PATCH v1 01/12] fbdev: gxfb: use generic power management

2020-08-10 Thread Sam Ravnborg
Hi Vaibhav On Mon, Aug 10, 2020 at 03:09:48PM +0530, Vaibhav Gupta wrote: > On Sat, Aug 08, 2020 at 01:17:46PM +0200, Sam Ravnborg wrote: > > Hi Vaibhav > > > > On Wed, Aug 05, 2020 at 11:37:11PM +0530, Vaibhav Gupta wrote: > > > Drivers using legacy power management .suspen()/.resume() callbacks

Re: [PATCH v1 01/12] fbdev: gxfb: use generic power management

2020-08-08 Thread Sam Ravnborg
Hi Vaibhav On Wed, Aug 05, 2020 at 11:37:11PM +0530, Vaibhav Gupta wrote: > Drivers using legacy power management .suspen()/.resume() callbacks > have to manage PCI states and device's PM states themselves. They also > need to take care of standard configuration registers. > > Switch to generic p

Re: [PATCH v1 01/12] fbdev: gxfb: use generic power management

2020-08-06 Thread Vaibhav Gupta
On Wed, Aug 05, 2020 at 03:19:01PM -0500, Bjorn Helgaas wrote: > On Wed, Aug 05, 2020 at 11:37:11PM +0530, Vaibhav Gupta wrote: > > Drivers using legacy power management .suspen()/.resume() callbacks > > have to manage PCI states and device's PM states themselves. They also > > need to take care of

[PATCH v1 01/12] fbdev: gxfb: use generic power management

2020-08-06 Thread Vaibhav Gupta
Drivers using legacy power management .suspen()/.resume() callbacks have to manage PCI states and device's PM states themselves. They also need to take care of standard configuration registers. Switch to generic power management framework using a single "struct dev_pm_ops" variable to take the unn

Re: [PATCH v1 01/12] fbdev: gxfb: use generic power management

2020-08-05 Thread Bjorn Helgaas
On Wed, Aug 05, 2020 at 11:37:11PM +0530, Vaibhav Gupta wrote: > Drivers using legacy power management .suspen()/.resume() callbacks > have to manage PCI states and device's PM states themselves. They also > need to take care of standard configuration registers. s/using legacy/using legacy PCI/ s/