Re: [PATCH v1 0/2] drm: drop uapi dependencies from include/drm

2019-06-24 Thread Sam Ravnborg
Hi Daniel. > > drm_file.h: > > - needs drm_magic_t > > drm_magic_t is a simple typedef, a simple unsigned int would do the trick > > I think we could switch over to unsigned int for this. OK, will send a v2 with this addressed. There is some preparatory patches to fix build breakage when the i

Re: [Intel-gfx] [PATCH v1 0/2] drm: drop uapi dependencies from include/drm

2019-06-24 Thread Jani Nikula
On Mon, 24 Jun 2019, Emil Velikov wrote: > On Mon, 24 Jun 2019 at 09:21, Daniel Vetter wrote: > >> > drm_legacy.h >> > - needs drm_map_type and drm_map_flags. Seems legit. >> >> enum in uapi, sweet (never do this, it's not portable across compilers, >> #defines all the way). > > Don't look too cl

Re: [Intel-gfx] [PATCH v1 0/2] drm: drop uapi dependencies from include/drm

2019-06-24 Thread Emil Velikov
On Mon, 24 Jun 2019 at 09:21, Daniel Vetter wrote: > > drm_legacy.h > > - needs drm_map_type and drm_map_flags. Seems legit. > > enum in uapi, sweet (never do this, it's not portable across compilers, > #defines all the way). Don't look too closely then $ git grep enum -- include/uapi/drm/ | wc

Re: [PATCH v1 0/2] drm: drop uapi dependencies from include/drm

2019-06-24 Thread Daniel Vetter
On Sat, Jun 22, 2019 at 02:11:54PM +0200, Sam Ravnborg wrote: > include/drm/* shall have no or at least minimal dependencies > to include/uapi/drm/*. > Following two patches do a small effort to drop such dependencies. > > After these patches there are two users > of uapi/drm/drm.h left in include

[PATCH v1 0/2] drm: drop uapi dependencies from include/drm

2019-06-22 Thread Sam Ravnborg
include/drm/* shall have no or at least minimal dependencies to include/uapi/drm/*. Following two patches do a small effort to drop such dependencies. After these patches there are two users of uapi/drm/drm.h left in include/drm: drm_file.h: - needs drm_magic_t drm_magic_t is a simple typedef,