Re: [PATCH v1] drm/i915/guc: Always disable interrupt ahead of synchronize_irq

2025-02-04 Thread Andi Shyti
Hi, > > Please, next time, do not remove the mailing and the other folks > > you cc'ed. > > > > I'm adding back the mailing list and Daniele who has commented > > before. > > Thanks, I also found my previous response click on "reply", not the "reply > all". no worries, happens :-) > > > > > Cl

Re: [PATCH v1] drm/i915/guc: Always disable interrupt ahead of synchronize_irq

2025-02-03 Thread Dong, Zhanjun
On 2025-02-03 8:29 a.m., Andi Shyti wrote: Hi, Please, next time, do not remove the mailing and the other folks you cc'ed. I'm adding back the mailing list and Daniele who has commented before. Thanks, I also found my previous response click on "reply", not the "reply all". ... Clos

Fwd: [PATCH v1] drm/i915/guc: Always disable interrupt ahead of synchronize_irq

2025-02-03 Thread Dong, Zhanjun
Just found my previous response click on "reply", not the "reply all", so add Cc list. Regards, Zhanjun Dong Forwarded Message ---- Subject: Re: [PATCH v1] drm/i915/guc: Always disable interrupt ahead of synchronize_irq Date: Mon, 27 Jan 2025 17:17:33 -0500

Re: [PATCH v1] drm/i915/guc: Always disable interrupt ahead of synchronize_irq

2025-02-03 Thread Andi Shyti
Hi, Please, next time, do not remove the mailing and the other folks you cc'ed. I'm adding back the mailing list and Daniele who has commented before. ... > > > Closes: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/13454 > > > Fixes: 26705e20752a ("drm/i915: Support for GuC interrupts

Re: [PATCH v1] drm/i915/guc: Always disable interrupt ahead of synchronize_irq

2025-01-27 Thread Daniele Ceraolo Spurio
On 1/23/2025 8:23 AM, Zhanjun Dong wrote: The purpose of synchronize_irq is to wait for any pending IRQ handlers for the interrupt to complete, if synchronize_irq called before interrupt disabled, an tiny timing window created, where no more pending IRQ, but interrupt not disabled yet. Meanwh

Re: [PATCH v1] drm/i915/guc: Always disable interrupt ahead of synchronize_irq

2025-01-27 Thread Andi Shyti
Hi Zhanjun, On Thu, Jan 23, 2025 at 08:23:51AM -0800, Zhanjun Dong wrote: > The purpose of synchronize_irq is to wait for any pending IRQ handlers for the > interrupt to complete, if synchronize_irq called before interrupt disabled, an > tiny timing window created, where no more pending IRQ, but i

Re: [PATCH v1] drm/i915/guc: Always disable interrupt ahead of synchronize_irq

2025-01-27 Thread Sebastian Brzezinka
Hi Zhanjun There is a missing newline at drm-tip/drivers/gpu/drm/i915/gt/intel_rps.c:249 Overall, LGTM. On Thu Jan 23, 2025 at 4:23 PM UTC, Zhanjun Dong wrote: > The purpose of synchronize_irq is to wait for any pending IRQ handlers for the > interrupt to complete, if synchronize_irq called befor

[PATCH v1] drm/i915/guc: Always disable interrupt ahead of synchronize_irq

2025-01-23 Thread Zhanjun Dong
The purpose of synchronize_irq is to wait for any pending IRQ handlers for the interrupt to complete, if synchronize_irq called before interrupt disabled, an tiny timing window created, where no more pending IRQ, but interrupt not disabled yet. Meanwhile, if the interrupt event happened in this tim