Re: [PATCH next] drm/st7571-i2c: Fix IS_ERR() vs NULL checks in probe()

Javier Martinez Canillas writes: > Dan Carpenter writes: > > Hello Dan, > >> The devm_kzalloc() function returns NULL on failure, not error pointers. >> Also printing an error message for kmalloc() failures is against kernel >> style so just return -ENOMEM without printing a message. (Kmalloc >

Re: [PATCH next] drm/st7571-i2c: Fix IS_ERR() vs NULL checks in probe()

Dan Carpenter writes: Hello Dan, > The devm_kzalloc() function returns NULL on failure, not error pointers. > Also printing an error message for kmalloc() failures is against kernel > style so just return -ENOMEM without printing a message. (Kmalloc > already prints a message). > > Fixes: 4b35f

[PATCH next] drm/st7571-i2c: Fix IS_ERR() vs NULL checks in probe()

The devm_kzalloc() function returns NULL on failure, not error pointers. Also printing an error message for kmalloc() failures is against kernel style so just return -ENOMEM without printing a message. (Kmalloc already prints a message). Fixes: 4b35f0f41ee2 ("drm/st7571-i2c: add support for Sitro