Re: [PATCH net-next v9 11/14] tcp: RX path for devmem TCP

2024-05-29 Thread Mina Almasry
On Tue, May 28, 2024 at 7:42 PM Pavel Begunkov wrote: > > On 5/28/24 18:36, Mina Almasry wrote: > > On Wed, May 22, 2024 at 11:02 PM David Wei wrote: > ... > >>> + */ > >>> + if (!skb_frag_net_iov(frag)) { > >>> + net_err_rateli

Re: [PATCH net-next v9 11/14] tcp: RX path for devmem TCP

2024-05-28 Thread Pavel Begunkov
On 5/28/24 18:36, Mina Almasry wrote: On Wed, May 22, 2024 at 11:02 PM David Wei wrote: ... + */ + if (!skb_frag_net_iov(frag)) { + net_err_ratelimited("Found non-dmabuf skb with net_iov"); + err

Re: [PATCH net-next v9 11/14] tcp: RX path for devmem TCP

2024-05-28 Thread Mina Almasry
On Wed, May 22, 2024 at 11:02 PM David Wei wrote: > > On 2024-05-10 16:21, Mina Almasry wrote: > > +/* On error, returns the -errno. On success, returns number of bytes sent > > to the > > + * user. May not consume all of @remaining_len. > > + */ > > +static int tcp_recvmsg_dmabuf(struct sock *sk

Re: [PATCH net-next v9 11/14] tcp: RX path for devmem TCP

2024-05-22 Thread David Wei
On 2024-05-10 16:21, Mina Almasry wrote: > +/* On error, returns the -errno. On success, returns number of bytes sent to > the > + * user. May not consume all of @remaining_len. > + */ > +static int tcp_recvmsg_dmabuf(struct sock *sk, const struct sk_buff *skb, > + unsign

[PATCH net-next v9 11/14] tcp: RX path for devmem TCP

2024-05-10 Thread Mina Almasry
In tcp_recvmsg_locked(), detect if the skb being received by the user is a devmem skb. In this case - if the user provided the MSG_SOCK_DEVMEM flag - pass it to tcp_recvmsg_devmem() for custom handling. tcp_recvmsg_devmem() copies any data in the skb header to the linear buffer, and returns a cmsg