Re: [PATCH net-next v4 2/6] dt-bindings: net: Brcm ASP 2.0 Ethernet controller

2023-05-24 Thread Conor Dooley
On Wed, May 24, 2023 at 02:47:59PM -0700, Justin Chen wrote: > On Tue, May 23, 2023 at 11:56 PM Conor Dooley > wrote: > Gotcha. I got something like this now. > > compatible: > oneOf: > - items: > - enum: > - brcm,bcm74165-asp > - const: brcm,asp-v2

Re: [PATCH net-next v4 2/6] dt-bindings: net: Brcm ASP 2.0 Ethernet controller

2023-05-24 Thread Justin Chen
On Tue, May 23, 2023 at 11:56 PM Conor Dooley wrote: > > On Wed, May 24, 2023 at 07:51:07AM +0100, Conor Dooley wrote: > > Hey Justin, > > On Tue, May 23, 2023 at 04:27:12PM -0700, Justin Chen wrote: > > > On Tue, May 23, 2023 at 3:55 PM Conor Dooley wrote: > > > > On Tue, May 23, 2023 at 02:53:4

Re: [PATCH net-next v4 2/6] dt-bindings: net: Brcm ASP 2.0 Ethernet controller

2023-05-24 Thread Conor Dooley
On Wed, May 24, 2023 at 07:51:07AM +0100, Conor Dooley wrote: > Hey Justin, > On Tue, May 23, 2023 at 04:27:12PM -0700, Justin Chen wrote: > > On Tue, May 23, 2023 at 3:55 PM Conor Dooley wrote: > > > On Tue, May 23, 2023 at 02:53:43PM -0700, Justin Chen wrote: > > > > > > > + compatible: > > > >

Re: [PATCH net-next v4 2/6] dt-bindings: net: Brcm ASP 2.0 Ethernet controller

2023-05-23 Thread Conor Dooley
Hey Justin, On Tue, May 23, 2023 at 04:27:12PM -0700, Justin Chen wrote: > On Tue, May 23, 2023 at 3:55 PM Conor Dooley wrote: > > On Tue, May 23, 2023 at 02:53:43PM -0700, Justin Chen wrote: > > > > > + compatible: > > > +enum: > > > + - brcm,asp-v2.0 > > > + - brcm,bcm72165-asp >

Re: [PATCH net-next v4 2/6] dt-bindings: net: Brcm ASP 2.0 Ethernet controller

2023-05-23 Thread Justin Chen
On Tue, May 23, 2023 at 3:55 PM Conor Dooley wrote: > > Hey Justin, > > On Tue, May 23, 2023 at 02:53:43PM -0700, Justin Chen wrote: > > > + compatible: > > +enum: > > + - brcm,asp-v2.0 > > + - brcm,bcm72165-asp > > + - brcm,asp-v2.1 > > + - brcm,bcm74165-asp > > > +

Re: [PATCH net-next v4 2/6] dt-bindings: net: Brcm ASP 2.0 Ethernet controller

2023-05-23 Thread Conor Dooley
Hey Justin, On Tue, May 23, 2023 at 02:53:43PM -0700, Justin Chen wrote: > + compatible: > +enum: > + - brcm,asp-v2.0 > + - brcm,bcm72165-asp > + - brcm,asp-v2.1 > + - brcm,bcm74165-asp > +compatible = "brcm,bcm72165-asp", "brcm,asp-v2.0"; You can't do this, as

Re: [PATCH net-next v4 2/6] dt-bindings: net: Brcm ASP 2.0 Ethernet controller

2023-05-23 Thread Rob Herring
On Tue, 23 May 2023 14:53:43 -0700, Justin Chen wrote: > From: Florian Fainelli > > Add a binding document for the Broadcom ASP 2.0 Ethernet > controller. > > Signed-off-by: Florian Fainelli > Signed-off-by: Justin Chen > --- > v3 > - Adjust compatible string example to reference SoC a

[PATCH net-next v4 2/6] dt-bindings: net: Brcm ASP 2.0 Ethernet controller

2023-05-23 Thread Justin Chen
From: Florian Fainelli Add a binding document for the Broadcom ASP 2.0 Ethernet controller. Signed-off-by: Florian Fainelli Signed-off-by: Justin Chen --- v3 - Adjust compatible string example to reference SoC and HW ver v3 - Minor formatting issues - Change channel pr