ThispatchisReviewed-by:JamesZhu
On 2022-08-15 3:00 a.m., Khalid Masum wrote:
The value assigned from vcn_v4_0_stop_dbg_mode to r is overwritten
before it can be used. Remove this assignment.
Addresses-Coverity: 1504988 ("Unused value")
Fixes: 8da1170a16e4 ("drm/amdgpu: add VCN4 ip block support
On 8/15/22 22:00, Dong, Ruijing wrote:
[AMD Official Use Only - General]
Then please update commit message, this change is due to "value r is never used, and
remove unnecessary assignment", that makes sense to me.
Thanks
Ruijing
Greg also pointed out that the function vcn_v4_0_stop_dpg_mode s
; Daniel Vetter ; Zhu, James ;
Jiang, Sonny ; Dong, Ruijing ; Wan Jiabing ; Liu, Leo
; Khalid Masum
Subject: [PATCH linux-next] drm/amdgpu/vcn: Remove unused assignment in
vcn_v4_0_stop
The value assigned from vcn_v4_0_stop_dbg_mode to r is overwritten before it
can be used. Remove this assignm
t...@lists.linuxfoundation.org
> > Cc: Deucher, Alexander ; Koenig, Christian
> > ; Pan, Xinhui ; David Airlie
> > ; Daniel Vetter ; Zhu, James
> > ; Jiang, Sonny ; Dong, Ruijing
> > ; Wan Jiabing ; Liu, Leo
> > ; Khalid Masum
> > Subject: [PATCH linux-next]
o
Subject: Re: [PATCH linux-next] drm/amdgpu/vcn: Remove unused assignment in
vcn_v4_0_stop
On 8/15/22 21:17, Dong, Ruijing wrote:
> [AMD Official Use Only - General]
>
> If the condition was met and it came to execute vcn_4_0_stop_dpg_mode, then
> it would never have a chance to go f
On 8/15/22 21:17, Dong, Ruijing wrote:
[AMD Official Use Only - General]
If the condition was met and it came to execute vcn_4_0_stop_dpg_mode, then it
would never have a chance to go for /*wait for vcn idle*/, isn't it?
Hypothetically, some other thread might set adev->pg_flags NULL and in
lie
; Daniel Vetter ; Zhu, James
; Jiang, Sonny ; Wan Jiabing
; Liu, Leo
Subject: Re: [PATCH linux-next] drm/amdgpu/vcn: Remove unused assignment in
vcn_v4_0_stop
On 8/15/22 20:15, Dong, Ruijing wrote:
> [AMD Official Use Only - General]
>
> Sorry, which "r" value was overwri
Masum
Subject: [PATCH linux-next] drm/amdgpu/vcn: Remove unused assignment in
vcn_v4_0_stop
The value assigned from vcn_v4_0_stop_dbg_mode to r is overwritten before it
can be used. Remove this assignment.
Addresses-Coverity: 1504988 ("Unused value")
Fixes: 8da1170a16e4 ("drm/amd
freedesktop.org;
linux-ker...@vger.kernel.org; linux-kernel-ment...@lists.linuxfoundation.org
Cc: Deucher, Alexander ; Koenig, Christian
; Pan, Xinhui ; David Airlie
; Daniel Vetter ; Zhu, James
; Jiang, Sonny ; Dong, Ruijing
; Wan Jiabing ; Liu, Leo
; Khalid Masum
Subject: [PATCH linux-next]
The value assigned from vcn_v4_0_stop_dbg_mode to r is overwritten
before it can be used. Remove this assignment.
Addresses-Coverity: 1504988 ("Unused value")
Fixes: 8da1170a16e4 ("drm/amdgpu: add VCN4 ip block support")
Signed-off-by: Khalid Masum
---
drivers/gpu/drm/amd/amdgpu/vcn_v4_0.c | 2 +
10 matches
Mail list logo
