Re: [PATCH linux-next] backlight: use sysfs_emit() to instead of scnprintf()

2023-01-04 Thread Lee Jones
On Mon, 05 Dec 2022, ye.xingc...@zte.com.cn wrote: > From: ye xingchen > > Follow the advice of the Documentation/filesystems/sysfs.rst and show() > should only use sysfs_emit() or sysfs_emit_at() when formatting the > value to be returned to user space. > > Signed-off-by: ye xingchen > --- >

Re: [PATCH linux-next] backlight: use sysfs_emit() to instead of scnprintf()

2022-12-09 Thread Daniel Thompson
On Mon, Dec 05, 2022 at 03:56:47PM +0800, ye.xingc...@zte.com.cn wrote: > Subject: [PATCH linux-next] backlight: use sysfs_emit() to instead of > scnprintf() Isn't this a v2? (this isn't just a "nice to have"... I ended up delaying review for several days until I had t

[PATCH linux-next] backlight: use sysfs_emit() to instead of scnprintf()

2022-12-04 Thread ye.xingchen
From: ye xingchen Follow the advice of the Documentation/filesystems/sysfs.rst and show() should only use sysfs_emit() or sysfs_emit_at() when formatting the value to be returned to user space. Signed-off-by: ye xingchen --- drivers/video/backlight/lm3533_bl.c | 10 +- drivers/video/ba

Re: [PATCH linux-next] backlight: use sysfs_emit() to instead of scnprintf()

2022-09-26 Thread Daniel Thompson
On Fri, Sep 23, 2022 at 06:34:48AM +, cgel@gmail.com wrote: > Subject: [PATCH linux-next] backlight: use sysfs_emit() to instead of > scnprintf() > From: ye xingchen > > Replace the open-code with sysfs_emit() to simplify the code. > > Signed-off-by: ye xingchen &

Re: [PATCH linux-next] backlight: use sysfs_emit() to instead of scnprintf()

2022-09-23 Thread Han Jingoo
On Thu, Sep 22, 2022 wrote: > > From: ye xingchen > > Replace the open-code with sysfs_emit() to simplify the code. > > Signed-off-by: ye xingchen Acked-by: Jingoo Han Best regards, Jingoo Han > --- > drivers/video/backlight/lm3533_bl.c | 10 +- > 1 file changed, 5 insertions(+), 5

[PATCH linux-next] backlight: use sysfs_emit() to instead of scnprintf()

2022-09-22 Thread cgel . zte
From: ye xingchen Replace the open-code with sysfs_emit() to simplify the code. Signed-off-by: ye xingchen --- drivers/video/backlight/lm3533_bl.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/video/backlight/lm3533_bl.c b/drivers/video/backlight/lm353