Re: [PATCH libdrm 1/4] intel: add IS_GENX() generic macro

2018-08-28 Thread Lucas De Marchi
On Tue, Aug 28, 2018 at 09:38:59AM +0100, Chris Wilson wrote: > Quoting Lucas De Marchi (2018-08-28 02:00:27) > > On Sat, Aug 25, 2018 at 10:35:23AM +0100, Chris Wilson wrote: > > > Quoting Lucas De Marchi (2018-08-25 00:56:46) > > > > diff --git a/intel/intel_chipset.h b/intel/intel_chipset.h > >

Re: [PATCH libdrm 1/4] intel: add IS_GENX() generic macro

2018-08-28 Thread Chris Wilson
Quoting Lucas De Marchi (2018-08-28 02:00:27) > On Sat, Aug 25, 2018 at 10:35:23AM +0100, Chris Wilson wrote: > > Quoting Lucas De Marchi (2018-08-25 00:56:46) > > > diff --git a/intel/intel_chipset.h b/intel/intel_chipset.h > > > index 4a34b7be..8a0e3e76 100644 > > > --- a/intel/intel_chipset.h >

Re: [PATCH libdrm 1/4] intel: add IS_GENX() generic macro

2018-08-27 Thread Lucas De Marchi
On Sat, Aug 25, 2018 at 10:35:23AM +0100, Chris Wilson wrote: > Quoting Lucas De Marchi (2018-08-25 00:56:46) > > diff --git a/intel/intel_chipset.h b/intel/intel_chipset.h > > index 4a34b7be..8a0e3e76 100644 > > --- a/intel/intel_chipset.h > > +++ b/intel/intel_chipset.h > > @@ -568,6 +568,26 @@ >

Re: [PATCH libdrm 1/4] intel: add IS_GENX() generic macro

2018-08-27 Thread Lucas De Marchi
On Mon, Aug 27, 2018 at 10:40:28PM +0100, Chris Wilson wrote: > Quoting Lucas De Marchi (2018-08-27 22:19:54) > > On Sat, Aug 25, 2018 at 10:35:23AM +0100, Chris Wilson wrote: > > > Quoting Lucas De Marchi (2018-08-25 00:56:46) > > > That should help cut down the object size expansion. But longer t

Re: [PATCH libdrm 1/4] intel: add IS_GENX() generic macro

2018-08-27 Thread Chris Wilson
Quoting Lucas De Marchi (2018-08-27 22:19:54) > On Sat, Aug 25, 2018 at 10:35:23AM +0100, Chris Wilson wrote: > > Quoting Lucas De Marchi (2018-08-25 00:56:46) > > That should help cut down the object size expansion. But longer term I'd > > I'm not opposed to turning it into inline function, but i

Re: [PATCH libdrm 1/4] intel: add IS_GENX() generic macro

2018-08-27 Thread Lucas De Marchi
On Sat, Aug 25, 2018 at 10:35:23AM +0100, Chris Wilson wrote: > Quoting Lucas De Marchi (2018-08-25 00:56:46) > > diff --git a/intel/intel_chipset.h b/intel/intel_chipset.h > > index 4a34b7be..8a0e3e76 100644 > > --- a/intel/intel_chipset.h > > +++ b/intel/intel_chipset.h > > @@ -568,6 +568,26 @@ >

Re: [PATCH libdrm 1/4] intel: add IS_GENX() generic macro

2018-08-25 Thread Chris Wilson
Quoting Lucas De Marchi (2018-08-25 00:56:46) > diff --git a/intel/intel_chipset.h b/intel/intel_chipset.h > index 4a34b7be..8a0e3e76 100644 > --- a/intel/intel_chipset.h > +++ b/intel/intel_chipset.h > @@ -568,6 +568,26 @@ > > #define IS_GEN11(devid)(IS_ICELAKE_11(devid)) > >

[PATCH libdrm 1/4] intel: add IS_GENX() generic macro

2018-08-24 Thread Lucas De Marchi
This will allow platforms to reuse kernel IDs instead of manually keeping them in sync. In most of the cases we only need to extend IS_9XX(). Current platforms that fit this requirement can be ported over to use this macro. The i915_pciids.h header is in sync with kernel tree on drm-tip 2018y-08m