[PATCH libdrm] meson: do not use cairo/valgrind if disabled

2018-02-19 Thread Igor Gnatenko
-Dcairo-tests=false currently results into enabling cairo support if it was found. Same for valgrind. v2: * Use underscore-prefixed variables to not change type of variable * Use empty array for "fake" dependency instead of real empty object v3: * Fix typo Reviewed-by: Eric Engestrom Signed-off

Re: [PATCH libdrm] meson: do not use cairo/valgrind if disabled

2018-02-19 Thread Igor Gnatenko
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 On Mon, 2018-02-19 at 12:15 +, Eric Engestrom wrote: > On Sunday, 2018-02-18 14:00:50 +0100, Igor Gnatenko wrote: > > -Dcairo-tests=false currently results into enabling cairo support if it > > was found. Same for valgrind. > > Indeed, this was

[PATCH libdrm] meson: do not use cairo/valgrind if disabled

2018-02-19 Thread Igor Gnatenko
-Dcairo-tests=false currently results into enabling cairo support if it was found. Same for valgrind. v2: * Use underscore-prefixed variables to not change type of variable * Use empty array for "fake" dependency instead of real empty object Signed-off-by: Igor Gnatenko --- meson.build | 24 +++

Re: [PATCH libdrm] meson: do not use cairo/valgrind if disabled

2018-02-19 Thread Eric Engestrom
On Sunday, 2018-02-18 14:00:50 +0100, Igor Gnatenko wrote: > -Dcairo-tests=false currently results into enabling cairo support if it > was found. Same for valgrind. Indeed, this was wrong; thanks for the fix! Reviewed-by: Eric Engestrom Do you have commit access, or do you want me to push this f

[PATCH libdrm] meson: do not use cairo/valgrind if disabled

2018-02-18 Thread Igor Gnatenko
-Dcairo-tests=false currently results into enabling cairo support if it was found. Same for valgrind. Signed-off-by: Igor Gnatenko --- meson.build | 20 1 file changed, 16 insertions(+), 4 deletions(-) diff --git a/meson.build b/meson.build index 166559e8..695f89b3 100644 -