Re: [PATCH libdrm] libdrm_amdgpu: add kernel semaphore support

2017-09-04 Thread Dave Airlie
On 5 September 2017 at 05:23, Marek Olšák wrote: > On Fri, Sep 1, 2017 at 5:36 PM, Marek Olšák wrote: >> On Thu, Jul 6, 2017 at 3:17 AM, Dave Airlie wrote: >>> From: Dave Airlie >>> >>> This adds kernel semaphore support to the command submission >>> interface in what should be a backwards comp

Re: [PATCH libdrm] libdrm_amdgpu: add kernel semaphore support

2017-09-04 Thread Dave Airlie
On 2 September 2017 at 01:36, Marek Olšák wrote: > On Thu, Jul 6, 2017 at 3:17 AM, Dave Airlie wrote: >> From: Dave Airlie >> >> This adds kernel semaphore support to the command submission >> interface in what should be a backwards compatible manner, >> it adds a new command submission API. >>

Re: [PATCH libdrm] libdrm_amdgpu: add kernel semaphore support

2017-09-04 Thread Marek Olšák
On Fri, Sep 1, 2017 at 5:36 PM, Marek Olšák wrote: > On Thu, Jul 6, 2017 at 3:17 AM, Dave Airlie wrote: >> From: Dave Airlie >> >> This adds kernel semaphore support to the command submission >> interface in what should be a backwards compatible manner, >> it adds a new command submission API. >

Re: [PATCH libdrm] libdrm_amdgpu: add kernel semaphore support

2017-09-01 Thread Marek Olšák
On Thu, Jul 6, 2017 at 3:17 AM, Dave Airlie wrote: > From: Dave Airlie > > This adds kernel semaphore support to the command submission > interface in what should be a backwards compatible manner, > it adds a new command submission API. > > Signed-off-by: Dave Airlie > --- > amdgpu/amdgpu.h

Re: [PATCH libdrm] libdrm_amdgpu: add kernel semaphore support

2017-07-19 Thread Michel Dänzer
On 18/07/17 09:55 PM, zhoucm1 wrote: On 2017年07月18日 21:57, Christian König wrote: Am 18.07.2017 um 04:29 schrieb zhoucm1: On 2017年07月18日 01:35, Christian König wrote: Am 17.07.2017 um 19:22 schrieb Marek Olšák: On Sun, Jul 16, 2017 at 11:36 PM, Dave Airlie wrote: I can take a look at it, I j

Re: [PATCH libdrm] libdrm_amdgpu: add kernel semaphore support

2017-07-18 Thread zhoucm1
On 2017年07月18日 21:57, Christian König wrote: Am 18.07.2017 um 04:29 schrieb zhoucm1: On 2017年07月18日 01:35, Christian König wrote: Am 17.07.2017 um 19:22 schrieb Marek Olšák: On Sun, Jul 16, 2017 at 11:36 PM, Dave Airlie wrote: I can take a look at it, I just won't have time until next wee

Re: [PATCH libdrm] libdrm_amdgpu: add kernel semaphore support

2017-07-18 Thread Marek Olšák
Hi Dave, If you just add "get" functions for what you need from amdgpu objects, that should be fine. Marek On Mon, Jul 17, 2017 at 11:00 PM, Dave Airlie wrote: > On 18 July 2017 at 03:02, Christian König wrote: >> Am 17.07.2017 um 05:36 schrieb Dave Airlie: I can take a look at it, I

Re: [PATCH libdrm] libdrm_amdgpu: add kernel semaphore support

2017-07-18 Thread Christian König
Am 18.07.2017 um 04:29 schrieb zhoucm1: On 2017年07月18日 01:35, Christian König wrote: Am 17.07.2017 um 19:22 schrieb Marek Olšák: On Sun, Jul 16, 2017 at 11:36 PM, Dave Airlie wrote: I can take a look at it, I just won't have time until next week most likely. I've taken a look, and it's see

Re: [PATCH libdrm] libdrm_amdgpu: add kernel semaphore support

2017-07-17 Thread zhoucm1
On 2017年07月18日 01:35, Christian König wrote: Am 17.07.2017 um 19:22 schrieb Marek Olšák: On Sun, Jul 16, 2017 at 11:36 PM, Dave Airlie wrote: I can take a look at it, I just won't have time until next week most likely. I've taken a look, and it's seemingly more complicated than I'm expectin

Re: [PATCH libdrm] libdrm_amdgpu: add kernel semaphore support

2017-07-17 Thread Dave Airlie
On 18 July 2017 at 03:02, Christian König wrote: > Am 17.07.2017 um 05:36 schrieb Dave Airlie: >>> >>> I can take a look at it, I just won't have time until next week most >>> likely. >> >> I've taken a look, and it's seemingly more complicated than I'm >> expecting I'd want to land in Mesa before

Re: [PATCH libdrm] libdrm_amdgpu: add kernel semaphore support

2017-07-17 Thread Christian König
Am 17.07.2017 um 19:22 schrieb Marek Olšák: On Sun, Jul 16, 2017 at 11:36 PM, Dave Airlie wrote: I can take a look at it, I just won't have time until next week most likely. I've taken a look, and it's seemingly more complicated than I'm expecting I'd want to land in Mesa before 17.2 ships, I'

Re: [PATCH libdrm] libdrm_amdgpu: add kernel semaphore support

2017-07-17 Thread Marek Olšák
On Sun, Jul 16, 2017 at 11:36 PM, Dave Airlie wrote: >> >> I can take a look at it, I just won't have time until next week most likely. > > I've taken a look, and it's seemingly more complicated than I'm > expecting I'd want to land in Mesa before 17.2 ships, I'd really > prefer to just push the n

Re: [PATCH libdrm] libdrm_amdgpu: add kernel semaphore support

2017-07-17 Thread Christian König
Am 17.07.2017 um 05:36 schrieb Dave Airlie: I can take a look at it, I just won't have time until next week most likely. I've taken a look, and it's seemingly more complicated than I'm expecting I'd want to land in Mesa before 17.2 ships, I'd really prefer to just push the new libdrm_amdgpu api

Re: [PATCH libdrm] libdrm_amdgpu: add kernel semaphore support

2017-07-16 Thread Dave Airlie
> > I can take a look at it, I just won't have time until next week most likely. I've taken a look, and it's seemingly more complicated than I'm expecting I'd want to land in Mesa before 17.2 ships, I'd really prefer to just push the new libdrm_amdgpu api from this patch. If I have to port all the

Re: [PATCH libdrm] libdrm_amdgpu: add kernel semaphore support

2017-07-12 Thread Dave Airlie
On 12 July 2017 at 03:47, Marek Olšák wrote: > On Tue, Jul 11, 2017 at 11:20 AM, Dave Airlie wrote: >> On 11 July 2017 at 18:36, Christian König wrote: >>> Am 11.07.2017 um 08:49 schrieb Dave Airlie: On 7 July 2017 at 19:07, Christian König wrote: > > Hi Dave, > > on f

Re: [PATCH libdrm] libdrm_amdgpu: add kernel semaphore support

2017-07-12 Thread Dave Airlie
On 11 July 2017 at 19:32, Christian König wrote: > Am 11.07.2017 um 11:20 schrieb Dave Airlie: >> >> On 11 July 2017 at 18:36, Christian König wrote: >>> >>> Am 11.07.2017 um 08:49 schrieb Dave Airlie: On 7 July 2017 at 19:07, Christian König wrote: > > Hi Dave, >

Re: [PATCH libdrm] libdrm_amdgpu: add kernel semaphore support

2017-07-11 Thread Marek Olšák
On Tue, Jul 11, 2017 at 11:20 AM, Dave Airlie wrote: > On 11 July 2017 at 18:36, Christian König wrote: >> Am 11.07.2017 um 08:49 schrieb Dave Airlie: >>> >>> On 7 July 2017 at 19:07, Christian König wrote: Hi Dave, on first glance that looks rather good to me, but there is o

Re: [PATCH libdrm] libdrm_amdgpu: add kernel semaphore support

2017-07-11 Thread Christian König
Am 11.07.2017 um 11:20 schrieb Dave Airlie: On 11 July 2017 at 18:36, Christian König wrote: Am 11.07.2017 um 08:49 schrieb Dave Airlie: On 7 July 2017 at 19:07, Christian König wrote: Hi Dave, on first glance that looks rather good to me, but there is one things I don't really like and I s

Re: [PATCH libdrm] libdrm_amdgpu: add kernel semaphore support

2017-07-11 Thread Dave Airlie
On 11 July 2017 at 18:36, Christian König wrote: > Am 11.07.2017 um 08:49 schrieb Dave Airlie: >> >> On 7 July 2017 at 19:07, Christian König wrote: >>> >>> Hi Dave, >>> >>> on first glance that looks rather good to me, but there is one things I >>> don't really like and I strongly think Marek wi

Re: [PATCH libdrm] libdrm_amdgpu: add kernel semaphore support

2017-07-11 Thread Christian König
Am 11.07.2017 um 08:49 schrieb Dave Airlie: On 7 July 2017 at 19:07, Christian König wrote: Hi Dave, on first glance that looks rather good to me, but there is one things I don't really like and I strongly think Marek will absolutely agree on that: When we add a new CS function then let's get

Re: [PATCH libdrm] libdrm_amdgpu: add kernel semaphore support

2017-07-10 Thread Dave Airlie
On 7 July 2017 at 19:07, Christian König wrote: > Hi Dave, > > on first glance that looks rather good to me, but there is one things I > don't really like and I strongly think Marek will absolutely agree on that: > When we add a new CS function then let's get ride of all this abstraction! > > The

Re: [PATCH libdrm] libdrm_amdgpu: add kernel semaphore support

2017-07-07 Thread Christian König
Hi Dave, on first glance that looks rather good to me, but there is one things I don't really like and I strongly think Marek will absolutely agree on that: When we add a new CS function then let's get ride of all this abstraction! The new function should get an amdgpu_device_handle and a li

Re: [PATCH libdrm] libdrm_amdgpu: add kernel semaphore support

2017-07-06 Thread Dave Airlie
Chrstian, you are probably the best person to ack this, I'd like to get the radv code landed and allow the GL code to get going. Dave. > This adds kernel semaphore support to the command submission > interface in what should be a backwards compatible manner, > it adds a new command submission AP

[PATCH libdrm] libdrm_amdgpu: add kernel semaphore support

2017-07-05 Thread Dave Airlie
From: Dave Airlie This adds kernel semaphore support to the command submission interface in what should be a backwards compatible manner, it adds a new command submission API. Signed-off-by: Dave Airlie --- amdgpu/amdgpu.h| 29 - amdgpu/amdgpu_cs.c | 118 ++