Re: [PATCH libdrm] intel: annotate the intel genx helpers as private

2018-09-21 Thread Chih-Wei Huang
2018-09-20 7:18 GMT+08:00 Lucas De Marchi : > On Wed, Sep 19, 2018 at 03:47:48PM +0800, Chih-Wei Huang wrote: >> 2018-09-14 2:23 GMT+08:00 Lucas De Marchi : >> > +Chris >> >> >> >> That's because drm_gralloc use the IS_GEN9 macro >> >> (and other IS_GEN{n} macros) directly. >> >> >> >> Since IS_GEN

Re: [PATCH libdrm] intel: annotate the intel genx helpers as private

2018-09-19 Thread Lucas De Marchi
On Wed, Sep 19, 2018 at 03:47:48PM +0800, Chih-Wei Huang wrote: > 2018-09-14 2:23 GMT+08:00 Lucas De Marchi : > > +Chris > >> > >> That's because drm_gralloc use the IS_GEN9 macro > >> (and other IS_GEN{n} macros) directly. > >> > >> Since IS_GEN{n} are public APIs, I don't see > > > > > > IS_GEN()

Re: [PATCH libdrm] intel: annotate the intel genx helpers as private

2018-09-19 Thread Chih-Wei Huang
2018-09-14 2:23 GMT+08:00 Lucas De Marchi : > +Chris >> >> That's because drm_gralloc use the IS_GEN9 macro >> (and other IS_GEN{n} macros) directly. >> >> Since IS_GEN{n} are public APIs, I don't see > > > IS_GEN() is *not* public API and should not be. It's an internal macro. > > DESTDIR=/tmp/ins

Re: [PATCH libdrm] intel: annotate the intel genx helpers as private

2018-09-13 Thread Chris Wilson
Quoting Lucas De Marchi (2018-09-13 19:23:49) > +Chris > > On 9/13/18 12:19 AM, Chih-Wei Huang wrote: > > Note this patch breaks drm_gralloc: > > > > FAILED: > > out/target/product/x86_64/obj_x86/SHARED_LIBRARIES/libgralloc_drm_intermediates/LINKED/libgralloc_drm.so > > /bin/bash -c "prebuilts/c

Re: [PATCH libdrm] intel: annotate the intel genx helpers as private

2018-09-13 Thread Eric Engestrom
On Thursday, 2018-09-13 10:43:04 -0700, Rodrigo Vivi wrote: > On Thu, Sep 13, 2018 at 09:45:47AM +0100, Eric Engestrom wrote: > > On Thursday, 2018-09-13 15:19:00 +0800, Chih-Wei Huang wrote: > > > Note this patch breaks drm_gralloc: > > > > > > FAILED: > > > out/target/product/x86_64/obj_x86/SHA

Re: [PATCH libdrm] intel: annotate the intel genx helpers as private

2018-09-13 Thread Lucas De Marchi
+Chris On 9/13/18 12:19 AM, Chih-Wei Huang wrote: Note this patch breaks drm_gralloc: FAILED: out/target/product/x86_64/obj_x86/SHARED_LIBRARIES/libgralloc_drm_intermediates/LINKED/libgralloc_drm.so /bin/bash -c "prebuilts/clang/host/linux-x86/clang-4053586/bin/clang++ -nostdlib -Wl,-soname,li

Re: [PATCH libdrm] intel: annotate the intel genx helpers as private

2018-09-13 Thread Rodrigo Vivi
On Thu, Sep 13, 2018 at 09:45:47AM +0100, Eric Engestrom wrote: > On Thursday, 2018-09-13 15:19:00 +0800, Chih-Wei Huang wrote: > > Note this patch breaks drm_gralloc: > > > > FAILED: > > out/target/product/x86_64/obj_x86/SHARED_LIBRARIES/libgralloc_drm_intermediates/LINKED/libgralloc_drm.so > >

Re: [PATCH libdrm] intel: annotate the intel genx helpers as private

2018-09-13 Thread Eric Engestrom
On Thursday, 2018-09-13 15:19:00 +0800, Chih-Wei Huang wrote: > Note this patch breaks drm_gralloc: > > FAILED: > out/target/product/x86_64/obj_x86/SHARED_LIBRARIES/libgralloc_drm_intermediates/LINKED/libgralloc_drm.so > /bin/bash -c "prebuilts/clang/host/linux-x86/clang-4053586/bin/clang++ > -no

Re: [PATCH libdrm] intel: annotate the intel genx helpers as private

2018-09-13 Thread Chih-Wei Huang
Note this patch breaks drm_gralloc: FAILED: out/target/product/x86_64/obj_x86/SHARED_LIBRARIES/libgralloc_drm_intermediates/LINKED/libgralloc_drm.so /bin/bash -c "prebuilts/clang/host/linux-x86/clang-4053586/bin/clang++ -nostdlib -Wl,-soname,libgralloc_drm.so -Wl,--gc-sections -shared out/target/

Re: [PATCH libdrm] intel: annotate the intel genx helpers as private

2018-09-12 Thread Rodrigo Vivi
On Wed, Sep 12, 2018 at 08:50:54AM -0700, Rodrigo Vivi wrote: > From: Emil Velikov > > They're used internally and never meant to be part of the API. > Add the drm_private notation, which should resolve that. > > v2: (Rodrigo) Add missing include. > v3: (Rodrigo) Keep includes grouped per Eric s

[PATCH libdrm] intel: annotate the intel genx helpers as private

2018-09-12 Thread Rodrigo Vivi
From: Emil Velikov They're used internally and never meant to be part of the API. Add the drm_private notation, which should resolve that. v2: (Rodrigo) Add missing include. v3: (Rodrigo) Keep includes grouped per Eric suggestion. Cc: Eric Engestrom Cc: Lucas De Marchi Cc: Chris Wilson Cc: R

Re: [PATCH libdrm] intel: annotate the intel genx helpers as private

2018-09-12 Thread Eric Engestrom
On Tuesday, 2018-09-11 14:22:24 -0700, Rodrigo Vivi wrote: > From: Emil Velikov > > They're used internally and never meant to be part of the API. > Add the drm_private notation, which should resolve that. > > v2: (Rodrigo) Add missing include. > > Cc: Eric Engestrom > Cc: Lucas De Marchi > C

[PATCH libdrm] intel: annotate the intel genx helpers as private

2018-09-11 Thread Rodrigo Vivi
From: Emil Velikov They're used internally and never meant to be part of the API. Add the drm_private notation, which should resolve that. v2: (Rodrigo) Add missing include. Cc: Eric Engestrom Cc: Lucas De Marchi Cc: Chris Wilson Cc: Rodrigo Vivi Fixes: 4e81d4f9c9b ("intel: add generic func

Re: [PATCH libdrm] intel: annotate the intel genx helpers as private

2018-09-06 Thread Lucas De Marchi
On Thu, Sep 06, 2018 at 06:59:33PM +0100, Chris Wilson wrote: > Quoting Lucas De Marchi (2018-09-06 18:51:37) > > On Thu, Sep 06, 2018 at 06:38:52PM +0100, Chris Wilson wrote: > > > Quoting Emil Velikov (2018-09-06 16:14:07) > > > > From: Emil Velikov > > > > > > > > They're used internally and n

Re: [PATCH libdrm] intel: annotate the intel genx helpers as private

2018-09-06 Thread Chris Wilson
Quoting Lucas De Marchi (2018-09-06 18:51:37) > On Thu, Sep 06, 2018 at 06:38:52PM +0100, Chris Wilson wrote: > > Quoting Emil Velikov (2018-09-06 16:14:07) > > > From: Emil Velikov > > > > > > They're used internally and never meant to be part of the API. > > > Add the drm_private notation, whic

Re: [PATCH libdrm] intel: annotate the intel genx helpers as private

2018-09-06 Thread Lucas De Marchi
On Thu, Sep 06, 2018 at 06:38:52PM +0100, Chris Wilson wrote: > Quoting Emil Velikov (2018-09-06 16:14:07) > > From: Emil Velikov > > > > They're used internally and never meant to be part of the API. > > Add the drm_private notation, which should resolve that. > > > > Cc: Eric Engestrom > > Cc

Re: [PATCH libdrm] intel: annotate the intel genx helpers as private

2018-09-06 Thread Lucas De Marchi
On Thu, Sep 06, 2018 at 04:14:07PM +0100, Emil Velikov wrote: > From: Emil Velikov > > They're used internally and never meant to be part of the API. > Add the drm_private notation, which should resolve that. > > Cc: Eric Engestrom > Cc: Lucas De Marchi > Cc: Chris Wilson > Cc: Rodrigo Vivi

Re: [PATCH libdrm] intel: annotate the intel genx helpers as private

2018-09-06 Thread Chris Wilson
Quoting Emil Velikov (2018-09-06 16:14:07) > From: Emil Velikov > > They're used internally and never meant to be part of the API. > Add the drm_private notation, which should resolve that. > > Cc: Eric Engestrom > Cc: Lucas De Marchi > Cc: Chris Wilson > Cc: Rodrigo Vivi > Fixes: 4e81d4f9c9

[PATCH libdrm] intel: annotate the intel genx helpers as private

2018-09-06 Thread Emil Velikov
From: Emil Velikov They're used internally and never meant to be part of the API. Add the drm_private notation, which should resolve that. Cc: Eric Engestrom Cc: Lucas De Marchi Cc: Chris Wilson Cc: Rodrigo Vivi Fixes: 4e81d4f9c9b ("intel: add generic functions to check PCI ID") Signed-off-b