Re: [PATCH libdrm] amdgpu/basic_tests.c: check for fork

2019-03-12 Thread Fabrice Fontaine
OK, then will you accept a patch that disable amdgpu test if fork is not available or a patch that disable all tests (for example through a --disable-test-programs option)? Currently, the user can only disable the cairo tests so the whole libdrm package fails to statically build with uclibc-ng on A

Re: [PATCH libdrm] amdgpu/basic_tests.c: check for fork

2019-03-12 Thread Fabrice Fontaine
OK, thanks for your input, I'll disable amdgpu on platforms without MMU. Fabrice Le lun. 11 mars 2019 à 18:40, Koenig, Christian a écrit : > > Am 11.03.19 um 18:17 schrieb Fabrice Fontaine: > > OK, then will you accept a patch that disable amdgpu test if fork is > > not available or a patch tha

Re: [PATCH libdrm] amdgpu/basic_tests.c: check for fork

2019-03-12 Thread Koenig, Christian
AH, enlightenment! Yeah, the whole kernel driver won't work on no-mmu platforms. So compiling the userspace parts doesn't make any sense either. Thanks for clearing that up, it wasn't obvious to me why we had this limitation here. Regards, Christian. Am 11.03.19 um 23:25 schrieb Fabrice Fonta

Re: [PATCH libdrm] amdgpu/basic_tests.c: check for fork

2019-03-11 Thread Koenig, Christian
Am 11.03.19 um 18:17 schrieb Fabrice Fontaine: > OK, then will you accept a patch that disable amdgpu test if fork is > not available or a patch that disable all tests (for example through a > --disable-test-programs option)? No, we really need to test the correct behavior of fork() with userptrs.

Re: [PATCH libdrm] amdgpu/basic_tests.c: check for fork

2019-03-11 Thread Christian König
Well NAK, cause that obviously would break the test if fork() isn't available. We certainly don't have any platform where we support amdgpu and fork() is not available, so that change is rather pointless in the first place. Christian. Am 10.03.19 um 10:44 schrieb Fabrice Fontaine: amdgpu te

[PATCH libdrm] amdgpu/basic_tests.c: check for fork

2019-03-11 Thread Fabrice Fontaine
amdgpu test program use fork since https://cgit.freedesktop.org/mesa/drm/commit/tests/amdgpu/basic_tests.c?id=736ef0b61cab55378202c5f49d91799cc2b99091 However, this function is not always available so add a check for it in configure.ac and use it in tests/amdgpu/basic_tests.c Fixes: - http://au