Re: [PATCH hwc v2 14/18] drm_hwcomposer: Fix race in ApplyFrame

2018-04-18 Thread Alexandru-Cosmin Gheorghe
On Tue, Apr 17, 2018 at 01:02:18PM -0400, Sean Paul wrote: > On Wed, Apr 11, 2018 at 04:22:25PM +0100, Alexandru Gheorghe wrote: > > ApplyFrame holds the lock just when it swaps the value of > > active_composition_, in a multithread context we could end up in a > > situation where something is show

Re: [PATCH hwc v2 14/18] drm_hwcomposer: Fix race in ApplyFrame

2018-04-17 Thread Sean Paul
On Wed, Apr 11, 2018 at 04:22:25PM +0100, Alexandru Gheorghe wrote: > ApplyFrame holds the lock just when it swaps the value of > active_composition_, in a multithread context we could end up in a > situation where something is shown on the screen, but something else > is set in active_composition_

[PATCH hwc v2 14/18] drm_hwcomposer: Fix race in ApplyFrame

2018-04-11 Thread Alexandru Gheorghe
ApplyFrame holds the lock just when it swaps the value of active_composition_, in a multithread context we could end up in a situation where something is shown on the screen, but something else is set in active_composition_. Fix it by holding the lock during CommitFrame. Signed-off-by: Alexandru G