Re: [PATCH hwc v2 02/18] drm_hwcomposer: vsyncworker: Fix deadlock on exit path

Hi Sean, On Mon, Apr 16, 2018 at 03:25:42PM -0400, Sean Paul wrote: > On Wed, Apr 11, 2018 at 04:22:13PM +0100, Alexandru Gheorghe wrote: > > vsyncworker::Routine assumes that when -EINTR is returned by > > WaitForSignalOrExitLocked the lock as been released, which is not > > true, so it hangs if

Re: [PATCH hwc v2 02/18] drm_hwcomposer: vsyncworker: Fix deadlock on exit path

On Wed, Apr 11, 2018 at 04:22:13PM +0100, Alexandru Gheorghe wrote: > vsyncworker::Routine assumes that when -EINTR is returned by > WaitForSignalOrExitLocked the lock as been released, which is not > true, so it hangs if a vsyncworker is never enabled and Exit is > called. > > There are two code

Re: [PATCH hwc v2 02/18] drm_hwcomposer: vsyncworker: Fix deadlock on exit path

Hey Alexandru, Feel free my SoB on this patch: Signed-off-by: Robert Foss Rob. On 04/11/2018 05:22 PM, Alexandru Gheorghe wrote: vsyncworker::Routine assumes that when -EINTR is returned by WaitForSignalOrExitLocked the lock as been released, which is not true, so it hangs if a vsyncworker

[PATCH hwc v2 02/18] drm_hwcomposer: vsyncworker: Fix deadlock on exit path

vsyncworker::Routine assumes that when -EINTR is returned by WaitForSignalOrExitLocked the lock as been released, which is not true, so it hangs if a vsyncworker is never enabled and Exit is called. There are two code paths in WaitForSignalOrExitLocked that return -EINTR, one releases the lock the