[alsa-devel] [PATCH V5 3/3] ASoC: AMD: add AMD ASoC ACP-I2S driver

2015-08-25 Thread Mark Brown
On Tue, Aug 25, 2015 at 03:26:54PM +0530, maruthi srinivas wrote: > On Tue, Aug 25, 2015 at 11:36 AM, Mark Brown wrote: > > Please explain this in more detail, shared register ranges are very > > common and are the sort of things MFDs are supposed to help with. > In our case, ACP I2S driver need

[alsa-devel] [PATCH V5 3/3] ASoC: AMD: add AMD ASoC ACP-I2S driver

2015-08-25 Thread maruthi srinivas
On Tue, Aug 25, 2015 at 11:36 AM, Mark Brown wrote: > On Mon, Aug 24, 2015 at 04:08:31PM -0400, Alex Deucher wrote: >> On Fri, Aug 21, 2015 at 12:17 PM, Mark Brown wrote: > >> > What I'm looking for is actual code sharing where we use the same code >> > for the I2S controller block or a clear and

[alsa-devel] [PATCH V5 3/3] ASoC: AMD: add AMD ASoC ACP-I2S driver

2015-08-25 Thread Mark Brown
On Mon, Aug 24, 2015 at 04:08:31PM -0400, Alex Deucher wrote: > On Fri, Aug 21, 2015 at 12:17 PM, Mark Brown wrote: > > What I'm looking for is actual code sharing where we use the same code > > for the I2S controller block or a clear and documented understanding of > > why it is not possible to

[alsa-devel] [PATCH V5 3/3] ASoC: AMD: add AMD ASoC ACP-I2S driver

2015-08-24 Thread Alex Deucher
On Fri, Aug 21, 2015 at 12:17 PM, Mark Brown wrote: > On Fri, Aug 21, 2015 at 05:21:07PM +0530, maruthi srinivas wrote: >> On Fri, Aug 21, 2015 at 4:48 AM, Mark Brown wrote: > >> > We already have a driver for the DesignWare I2S controller. To repeat >> > the concern I raised in a slightly diffe

[alsa-devel] [PATCH V5 3/3] ASoC: AMD: add AMD ASoC ACP-I2S driver

2015-08-21 Thread maruthi srinivas
On Fri, Aug 21, 2015 at 4:48 AM, Mark Brown wrote: > > On Thu, Aug 20, 2015 at 05:36:34PM -0400, Alex Deucher wrote: > > From: Maruthi Srinivas Bayyavarapu > > > > ACP IP block consists of dedicated DMA and I2S blocks. The PCM driver > > provides the DMA and CPU DAI components to ALSA core. > > T

[alsa-devel] [PATCH V5 3/3] ASoC: AMD: add AMD ASoC ACP-I2S driver

2015-08-21 Thread Mark Brown
On Fri, Aug 21, 2015 at 05:21:07PM +0530, maruthi srinivas wrote: > On Fri, Aug 21, 2015 at 4:48 AM, Mark Brown wrote: > > We already have a driver for the DesignWare I2S controller. To repeat > > the concern I raised in a slightly different bit of the code last time: > > | This doesn't appear

[PATCH V5 3/3] ASoC: AMD: add AMD ASoC ACP-I2S driver

2015-08-20 Thread Alex Deucher
On Thu, Aug 20, 2015 at 7:18 PM, Mark Brown wrote: > On Thu, Aug 20, 2015 at 05:36:34PM -0400, Alex Deucher wrote: >> From: Maruthi Srinivas Bayyavarapu >> >> ACP IP block consists of dedicated DMA and I2S blocks. The PCM driver >> provides the DMA and CPU DAI components to ALSA core. > > This is

[PATCH V5 3/3] ASoC: AMD: add AMD ASoC ACP-I2S driver

2015-08-20 Thread Alex Deucher
From: Maruthi Srinivas Bayyavarapu ACP IP block consists of dedicated DMA and I2S blocks. The PCM driver provides the DMA and CPU DAI components to ALSA core. Signed-off-by: Maruthi Bayyavarapu Reviewed-by: Alex Deucher Reviewed-by: Murali Krishna Vemuri Signed-off-by: Alex Deucher --- v2:

[PATCH V5 3/3] ASoC: AMD: add AMD ASoC ACP-I2S driver

2015-08-20 Thread Mark Brown
On Thu, Aug 20, 2015 at 05:36:34PM -0400, Alex Deucher wrote: > From: Maruthi Srinivas Bayyavarapu > > ACP IP block consists of dedicated DMA and I2S blocks. The PCM driver > provides the DMA and CPU DAI components to ALSA core. This is flagged as patch 3/3 but appears to be sent as a single pat