Re: [PATCH V4 6/8] backlight: qcom-wled: Add support for WLED4 peripheral

2018-08-07 Thread Bjorn Andersson
On Mon 09 Jul 03:22 PDT 2018, Kiran Gunda wrote: > WLED4 peripheral is present on some PMICs like pmi8998 and > pm660l. It has a different register map and configurations > are also different. Add support for it. > > Signed-off-by: Kiran Gunda Reviewed-by: Bjorn Andersson Regards, Bjorn > --

Re: [PATCH V4 6/8] backlight: qcom-wled: Add support for WLED4 peripheral

2018-07-23 Thread kgunda
On 2018-07-21 02:51, Pavel Machek wrote: Hi! >@@ -332,6 +529,7 @@ static u32 wled_values(const struct wled_var_cfg *cfg, u32 idx) > } > #define WLED3 3 >+#defineWLED4 4 Are these macros always going to define 3 to be 3 and 4 to be 4. If so we probably don't need them (and they sh

Re: [PATCH V4 6/8] backlight: qcom-wled: Add support for WLED4 peripheral

2018-07-20 Thread Pavel Machek
Hi! > >@@ -332,6 +529,7 @@ static u32 wled_values(const struct wled_var_cfg *cfg, > >u32 idx) > > } > > #defineWLED3 3 > >+#define WLED4 4 > > Are these macros always going to define 3 to be 3 and 4 to be 4. If so we > probably don't need them (and they should be removed from patch

Re: [PATCH V4 6/8] backlight: qcom-wled: Add support for WLED4 peripheral

2018-07-20 Thread Daniel Thompson
On 09/07/18 11:22, Kiran Gunda wrote: WLED4 peripheral is present on some PMICs like pmi8998 and pm660l. It has a different register map and configurations are also different. Add support for it. Signed-off-by: Kiran Gunda --- Changes from V3: - The WLED3 specific changes are splitted o

[PATCH V4 6/8] backlight: qcom-wled: Add support for WLED4 peripheral

2018-07-09 Thread Kiran Gunda
WLED4 peripheral is present on some PMICs like pmi8998 and pm660l. It has a different register map and configurations are also different. Add support for it. Signed-off-by: Kiran Gunda --- Changes from V3: - The WLED3 specific changes are splitted out - Merged the wled3_sync_toggl