Re: [PATCH V3 2/3] drm/vkms: Add basic CRTC initialization

2018-10-23 Thread Emil Velikov
On Tue, 23 Oct 2018 at 00:57, Rodrigo Siqueira wrote: > > On 10/22, Emil Velikov wrote: > > Hi all, > > Hi Emil, > > Thanks for your feedback. > > > On Tue, 22 May 2018 at 02:07, Rodrigo Siqueira > > wrote: > > > > > +// SPDX-License-Identifier: GPL-2.0 > > > > This > > > > > +/* > > > + * This p

Re: [PATCH V3 2/3] drm/vkms: Add basic CRTC initialization

2018-10-22 Thread Rodrigo Siqueira
On 10/22, Emil Velikov wrote: > Hi all, Hi Emil, Thanks for your feedback. > On Tue, 22 May 2018 at 02:07, Rodrigo Siqueira > wrote: > > > +// SPDX-License-Identifier: GPL-2.0 > > This > > > +/* > > + * This program is free software; you can redistribute it and/or modify > > + * it under th

Re: [PATCH V3 2/3] drm/vkms: Add basic CRTC initialization

2018-10-22 Thread Emil Velikov
Hi all, On Tue, 22 May 2018 at 02:07, Rodrigo Siqueira wrote: > +// SPDX-License-Identifier: GPL-2.0 This > +/* > + * This program is free software; you can redistribute it and/or modify > + * it under the terms of the GNU General Public License as published by > + * the Free Software Foundati

Re: [PATCH V3 2/3] drm/vkms: Add basic CRTC initialization

2018-05-22 Thread Rodrigo Siqueira
I fixed it, and I'm preparing the v4 patchset. Thanks again for the review :) On Mon, May 21, 2018 at 11:57 PM, Haneen Mohammed wrote: > On Mon, May 21, 2018 at 10:06:40PM -0300, Rodrigo Siqueira wrote: > > This commit appends the essential CRTCs infrastructure for VKMS. CRTCs > > demands other

Re: [PATCH V3 2/3] drm/vkms: Add basic CRTC initialization

2018-05-22 Thread Haneen Mohammed
On Mon, May 21, 2018 at 10:06:40PM -0300, Rodrigo Siqueira wrote: > This commit appends the essential CRTCs infrastructure for VKMS. CRTCs > demands other elements to work correctly, in this sense, this patch adds > a new data struct that centralizes the data structures related to the > output, sim

[PATCH V3 2/3] drm/vkms: Add basic CRTC initialization

2018-05-21 Thread Rodrigo Siqueira
This commit appends the essential CRTCs infrastructure for VKMS. CRTCs demands other elements to work correctly, in this sense, this patch adds a new data struct that centralizes the data structures related to the output, simple planes management, and single encoder attached to the connector. Sign