Re: [PATCH V3 2/2] drm/bridge: ti-sn65dsi83: Add TI SN65DSI83 and SN65DSI84 driver

2021-05-10 Thread Marek Vasut
On 5/10/21 8:04 PM, Dave Stevenson wrote: Hi, [...] +static void sn65dsi83_enable(struct drm_bridge *bridge) +{ + struct sn65dsi83 *ctx = bridge_to_sn65dsi83(bridge); + unsigned int pval; + u16 val; + int ret; + + /* Clear reset, disable PLL */ + regmap_write(

Re: [PATCH V3 2/2] drm/bridge: ti-sn65dsi83: Add TI SN65DSI83 and SN65DSI84 driver

2021-05-10 Thread Dave Stevenson
On Mon, 10 May 2021 at 12:16, Marek Vasut wrote: > > On 5/10/21 11:58 AM, Dave Stevenson wrote: > > On Sat, 8 May 2021 at 21:26, Marek Vasut wrote: > >> > >> On 5/7/21 2:48 PM, Dave Stevenson wrote: > >> > >> [...] > >> > +static void sn65dsi83_enable(struct drm_bridge *bridge) > +{ > >

Re: [PATCH V3 2/2] drm/bridge: ti-sn65dsi83: Add TI SN65DSI83 and SN65DSI84 driver

2021-05-10 Thread Marek Vasut
On 5/10/21 11:58 AM, Dave Stevenson wrote: On Sat, 8 May 2021 at 21:26, Marek Vasut wrote: On 5/7/21 2:48 PM, Dave Stevenson wrote: [...] +static void sn65dsi83_enable(struct drm_bridge *bridge) +{ + struct sn65dsi83 *ctx = bridge_to_sn65dsi83(bridge); + unsigned int pval; +

Re: [PATCH V3 2/2] drm/bridge: ti-sn65dsi83: Add TI SN65DSI83 and SN65DSI84 driver

2021-05-10 Thread Dave Stevenson
On Sat, 8 May 2021 at 21:26, Marek Vasut wrote: > > On 5/7/21 2:48 PM, Dave Stevenson wrote: > > [...] > > >> +static void sn65dsi83_enable(struct drm_bridge *bridge) > >> +{ > >> + struct sn65dsi83 *ctx = bridge_to_sn65dsi83(bridge); > >> + unsigned int pval; > >> + u16 val; > >

Re: [PATCH V3 2/2] drm/bridge: ti-sn65dsi83: Add TI SN65DSI83 and SN65DSI84 driver

2021-05-08 Thread Marek Vasut
On 5/7/21 2:48 PM, Dave Stevenson wrote: [...] +static void sn65dsi83_enable(struct drm_bridge *bridge) +{ + struct sn65dsi83 *ctx = bridge_to_sn65dsi83(bridge); + unsigned int pval; + u16 val; + int ret; + + /* Clear reset, disable PLL */ + regmap_write(ctx-

Re: [PATCH V3 2/2] drm/bridge: ti-sn65dsi83: Add TI SN65DSI83 and SN65DSI84 driver

2021-05-08 Thread Marek Vasut
On 5/7/21 11:17 AM, Dave Stevenson wrote: On Thu, 6 May 2021 at 21:51, Marek Vasut wrote: On 5/6/21 6:03 PM, Frieder Schrempf wrote: On 06.05.21 17:46, Marek Vasut wrote: On 5/6/21 5:38 PM, Frieder Schrempf wrote: [...] Works on i.MX8MM with SN65DSI84 and a single link LVDS display (1024x60

Re: [PATCH V3 2/2] drm/bridge: ti-sn65dsi83: Add TI SN65DSI83 and SN65DSI84 driver

2021-05-07 Thread Dave Stevenson
On Wed, 5 May 2021 at 11:03, Marek Vasut wrote: > > Add driver for TI SN65DSI83 Single-link DSI to Single-link LVDS bridge > and TI SN65DSI84 Single-link DSI to Dual-link or 2x Single-link LVDS > bridge. TI SN65DSI85 is unsupported due to lack of hardware to test on, > but easy to add. > > The dri

Re: [PATCH V3 2/2] drm/bridge: ti-sn65dsi83: Add TI SN65DSI83 and SN65DSI84 driver

2021-05-07 Thread Dave Stevenson
On Thu, 6 May 2021 at 21:51, Marek Vasut wrote: > > On 5/6/21 6:03 PM, Frieder Schrempf wrote: > > On 06.05.21 17:46, Marek Vasut wrote: > >> On 5/6/21 5:38 PM, Frieder Schrempf wrote: > >> [...] > >>> Works on i.MX8MM with SN65DSI84 and a single link LVDS display (1024x600) > >>> and from my per

Re: [PATCH V3 2/2] drm/bridge: ti-sn65dsi83: Add TI SN65DSI83 and SN65DSI84 driver

2021-05-07 Thread Dave Stevenson
On Thu, 6 May 2021 at 21:49, Marek Vasut wrote: > > On 5/6/21 7:03 PM, Dave Stevenson wrote: > > On Thu, 6 May 2021 at 13:48, Marek Vasut wrote: > >> > >> On 5/6/21 11:45 AM, Dave Stevenson wrote: > >>> Hi Marek > >> > >> Hi, > >> > >>> I'm taking an interest as there are a number of Raspberry Pi

Re: [PATCH V3 2/2] drm/bridge: ti-sn65dsi83: Add TI SN65DSI83 and SN65DSI84 driver

2021-05-06 Thread Marek Vasut
On 5/6/21 6:03 PM, Frieder Schrempf wrote: On 06.05.21 17:46, Marek Vasut wrote: On 5/6/21 5:38 PM, Frieder Schrempf wrote: [...] Works on i.MX8MM with SN65DSI84 and a single link LVDS display (1024x600) and from my perspective everything else also looks good. Thanks for your work! I have two

Re: [PATCH V3 2/2] drm/bridge: ti-sn65dsi83: Add TI SN65DSI83 and SN65DSI84 driver

2021-05-06 Thread Marek Vasut
On 5/6/21 7:03 PM, Dave Stevenson wrote: On Thu, 6 May 2021 at 13:48, Marek Vasut wrote: On 5/6/21 11:45 AM, Dave Stevenson wrote: Hi Marek Hi, I'm taking an interest as there are a number of Raspberry Pi users trying to get this chip up and running (not there quite yet). A couple of fair

Re: [PATCH V3 2/2] drm/bridge: ti-sn65dsi83: Add TI SN65DSI83 and SN65DSI84 driver

2021-05-06 Thread Dave Stevenson
On Thu, 6 May 2021 at 13:48, Marek Vasut wrote: > > On 5/6/21 11:45 AM, Dave Stevenson wrote: > > Hi Marek > > Hi, > > > I'm taking an interest as there are a number of Raspberry Pi users > > trying to get this chip up and running (not there quite yet). > > A couple of fairly minor comments > > Is

Re: [PATCH V3 2/2] drm/bridge: ti-sn65dsi83: Add TI SN65DSI83 and SN65DSI84 driver

2021-05-06 Thread Frieder Schrempf
On 06.05.21 17:46, Marek Vasut wrote: > On 5/6/21 5:38 PM, Frieder Schrempf wrote: > [...] >> Works on i.MX8MM with SN65DSI84 and a single link LVDS display (1024x600) >> and from my perspective everything else also looks good. Thanks for your >> work! >> >> I have two remarks: >> >> 1. In my tes

Re: [PATCH V3 2/2] drm/bridge: ti-sn65dsi83: Add TI SN65DSI83 and SN65DSI84 driver

2021-05-06 Thread Marek Vasut
On 5/6/21 5:38 PM, Frieder Schrempf wrote: [...] Works on i.MX8MM with SN65DSI84 and a single link LVDS display (1024x600) and from my perspective everything else also looks good. Thanks for your work! I have two remarks: 1. In my test I couldn't get it to work with four DSI lanes enabled (onl

Re: [PATCH V3 2/2] drm/bridge: ti-sn65dsi83: Add TI SN65DSI83 and SN65DSI84 driver

2021-05-06 Thread Frieder Schrempf
On 05.05.21 12:02, Marek Vasut wrote: > Add driver for TI SN65DSI83 Single-link DSI to Single-link LVDS bridge > and TI SN65DSI84 Single-link DSI to Dual-link or 2x Single-link LVDS > bridge. TI SN65DSI85 is unsupported due to lack of hardware to test on, > but easy to add. > > The driver operates

Re: [PATCH V3 2/2] drm/bridge: ti-sn65dsi83: Add TI SN65DSI83 and SN65DSI84 driver

2021-05-06 Thread Marek Vasut
On 5/6/21 3:03 PM, Laurent Pinchart wrote: Hi Marek, Hi, On Thu, May 06, 2021 at 02:48:11PM +0200, Marek Vasut wrote: On 5/6/21 11:45 AM, Dave Stevenson wrote: Hi Marek Hi, I'm taking an interest as there are a number of Raspberry Pi users trying to get this chip up and running (not the

Re: [PATCH V3 2/2] drm/bridge: ti-sn65dsi83: Add TI SN65DSI83 and SN65DSI84 driver

2021-05-06 Thread Laurent Pinchart
Hi Marek, On Thu, May 06, 2021 at 02:48:11PM +0200, Marek Vasut wrote: > On 5/6/21 11:45 AM, Dave Stevenson wrote: > > Hi Marek > > Hi, > > > I'm taking an interest as there are a number of Raspberry Pi users > > trying to get this chip up and running (not there quite yet). > > A couple of fairl

Re: [PATCH V3 2/2] drm/bridge: ti-sn65dsi83: Add TI SN65DSI83 and SN65DSI84 driver

2021-05-06 Thread Marek Vasut
On 5/6/21 11:45 AM, Dave Stevenson wrote: Hi Marek Hi, I'm taking an interest as there are a number of Raspberry Pi users trying to get this chip up and running (not there quite yet). A couple of fairly minor comments Is there any readily available display unit / expansion board with this

Re: [PATCH V3 2/2] drm/bridge: ti-sn65dsi83: Add TI SN65DSI83 and SN65DSI84 driver

2021-05-06 Thread Dave Stevenson
Hi Marek I'm taking an interest as there are a number of Raspberry Pi users trying to get this chip up and running (not there quite yet). A couple of fairly minor comments On Wed, 5 May 2021 at 11:03, Marek Vasut wrote: > > Add driver for TI SN65DSI83 Single-link DSI to Single-link LVDS bridge >

Re: [PATCH V3 2/2] drm/bridge: ti-sn65dsi83: Add TI SN65DSI83 and SN65DSI84 driver

2021-05-05 Thread Linus Walleij
On Wed, May 5, 2021 at 12:03 PM Marek Vasut wrote: > Add driver for TI SN65DSI83 Single-link DSI to Single-link LVDS bridge > and TI SN65DSI84 Single-link DSI to Dual-link or 2x Single-link LVDS > bridge. TI SN65DSI85 is unsupported due to lack of hardware to test on, > but easy to add. > > The d

[PATCH V3 2/2] drm/bridge: ti-sn65dsi83: Add TI SN65DSI83 and SN65DSI84 driver

2021-05-05 Thread Marek Vasut
Add driver for TI SN65DSI83 Single-link DSI to Single-link LVDS bridge and TI SN65DSI84 Single-link DSI to Dual-link or 2x Single-link LVDS bridge. TI SN65DSI85 is unsupported due to lack of hardware to test on, but easy to add. The driver operates the chip via I2C bus. Currently the LVDS clock ar