[PATCH V3] drm/sched: Fix fence reference count leak

2025-03-10 Thread Qianyi Liu
> Sorry for the delay > > On Wed, 2025-02-26 at 17:05 +0800, Qianyi Liu wrote: >> From: qianyi liu >> >> The last_scheduled fence leaked when an entity was being killed and >> adding its callback failed. > > s/leaked/leaks > > s/was being/is being > > s/its callback/the cleanup callback > > s/fail

Re: [PATCH V3] drm/sched: Fix fence reference count leak

2025-03-10 Thread Philipp Stanner
Sorry for the delay On Wed, 2025-02-26 at 17:05 +0800, Qianyi Liu wrote: > From: qianyi liu > > The last_scheduled fence leaked when an entity was being killed and > adding its callback failed. s/leaked/leaks s/was being/is being s/its callback/the cleanup callback s/failed/fails > > Decr

[PATCH V3] drm/sched: Fix fence reference count leak

2025-03-10 Thread Qianyi Liu
>> The last_scheduled fence leaked when an entity was being killed and >> adding its callback failed. >> >> Decrement the reference count of prev when dma_fence_add_callback() >> fails, ensuring proper balance. >> >> Cc: sta...@vger.kernel.org >> Fixes: 2fdb8a8f07c2 ("drm/scheduler: rework entity f

Re: [PATCH V3] drm/sched: Fix fence reference count leak

2025-02-26 Thread Philipp Stanner
On Wed, 2025-02-26 at 17:05 +0800, Qianyi Liu wrote: > From: qianyi liu > > The last_scheduled fence leaked when an entity was being killed and > adding its callback failed. > > Decrement the reference count of prev when dma_fence_add_callback() > fails, ensuring proper balance. > > Cc: sta...@

[PATCH V3] drm/sched: Fix fence reference count leak

2025-02-26 Thread Qianyi Liu
From: qianyi liu The last_scheduled fence leaked when an entity was being killed and adding its callback failed. Decrement the reference count of prev when dma_fence_add_callback() fails, ensuring proper balance. Cc: sta...@vger.kernel.org Fixes: 2fdb8a8f07c2 ("drm/scheduler: rework entity flus